Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=494283
--- Comment #5 from Kalev Lember <kalev(a)smartlink.ee> 2009-04-07 05:03:42 EDT ---
Thanks for your very fast review, Thomas.
Richard Jones said he is not familiar with how the sponsorship system works and
that he'll try setting fedora‑cvs? flag for me. That's why I requested CVS
without being sponsored.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=494283
--- Comment #4 from Thomas Sailer <t.sailer(a)alumni.ethz.ch> 2009-04-07 04:37:06 EDT ---
I think you first need a sponsor, then get a fedora account, before you can
request CVS...
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=494283
Richard W.M. Jones <rjones(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rjones(a)redhat.com
Flag| |fedora-cvs?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=494283
--- Comment #3 from Kalev Lember <kalev(a)smartlink.ee> 2009-04-07 04:29:09 EDT ---
New Package CVS Request
=======================
Package Name: mingw32-libp11
Short Description: MingGW Windows libp11 library
Owners: kalev rjones
Branches: F-10
InitialCC:
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=494283
Thomas Sailer <t.sailer(a)alumni.ethz.ch> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-review+
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=494283
--- Comment #2 from Thomas Sailer <t.sailer(a)alumni.ethz.ch> 2009-04-06 18:30:58 EDT ---
+ rpmlint output
+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
LGPLv2+
+ license matches the actual package license
+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
9e2c5cbececde245e2d2f535bd49ce35 libp11-0.2.4.tar.gz
9e2c5cbececde245e2d2f535bd49ce35 p/libp11-0.2.4.tar.gz
+ package successfully builds on at least one architecture
noarch
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun
+ does not use Prefix: /usr
+ package owns all directories it creates
+ no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
n/a header files should be in -devel
ok for mingw packages to have headers
n/a static libraries should be in -static
+ packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a -devel must require the fully versioned base
+ packages should not contain libtool .la files
allowed according to http://fedoraproject.org/wiki/Packaging/MinGW
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8
Optional:
n/a if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if
available
n/a reviewer should build the package in mock
+ the package should build into binary RPMs on all supported architectures
n/a review should test the package functions as described
n/a scriptlets should be sane
n/a pkgconfig files should go in -devel
n/a shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin
APPROVED by sailer
Note: I am not a sponsor, I cannot sponsor you
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=494283
Thomas Sailer <t.sailer(a)alumni.ethz.ch> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |t.sailer(a)alumni.ethz.ch
--- Comment #1 from Thomas Sailer <t.sailer(a)alumni.ethz.ch> 2009-04-06 18:20:46 EDT ---
rpmlint:
mingw32-libp11.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libp11.dll.a
mingw32-libp11.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libp11.dll.a
mingw32-libp11.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/libp11.h
mingw32-libp11.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/pkgconfig/libp11.pc
mingw32-libp11.noarch: E: script-without-shebang
/usr/i686-pc-mingw32/sys-root/mingw/lib/libp11.la
mingw32-libp11.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libp11.dll.a
mingw32-libp11.noarch: W: non-standard-dir-in-usr i686-pc-mingw32
2 packages and 1 specfiles checked; 2 errors, 5 warnings.
(this is f10 rpmlint, f11 rpmlint would not have complained)
These can be ignored as per: http://fedoraproject.org/wiki/MinGW/Rpmlint
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=494283
Kalev Lember <kalev(a)smartlink.ee> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Review |Review Request:
|Request:mingw32-libp11 - |mingw32-libp11 - MingGW
|MingGW Windows libp11 |Windows libp11 library
|library |
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.