https://bugzilla.redhat.com/show_bug.cgi?id=819670
--- Comment #14 from Eric Smith <eric(a)brouhaha.com> ---
Thanks Michael! I'll look into why it wanted the native C++ compiler. I'm
also working on updating this to llvm 3.1, which does have to build a native
executable for llvm-config, which was formerly a script, so 3.1 will definitely
need a native compiler.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=819670
Eric Smith <eric(a)brouhaha.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-cvs?
--- Comment #13 from Eric Smith <eric(a)brouhaha.com> ---
New Package SCM Request
=======================
Package Name: mingw-llvm
Short Description: MinGW LLVM libraries for cross-development use
Owners: brouhaha
Branches: f17 el6
InitialCC:
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=825557
--- Comment #5 from greg.hellings(a)gmail.com ---
(In reply to comment #4)
> (In reply to comment #3)
> > I have uploaded an updated spec and src.rpm file to
> > the same URLs as above if anyone else wants to take a look.
>
> Please bump the release and upload a new .src.rpm every time you make a
> change. This makes it easier to compare changes between versions
Noted. I figured the bumps should only happen once an actual build was
released. My bad.
>
> Some additional review comments:
> - The CMake argument -DDISABLE_MULTITHREADING=ON and
> -D_CL_HAVE_WIN32_THREADS=0 are used in both the MINGW32_CMAKE_ARGS and the
> MINGW64_CMAKE_ARGS. To reduce duplication, you might want to move these to
> the %mingw_cmake call
I still hope to fix the issue regarding threads on 32-bit architecture, as I
know the 32-bit version can be built with threading support. Hence why I want
to keep them separated until I can focus on that.
> - The %clean section can be removed completely
Will do.
> - Why are the files %{mingw32_libdir}/CLuceneConfig.cmake and
> %{mingw64_libdir}/CLuceneConfig.cmake dropped but not the files
> %{mingw32_libdir}/CLucene/CLuceneConfig.cmake and
> %{mingw64_libdir}/CLucene/CLuceneConfig.cmake. Shouldn't these two files be
> dropped as well?
The .cmake files are analagous to .pc files. Since they are supplied by the
CLucene team they should be maintained, but they shouldn't be placed in the
general %{mingw*_libdir}/ root.
> - The CMake arguments -DLUCENE_SYS_INCLUDES:PATH=%{mingw32_libdir} and
> -DLUCENE_SYS_INCLUDES:PATH=%{mingw64_libdir} shouldn't be needed for MinGW
> packages. It looks like the native Fedora CLucene package uses it for
> multilib support, but as Fedora MinGW doesn't use multilib this CMake
> argument shouldn't be needed for this package
I'll give it a go building without it and see how it works out.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=835686
Andreas Bierfert <andreas.bierfert(a)lowlatency.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Resolution|--- |RAWHIDE
Last Closed| |2012-07-05 11:23:02
--- Comment #14 from Andreas Bierfert <andreas.bierfert(a)lowlatency.de> ---
Thanks for the review!
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=835686
--- Comment #13 from Jon Ciesla <limburgher(a)gmail.com> ---
Git done (by process-git-requests).
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=835686
Andreas Bierfert <andreas.bierfert(a)lowlatency.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-cvs?
--- Comment #12 from Andreas Bierfert <andreas.bierfert(a)lowlatency.de> ---
New Package SCM Request
=======================
Package Name: wine-mono
Short Description: Mono library required for Wine
Owners: awjb
Branches: f17
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=835686
Michael Cronenworth <mike(a)cchtml.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #11 from Michael Cronenworth <mike(a)cchtml.com> ---
Looks good.
================================================
The package wine-mono is APPROVED by mooninite
================================================
--
You are receiving this mail because:
You are on the CC list for the bug.