https://bugzilla.redhat.com/show_bug.cgi?id=957346
Marcel Wysocki <maci(a)satgnu.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-cvs?
--- Comment #8 from Marcel Wysocki <maci(a)satgnu.net> ---
New Package SCM Request
=======================
Package Name: mingw-physfs
Short Description: MinGW compiled physfs library to provide abstract access to
various archives
Owners: maci epienbro
Branches: f19 f20 epel7
InitialCC:
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=v3mbylSgtv&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=1096807
Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |erik-fedora(a)vanpienbroek.nl
Assignee|nobody(a)fedoraproject.org |erik-fedora(a)vanpienbroek.nl
--- Comment #1 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> ---
Taking for review
The BuildRequires mingw32-binutils and mingw64-binutils are unneeded and can be
removed
The Requires pkgconfig can also be removed (automatically added during build)
In the %files section the '%{mingw32_includedir}/SDL2' needs to be replaced
with '%{mingw32_includedir}/SDL2/*' as the folder in question is already owned
by the mingw-SDL2 package (same applies as well for the mingw64 section)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PrWvCUfvzt&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=1096796
Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |erik-fedora(a)vanpienbroek.nl
Assignee|nobody(a)fedoraproject.org |erik-fedora(a)vanpienbroek.nl
--- Comment #1 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> ---
Taking for review
The fedora-review flag needs to be set by the person doing the review. You
don't have to set it yourself.
The manual Requires tags (for pkgconfig and mingw32/64-win-iconv) are redundant
because they get added automatically during the build (by the
/usr/lib/rpm/mingw-find-requires.sh script). Therefore these can be removed.
Package looks good otherwise
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=49amBm4CqW&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=957346
Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #7 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> ---
My apologies on the long delay. I forgot about this review ticket. All issues
are resolved now:
==================================================
The package mingw-physfs is APPROVED by epienbro
==================================================
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aNyARh2ijk&a=cc_unsubscribe