[Bug 491617] New: Review Request: mingw32-libxml++ - MinGW Windows C++ wrapper for libxml2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: mingw32-libxml++ - MinGW Windows C++ wrapper for libxml2
Alias: mingw32-libxml++

https://bugzilla.redhat.com/show_bug.cgi?id=491617

Summary: Review Request: mingw32-libxml++ - MinGW Windows C++
                    wrapper for libxml2
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail],
                    [e-mail]
    Classification: Fedora

Spec URL: http://sailer.fedorapeople.org/mingw32-libxml++.spec
SRPM URL: http://sailer.fedorapeople.org/mingw32-libxml++-2.24.2-3.fc11.src.rpm
Description:
MinGW Windows C++ wrapper for libxml2.

Approved MinGW packaging guidelines are here:
http://fedoraproject.org/wiki/Packaging/MinGW

[Bug 491617] Review Request: mingw32-libxml++ - MinGW Windows C++ wrapper for libxml2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491617

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Kalev Lember   2009-03-24 13:47:54 EDT ---
This package needs mingw32-glibmm24, which isn't included in Fedora and has to
be submitted for review first.

Besides that, you'll also need:
BuildRequires: mingw32-gcc-c++

and pkgconfig because you have libxml++-2.6.pc in the package:
Requires: pkgconfig

Examples, manual, and reference shouldn't be included in the package because
they duplicate docs in the native Fedora package.

[Bug 491617] Review Request: mingw32-libxml++ - MinGW Windows C++ wrapper for libxml2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491617

--- Comment #2 from Thomas Sailer   2009-03-25 05:32:24 EDT ---
You are right, mingw32-glibmm24 should go in first, I unfortunately noticed
this only after submitting the review request.

Thank you for your intial review comments, I updated the package according to
your comments:
http://sailer.fedorapeople.org/mingw32-libxml++.spec
http://sailer.fedorapeople.org/mingw32-libxml++-2.24.2-4.fc11.src.rpm

[Bug 491617] Review Request: mingw32-libxml++ - MinGW Windows C++ wrapper for libxml2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491617

--- Comment #3 from Richard W.M. Jones   2009-03-25 06:13:00 EDT ---
Please note that we have packaged mingw32-glibmm24:
http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/gli...
It needs to be turned into a Review Request.

[Bug 491617] Review Request: mingw32-libxml++ - MinGW Windows C++ wrapper for libxml2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491617

Thomas Sailer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |492113(mingw32-glibmm24)

[Bug 491617] Review Request: mingw32-libxml++ - MinGW Windows C++ wrapper for libxml2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491617

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

Bug 491617 depends on bug 492113, which changed state.

Bug 492113 Summary: Review Request: mingw32-glibmm24 - MinGW Windows C++ interface for GTK2 (a GUI library for X)
https://bugzilla.redhat.com/show_bug.cgi?id=492113

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

--- Comment #4 from Kalev Lember   2009-04-16 15:52:15 EDT ---
mingw32-glibmm24 is now in Fedora and we can go on with this review.

- In Rawhide the native Fedora libxml++ package has been updated to 2.26.0, and
according to MinGW packaging guidelines the versions should match native
package if possible.

- Please clean up the %install section. It only makes the spec file unreadable
if most of a section contains leftovers that aren't actually used.

- Removing *.a in %install section only matches the (needed) import library,
because static libraries aren't built (configure --disable-static). It seems
unnecessary to first delete the import lib and then manually copy it over from
.libs.

[Bug 491617] Review Request: mingw32-libxml++ - MinGW Windows C++ wrapper for libxml2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491617

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 491617] Review Request: mingw32-libxml++ - MinGW Windows C++ wrapper for libxml2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491617

--- Comment #5 from Thomas Sailer   2009-04-17 03:46:49 EDT ---
Thanks!

I removed the docs cruft...

Spec URL: http://sailer.fedorapeople.org/mingw32-libxml++.spec
SRPM URL: http://sailer.fedorapeople.org/mingw32-libxml++-2.26.0-1.fc11.src.rpm

[Bug 491617] Review Request: mingw32-libxml++ - MinGW Windows C++ wrapper for libxml2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491617

--- Comment #6 from Kalev Lember   2009-04-17 06:50:09 EDT ---
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1303634

Rpmlint is quiet:
$ rpmlint mingw32-libxml++-2.26.0-1.fc11.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint mingw32-libxml++-2.26.0-1.fc11.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[Bug 491617] Review Request: mingw32-libxml++ - MinGW Windows C++ wrapper for libxml2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491617

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #7 from Kalev Lember   2009-04-17 07:36:17 EDT ---
Fedora review mingw32-libxml++-2.26.0-1.fc11.src.rpm 2008-04-17

+ OK
! needs attention

+ rpmlint output
+ Package is named according to Fedora MinGW packaging guidelines
+ Specfile name matches the package base name
+ Package follows the Fedora MinGW packaging guidelines
+ License meets guidelines and is acceptable to Fedora
  LGPLv2+
+ License matches the actual package license
  It is also the same as in the corresponding Fedora libxml++ package
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm
a52fc7e6e44bb5cc187672930b843f72  libxml++-2.26.0.tar.bz2
a52fc7e6e44bb5cc187672930b843f72  SRPM/libxml++-2.26.0.tar.bz2

+ Package builds in mock (Fedora Rawhide i586)
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun
+ Does not use Prefix: /usr
+ Package owns all directories it creates
+ No duplicate files in %files
+ %files has %defattr
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ Consistent use of macros
+ Package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
    Fedora MinGW guidelines allow headers in main package
n/a Static libraries should be in -static
+ Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
    Fedora MinGW guidelines allow .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Packages must not own files or directories owned by other packages
+ %install begins with rm -rf $RPM_BUILD_ROOT
+ Filenames must be valid UTF-8

After the %install cleanup dos2unix is no longer needed in BuildRequires, but
that can be fixed without having to send an updated version for me to approve.

Package APPROVED.

[Bug 491617] Review Request: mingw32-libxml++ - MinGW Windows C++ wrapper for libxml2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491617

Thomas Sailer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #8 from Thomas Sailer   2009-04-17 07:50:10 EDT ---
New Package CVS Request
=======================
Package Name: mingw32-libxml++
Short Description: MinGW Windows C++ wrapper for libxml2
Owners: sailer rjones
Branches: F-10 F-11
InitialCC:

[Bug 491617] Review Request: mingw32-libxml++ - MinGW Windows C++ wrapper for libxml2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491617

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #9 from Kevin Fenzi   2009-04-17 12:40:19 EDT ---
cvs done.

[Bug 491617] Review Request: mingw32-libxml++ - MinGW Windows C++ wrapper for libxml2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491617

--- Comment #10 from Fedora Update System   2009-04-17 16:59:00 EDT ---
mingw32-libxml++-2.26.0-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/mingw32-libxml++-2.26.0-1.fc11

[Bug 491617] Review Request: mingw32-libxml++ - MinGW Windows C++ wrapper for libxml2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491617

--- Comment #11 from Fedora Update System   2009-04-17 16:59:42 EDT ---
mingw32-libxml++-2.24.2-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/mingw32-libxml++-2.24.2-1.fc10

[Bug 491617] Review Request: mingw32-libxml++ - MinGW Windows C++ wrapper for libxml2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491617

--- Comment #12 from Fedora Update System   2009-04-21 20:48:46 EDT ---
mingw32-libxml++-2.24.2-1.fc10 has been pushed to the Fedora 10 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 491617] Review Request: mingw32-libxml++ - MinGW Windows C++ wrapper for libxml2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491617

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
   Fixed In Version|                            |2.24.2-1.fc10
         Resolution|                            |NEXTRELEASE

[Bug 491617] Review Request: mingw32-libxml++ - MinGW Windows C++ wrapper for libxml2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491617

--- Comment #13 from Fedora Update System   2009-05-09 00:04:22 EDT ---
mingw32-libxml++-2.26.0-1.fc11 has been pushed to the Fedora 11 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 491617] Review Request: mingw32-libxml++ - MinGW Windows C++ wrapper for libxml2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491617

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|2.24.2-1.fc10               |2.26.0-1.fc11