New mingw-nsis package apparent breakage

[Richard W.M. Jones]

Hello Sandro,

mingw-nsis failed to build in the F32 mass rebuild, so I have updated
the package to the latest version and fixed quite a few problems.

It now builds, but there are some seemingly serious problems with the
resulting package which make me reluctant to want to push anything to
Rawhide dist-git.  Instead I pushed my changes to a private branch so
you can play with them:

https://src.fedoraproject.org/rpms/mingw-nsis/commits/private-rjones-nsis305

(1) No debuginfo is built.

If debuginfo is enabled, the build fails with:
error: Empty %files file /home/rjones/d/fedora/mingw-nsis/master/nsis-3.05-src/debugsourcefiles.list

I haven't changed anything about debuginfo, so I'm not clear how
my changes caused this to happen.

(2) More seriously, some files are missing compared to the 3.04 package.

There is no /etc/nsisconf.nsh file, no /usr/bin/GenPat, and no
/usr/bin/makensis (without the .exe extension).

Rich.

[Sandro Mani]

Hello Richard

Yes indeed, I've looked into that one a while back, and haven't really 
been able to figure out why the build output is so different, even by 
looking at what look like relevant changes in the diff between the 3.04 
and 3.05 source trees. I'll try and give it another shot.

Sandro

On 30.01.20 11:47, Richard W.M. Jones wrote:
> Hello Sandro,
>
> mingw-nsis failed to build in the F32 mass rebuild, so I have updated
> the package to the latest version and fixed quite a few problems.
>
> It now builds, but there are some seemingly serious problems with the
> resulting package which make me reluctant to want to push anything to
> Rawhide dist-git.  Instead I pushed my changes to a private branch so
> you can play with them:
>
> https://src.fedoraproject.org/rpms/mingw-nsis/commits/private-rjones-nsis305
>
> (1) No debuginfo is built.
>
> If debuginfo is enabled, the build fails with:
> error: Empty %files file /home/rjones/d/fedora/mingw-nsis/master/nsis-3.05-src/debugsourcefiles.list
>
> I haven't changed anything about debuginfo, so I'm not clear how
> my changes caused this to happen.
>
> (2) More seriously, some files are missing compared to the 3.04 package.
>
> There is no /etc/nsisconf.nsh file, no /usr/bin/GenPat, and no
> /usr/bin/makensis (without the .exe extension).
>
> Rich.

[Sandro Mani]

Hello Richard

Yes indeed, I've looked into that one a while back, and haven't really 
been able to figure out why the build output is so different, even by 
looking at what look like relevant changes in the diff between the 3.04 
and 3.05 source trees. I'll try and give it another shot.

Sandro

On 30.01.20 11:47, Richard W.M. Jones wrote:
> Hello Sandro,
>
> mingw-nsis failed to build in the F32 mass rebuild, so I have updated
> the package to the latest version and fixed quite a few problems.
>
> It now builds, but there are some seemingly serious problems with the
> resulting package which make me reluctant to want to push anything to
> Rawhide dist-git.  Instead I pushed my changes to a private branch so
> you can play with them:
>
> https://src.fedoraproject.org/rpms/mingw-nsis/commits/private-rjones-nsis305
>
> (1) No debuginfo is built.
>
> If debuginfo is enabled, the build fails with:
> error: Empty %files file /home/rjones/d/fedora/mingw-nsis/master/nsis-3.05-src/debugsourcefiles.list
>
> I haven't changed anything about debuginfo, so I'm not clear how
> my changes caused this to happen.
>
> (2) More seriously, some files are missing compared to the 3.04 package.
>
> There is no /etc/nsisconf.nsh file, no /usr/bin/GenPat, and no
> /usr/bin/makensis (without the .exe extension).
>
> Rich.