Problem when cross compiling Gecko (ILocation not declared)

[Zhenbo Li]

Hello, everyone
I'm trying to use mingw-w64 to cross compile gecko (hg version), and,
I faced a problem:

1:59.33 In file included from
/home/lizhenbo/src/mozilla-central-upstream/dom/geolocation/nsGeolocation.cpp:53:0:
 1:59.33 /home/lizhenbo/src/mozilla-central-upstream/dom/system/windows/WindowsLocationProvider.h:43:12:
error: 'ILocation' was not declared in this scope
 1:59.33    nsRefPtr<ILocation> mLocation;
 1:59.33             ^
 1:59.33 /home/lizhenbo/src/mozilla-central-upstream/dom/system/windows/WindowsLocationProvider.h:43:21:
error: template argument 1 is invalid
 1:59.33    nsRefPtr<ILocation> mLocation;
 1:59.33

$ cat /usr/i686-w64-mingw32/sys-root/mingw/include/locationapi.h|grep
-w ILocation
And nothing is found

There is a patch by Jacek[0], has it been merged to trunk? What should
I do to cross compile gecko?

Thank you very much.

[0]: http://sourceforge.net/p/mingw-w64/mingw-w64/ci/7268caece9b4cb33ff698306e511...

[Michael Cronenworth]

On 04/28/2015 09:44 AM, Zhenbo Li wrote:
> There is a patch by Jacek[0], has it been merged to trunk? What should
> I do to cross compile gecko?

What MinGW environment are you using? Fedora 20, 21, 22, rawhide?

That patch is present in MinGW 4.0, which Fedora 21+ provides.

If all you need is gecko you should check out our Fedora wine-gecko package:
mingw-wine-gecko

Fedora rawhide: http://koji.fedoraproject.org/koji/buildinfo?buildID=618620

[Zhenbo Li]

Hi Michael,

2015-04-28 23:01 GMT+08:00 Michael Cronenworth :
> What MinGW environment are you using? Fedora 20, 21, 22, rawhide?

I'm using Fedora 21
> That patch is present in MinGW 4.0, which Fedora 21+ provides.

I extracted the locationapi.h[0] file from rpm[1] provides on koji[2],
and I can't find ILocation
> If all you need is gecko you should check out our Fedora wine-gecko package:
> mingw-wine-gecko

Well, I need the header files generated while compiling, so
mingw-wine-gecko is not enough.

[0]: https://gist.github.com/90ed779536577e4cc34e
[1]: https://kojipkgs.fedoraproject.org//packages/mingw-headers/4.0.1/1.fc21/noar...
[2]: http://koji.fedoraproject.org/koji/buildinfo?buildID=624513

[Michael Cronenworth]

On 04/28/2015 03:34 PM, Zhenbo Li wrote:
> I extracted the locationapi.h[0] file from rpm[1] provides on koji[2],
> and I can't find ILocation

The sourceforge git interface was lying. It shows the commit as in the branch, but 
it is not really in it.

As noted by Erik, upstream will have to backport.

[Erik van Pienbroek]

Zhenbo Li schreef op di 28-04-2015 om 22:44 [+0800]:
> Hello, everyone
> I'm trying to use mingw-w64 to cross compile gecko (hg version), and,
> I faced a problem:
>
> 1:59.33 In file included from
> /home/lizhenbo/src/mozilla-central
> -upstream/dom/geolocation/nsGeolocation.cpp:53:0:
>  1:59.33 /home/lizhenbo/src/mozilla-central
> -upstream/dom/system/windows/WindowsLocationProvider.h:43:12:
> error: 'ILocation' was not declared in this scope
>  1:59.33    nsRefPtr<ILocation> mLocation;
>  1:59.33             ^
>  1:59.33 /home/lizhenbo/src/mozilla-central
> -upstream/dom/system/windows/WindowsLocationProvider.h:43:21:
> error: template argument 1 is invalid
>  1:59.33    nsRefPtr<ILocation> mLocation;
>  1:59.33
>
> $ cat /usr/i686-w64-mingw32/sys-root/mingw/include/locationapi.h|grep
> -w ILocation
> And nothing is found
>
> There is a patch by Jacek[0], has it been merged to trunk? What 
> should
> I do to cross compile gecko?

Hi,

Apparently the required change is already available in upstream mingw
-w64 master: http://sourceforge.net/p/mingw-w64/mingw
-w64/ci/7268caece9b4cb33ff698306e51140b11d7656b0/
However, this change hasn't been backported to the v4.x branch yet.
I'll ask upstream mingw-w64 developers if they can backport the commit
in question to the v4.x branch after which I can prepare an updated
mingw-headers package for Fedora.

Regards,

Erik