Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: mingw32-WebKit - MinGW Windows web content engine library
https://bugzilla.redhat.com/show_bug.cgi?id=499992
Summary: Review Request: mingw32-WebKit - MinGW Windows web content engine library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: erik-fedora@vanpienbroek.nl QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com, fedora-mingw@lists.fedoraproject.org Depends on: 499983,499986,499991 Classification: Fedora
Spec URL: http://www.ftd4linux.nl/contrib/mingw32-WebKit.spec SRPM URL: http://www.ftd4linux.nl/contrib/mingw32-WebKit-1.1.5-1.fc11.src.rpm Description: WebKit is an open source web browser engine.
Koji scratch build: none for now because mingw32-libsoup, mingw32-libxslt and mingw32-libidn aren't in Fedora yet
Approved MinGW packaging guidelines are here: http://fedoraproject.org/wiki/Packaging/MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
--- Comment #1 from Kevin Kofler kevin@tigcc.ticalc.org 2009-05-10 06:24:27 EDT --- The native package is now built from a SRPM called webkitgtk, the MinGW package should probably be based on that.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |mingw32-WebKit - MinGW |mingw32-webkitgtk - MinGW |Windows web content engine |Windows web content engine |library |library
--- Comment #2 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2009-05-10 16:47:32 EDT --- This .spec file is based on the native WebKit package from just before the rename. I've renamed the package now to mingw32-webkitgtk and updated it to version 1.1.6 (the current version of the native package), but I can't get it compiled yet because upstream has added a dependency on enchant which we don't have packaged in our mingw toolchain yet. I'll try to package mingw32-enchant ASAP and also put it up for review.
New Spec URL: http://www.ftd4linux.nl/contrib/mingw32-webkitgtk.spec New SRPM URL: http://www.ftd4linux.nl/contrib/mingw32-webkitgtk-1.1.6-1.fc11.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
--- Comment #3 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2009-05-11 07:34:22 EDT --- Just tried to package mingw32-enchant, but it can't be compiled right now because the C functions _lock_file and _unlock_file aren't present in the MinGW headers/libraries yet: http://msdn.microsoft.com/en-us/library/8w5bsb4f%28VS.80%29.aspx
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
--- Comment #4 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2009-05-20 10:02:27 EDT --- The _lock_file issue has been reported upstream by Ryan McDougall (sempuki) @ https://sourceforge.net/tracker/?func=detail&aid=2794382&group_id=24...
Check the enchant package in the url I mentioned in the "Worth considering" thread. Or check the SVN of enchant. I submitted all the patches that are needed to cross-compile it with mingw.
Cheers
Fridrich
On Wed, 2009-05-20 at 10:02 -0400, bugzilla-H+wXaHxf7aLQT0dZR +AlfA@public.gmane.org wrote:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
--- Comment #4 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2009-05-20 10:02:27 EDT --- The _lock_file issue has been reported upstream by Ryan McDougall (sempuki) @ https://sourceforge.net/tracker/?func=detail&aid=2794382&group_id=24...
Op woensdag 20-05-2009 om 19:29 uur [tijdzone +0200], schreef Fridrich Strba:
Check the enchant package in the url I mentioned in the "Worth considering" thread. Or check the SVN of enchant. I submitted all the patches that are needed to cross-compile it with mingw.
Cheers
Fridrich
Ah, thx for the heads up!
Upon further investigation it looks like the _lock_file issue was already solved for several months in the enchant SVN: http://www.abisource.com/viewvc?limit_changes=100&view=rev&revision=... It's strange there hasn't been any new release of enchant, the last release was over a year ago...
Anyway, with this patch I can get enchant compiled and packaged, so a review request can be expected soon :)
Regards,
Erik van Pienbroek
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |502388
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
--- Comment #5 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2009-05-24 13:58:39 EDT --- The libraries enchant and hunspell (dependency for enchant) are now packaged and ready for review (bug 502388 and bug 502387).
Spec URL: http://www.ftd4linux.nl/contrib/mingw32-webkitgtk.spec SRPM URL: http://www.ftd4linux.nl/contrib/mingw32-webkitgtk-1.1.7-1.fc11.src.rpm
* Fri May 22 2009 Erik van Pienbroek epienbro@fedoraproject.org - 1.1.7-1 - Update to 1.1.7
* Sun May 10 2009 Erik van Pienbroek epienbro@fedoraproject.org - 1.1.6-1 - Update to 1.1.6 - Updated the patches to apply cleanly against version 1.1.6 - Renamed the package to mingw32-webkitgtk - Merged the changes from the native webkitgtk package up to 1.1.6-1 - Added a BR: mingw32-enchant (required as of version 1.1.6)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
Rafael Aquini aquini@linux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |aquini@linux.com
Bug 499992 depends on bug 499986, which changed state.
Bug 499986 Summary: Review Request: mingw32-libidn - MinGW Windows Internationalized Domain Name support library https://bugzilla.redhat.com/show_bug.cgi?id=499986
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Bug 499992 depends on bug 499983, which changed state.
Bug 499983 Summary: Review Request: mingw32-libsoup - MinGW library for HTTP and XML-RPC functionality https://bugzilla.redhat.com/show_bug.cgi?id=499983
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Bug 499992 depends on bug 499991, which changed state.
Bug 499991 Summary: Review Request: mingw32-libxslt - MinGW Windows Library providing the Gnome XSLT engine https://bugzilla.redhat.com/show_bug.cgi?id=499991
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Bug 499992 depends on bug 502388, which changed state.
Bug 502388 Summary: Review Request: mingw32-enchant - MinGW Windows Enchanting Spell Checking Library https://bugzilla.redhat.com/show_bug.cgi?id=502388
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Resolution| |ERRATA Status|ASSIGNED |CLOSED
--- Comment #6 from Rafael Aquini aquini@linux.com 2010-08-19 21:22:59 EDT --- PING
It's been more than a year with no progress; This review should be closed soon if there is no response, shouldn't it?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
Richard W.M. Jones rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rjones@redhat.com
--- Comment #7 from Richard W.M. Jones rjones@redhat.com 2010-08-20 03:42:55 EDT --- Ditto, leave these bugs open. They don't harm anyone.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
--- Comment #8 from Rafael Aquini aquini@linux.com 2010-08-20 08:06:15 EDT --- Richard,
Same as Bug 479874:
This is a janitorial work on Fedora Package Review queues, -- http://fedoraproject.org/PackageReviewStatus/ -- in order to identify and close stalled reviews.
I'm just following this policy: http://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
Regards
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
--- Comment #9 from Jason Tibbitts tibbs@math.uh.edu 2010-08-20 08:11:55 EDT --- A review ticket without a submitter is useless and needs to be closed. We have few enough reviewers as it is without having them waste time on packages where they will receive no response from the submitter.
In any case, if another submitter wants to take up this package, they should open their own review ticket. So this one must be closed in any case.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
Richard W.M. Jones rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |NotReady
--- Comment #10 from Richard W.M. Jones rjones@redhat.com 2010-08-20 08:43:05 EDT --- Does adding NotReady to the Whiteboard help?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|NotReady |
--- Comment #11 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2010-11-07 12:30:47 EST --- New Spec URL: http://www.ftd4linux.nl/contrib/mingw32-webkitgtk.spec New SRPM URL: http://www.ftd4linux.nl/contrib/mingw32-webkitgtk-1.2.5-1.fc14.src.rpm
* Sun Nov 7 2010 Erik van Pienbroek epienbro@fedoraproject.org - 1.2.5-1 - Update to 1.2.5 - Automatically generate debuginfo subpackage - Use %global instead of %define - Dropped the manual strip command - Dropped old patches
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
--- Comment #12 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2010-11-11 19:34:15 EST --- The Koji scratch build has completed successfully as well: http://koji.fedoraproject.org/koji/taskinfo?taskID=2595924
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
--- Comment #13 from Jason Tibbitts tibbs@math.uh.edu 2010-11-13 15:11:27 EST --- I note that F14 is at webkitgtk 1.3.4 (and 1.3.6 is in testing), so this package violates http://fedoraproject.org/wiki/Packaging:MinGW#Track_Fedora_native_package_ve...
Is there a specific reason to stay with 1.2.5?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
--- Comment #14 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2010-11-13 18:33:33 EST --- While updating the package I wasn't aware that F14 was bundling a development version of webkitgtk. I just took the latest stable version which is 1.2.5.
I'll try to provide a more recent version ASAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
--- Comment #15 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2010-11-14 13:39:49 EST --- New Spec URL: http://www.ftd4linux.nl/contrib/mingw32-webkitgtk.spec New SRPM URL: http://www.ftd4linux.nl/contrib/mingw32-webkitgtk-1.3.6-1.fc14.src.rpm Koji scratch build (F15): http://koji.fedoraproject.org/koji/taskinfo?taskID=2600627
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Flag| |fedora-review?
--- Comment #16 from Jason Tibbitts tibbs@math.uh.edu 2010-11-16 10:54:26 EST --- This is a huge build, and the debuginfo package is hilarious; one of the debug files is over a gigabyte. Fortunately it compresses pretty well.
Note that Fedora doesn't need BuildRoot:, %clean or the first line of %install.
I think the main package %description probably needs mention of MinGW somewhere.
The license information seems to be missing. The regular webkitgtk package puts it in the -doc subpackage, which is actually a guideline violation, but you seem to drop the -doc package altogether so it doesn't get in at all.
* source files match upstream. sha256sum: c9bdd5eb544d9447dbfa117cac2c925b6d09091a6a9798c71f2d2e6d5ab542f9 webkit-1.3.6.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. ? description is OK. * dist tag is present. * license field matches the actual license. * license is open source-compatible. X license text not included in package. * version packaged is the same as the native Fedora version. * package is noarch. * BuildRequires are proper. * compiler flags are appropriate. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints. * special mingw32 dependency generators are used. * final provides and requires are sane: mingw32-webkitgtk-1.3.6-1.fc15.noarch.rpm mingw32(libwebkitgtk-1.0-0.dll) mingw32-webkitgtk = 1.3.6-1.fc15 = mingw32-filesystem >= 63 mingw32-runtime mingw32(kernel32.dll) mingw32(libatk-1.0-0.dll) mingw32(libcairo-2.dll) mingw32(libenchant.dll) mingw32(libgailutil-18.dll) mingw32(libgcc_s_sjlj-1.dll) mingw32(libgdk_pixbuf-2.0-0.dll) mingw32(libgdk-win32-2.0-0.dll) mingw32(libgio-2.0-0.dll) mingw32(libglib-2.0-0.dll) mingw32(libgmodule-2.0-0.dll) mingw32(libgnutls-26.dll) mingw32(libgobject-2.0-0.dll) mingw32(libgthread-2.0-0.dll) mingw32(libgtk-win32-2.0-0.dll) mingw32(libjpeg-7.dll) mingw32(libpango-1.0-0.dll) mingw32(libpangocairo-1.0-0.dll) mingw32(libpng14-14.dll) mingw32(libsoup-2.4-1.dll) mingw32(libsqlite3-0.dll) mingw32(libstdc++-6.dll) mingw32(libwebkitgtk-1.0-0.dll) mingw32(libxml2-2.dll) mingw32(libxslt-1.dll) mingw32(msvcrt.dll) mingw32(ole32.dll) mingw32(pthreadgc2.dll) mingw32(user32.dll)
mingw32-webkitgtk-static-1.3.6-1.fc15.noarch.rpm mingw32-webkitgtk-static = 1.3.6-1.fc15 = mingw32-webkitgtk = 1.3.6-1.fc15 mingw32-filesystem >= 63 mingw32-runtime
* owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * static libraries are in a separate -static subpackage. * .dll and .def files in _mingw32_bindir * .dll.a and .la files in _mingw32_libdir * dll files are listed explicitly in %files. * libraries and executables are stripped properly.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
--- Comment #17 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2010-11-16 13:35:31 EST --- Yeah, this package is a huge beast to get compiled. I don't know why the (unstripped) binaries are so huge. The debug .so file in native Fedora package also is quite huge, over 600MB (http://koji.fedoraproject.org/koji/rpminfo?rpmID=2250732) so I guess it's something we have to live with.
I just updated published packages where all your review comments are taken care of.
New Spec URL: http://www.ftd4linux.nl/contrib/mingw32-webkitgtk.spec New SRPM URL: http://www.ftd4linux.nl/contrib/mingw32-webkitgtk-1.3.6-2.fc14.src.rpm
* Tue Nov 16 2010 Erik van Pienbroek epienbro@fedoraproject.org - 1.3.6-2 - Improved the description - Bundle the various license files - Dropped the BuildRoot tag, the %%clean section and the 'rm -rf %{buildroot}' from the %%install section as they aren't needed anymore these days
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #18 from Jason Tibbitts tibbs@math.uh.edu 2010-11-16 13:42:54 EST --- Great, thanks. I'm not going to bother building this because it takes a while even on my fast builder, but everything looks fine from looking at the spec.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #19 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2010-11-16 13:57:26 EST --- Thanks for the review!
New Package SCM Request ======================= Package Name: mingw32-webkitgtk Short Description: MinGW Windows web content engine library Owners: epienbro Branches: f14 el5 el6 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
--- Comment #20 from Jason Tibbitts tibbs@math.uh.edu 2010-11-16 14:03:14 EST --- I may have led you astray; Fedora doesn't need it and EL6 doesn't need it, but el5, being ancient, still needs BuildRoot, %clean and so on.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
--- Comment #21 from Jason Tibbitts tibbs@math.uh.edu 2010-11-17 10:58:16 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
--- Comment #22 from Fedora Update System updates@fedoraproject.org 2010-12-08 18:02:43 EST --- mingw32-webkitgtk-1.3.6-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/mingw32-webkitgtk-1.3.6-2.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #23 from Fedora Update System updates@fedoraproject.org 2010-12-09 16:59:17 EST --- mingw32-webkitgtk-1.3.6-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update mingw32-webkitgtk'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/mingw32-webkitgtk-1.3.6-2.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
--- Comment #24 from Fedora Update System updates@fedoraproject.org 2010-12-17 15:32:11 EST --- mingw32-webkitgtk-1.3.6-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499992
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |mingw32-webkitgtk-1.3.6-2.f | |c14 Resolution| |ERRATA Last Closed| |2010-12-17 15:32:18