[Bug 688171] New: i686-pc-mingw32-pkg-config shouldn't unset PKG_CONFIG_PATH

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: i686-pc-mingw32-pkg-config shouldn't unset PKG_CONFIG_PATH

https://bugzilla.redhat.com/show_bug.cgi?id=688171

           Summary: i686-pc-mingw32-pkg-config shouldn't unset
                    PKG_CONFIG_PATH
           Product: Fedora
           Version: rawhide
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: unspecified
          Priority: unspecified
         Component: mingw32-filesystem
        AssignedTo: rjones(a)redhat.com
        ReportedBy: bpeeluk(a)yahoo.co.uk
         QAContact: extras-qa(a)fedoraproject.org
                CC: rjones(a)redhat.com, kalev(a)smartlink.ee,
                    erik-fedora(a)vanpienbroek.nl,
                    fedora-mingw(a)lists.fedoraproject.org, drizt(a)land.ru
    Classification: Fedora


The MingW32 compiler on Fedora includes a wrapper script for pkg-config called
i686-pc-mingw32-pkg-config that sets PKG_CONFIG_LIBDIR. Presumably the idea of
this is to prevent pkg-config from picking up the native system .pc files when
cross compiling for Windows. However the script also does “unset
PKG_CONFIG_PATH”. This makes it very difficult to use pkg-config when using a
custom cross-compile environment where all of your dependencies are installed
in a non-standard prefix (typically somewhere in your home directory). I can't
see why the script would want to unset PKG_CONFIG_PATH as this won't be
typically set on a normal system so it's unlikely to pick up any native .pc
files. A developer would usually want to explicitly set this variable when
building in a custom environment so he or she would know to set it to only
include the Win32 environment path.

This was causing problems when cross-compiling Clutter on Fedora systems.
Clutter includes a build script for cross-compiling that installs all of
Clutter's dependencies into a custom prefix and then tries to set
PKG_CONFIG_PATH to point to this prefix. However Fedora's pkg-config wrapper
script prevents this variable from being passed to pkg-config. Clutter's build
script now explicitly includes its own wrapper for pkg-config to work around
Fedora.

I think the solution is to just remove the line that unsets PKG_CONFIG_PATH.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 688171] i686-pc-mingw32-pkg-config shouldn't unset PKG_CONFIG_PATH

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688171

Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl&gt; 2011-03-17
07:27:34 EDT ---
Unfortunately this will break compilation of packages using RPM:
$ grep -Hr PKG_CONFIG /usr/lib/rpm/*
macros:  PKG_CONFIG_PATH=\"%{_libdir}/pkgconfig:%{_datadir}/pkgconfig\"\
macros:  export PKG_CONFIG_PATH\
pkgconfigdeps.sh: export PKG_CONFIG_PATH="$DIR:$DIR/../../share/pkgconfig"
pkgconfigdeps.sh: export PKG_CONFIG_PATH="$DIR:$DIR/../../share/pkgconfig"

The match in the macros file is part of the %___build_pre section (which will
always get called in RPM %build sections)

If I change the mingw32-curl package to this:
 %build
+export > /tmp/rpm_export1
 %{_mingw32_configure} \
   --with-ssl --enable-ipv6 \
   --with-ca-bundle=%{_mingw32_sysconfdir}/pki/tls/certs/ca-bundle.crt \
   --with-libidn \
   --enable-static --with-libssh2 \
   --without-random
+export > /tmp/rpm_export2

Then the /tmp/rpm_export1 file will contain the line: export
PKG_CONFIG_PATH="/usr/lib64/pkgconfig:/usr/share/pkgconfig" (set by the
%___build_pre macro)
The /tmp/rpm_export2 file doesn't have the PKG_CONFIG_PATH export as the
%{_mingw32_configure} call (thus %{_mingw32_env}) has replaced it with: export
PKG_CONFIG_LIBDIR="/usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig" (which
is what we want to avoid pulling in native stuff)

A possible solution to your issue would be that a new variable like
MINGW32_PKG_CONFIG_PATH gets introduced. When it's set, we won't unset the
PKG_CONFIG_PATH, but set the PKG_CONFIG_PATH to the value of that
MINGW32_PKG_CONFIG_PATH variable. So with this, you could do something like:

MINGW32_PKG_CONFIG_PATH=/opt/my_custom_prefix/lib/pkgconfig pkg-config --cflags
glib-2.0

How do the other Fedora MinGW maintainers think of such a change?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 688171] i686-pc-mingw32-pkg-config shouldn't unset PKG_CONFIG_PATH

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688171

Richard W.M. Jones <rjones(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(bpeeluk(a)yahoo.co.
                   |                            |uk)

--- Comment #2 from Richard W.M. Jones <rjones(a)redhat.com&gt; 2011-03-17 07:58:42 EDT
---
Appears that MINGW32_PKG_CONFIG_PATH is a good practical
solution.  Does it fit the reporter's need?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 688171] i686-pc-mingw32-pkg-config shouldn't unset PKG_CONFIG_PATH

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688171

--- Comment #3 from Kalev Lember <kalev(a)smartlink.ee&gt; 2011-03-17 08:24:13 EDT ---
(In reply to comment #1)
>  Unfortunately this will break compilation of packages using RPM:
Not necessarily.

The way i686-pc-mingw32-* wrapper scripts are currently done is that they
internally evaluate the matching rpm macro. For example,
i686-pc-mingw32-pkg-config runs 'rpm --eval %{_mingw32_pkg_config}'.

We need the unset command in the rpm macro, but it's not needed for the wrapper
script. In fact, it's not only unneeded but might cause problems when configure
scripts call <host-triplet>-pkg-config.

I would say another solution is rewriting i686-pc-mingw32-pkg-config script so
it wouldn't call rpm --eval internally. With that we'd be able to get rid of
the 'unset' command in the script, but keep it in the rpm macro.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 688171] i686-pc-mingw32-pkg-config shouldn't unset PKG_CONFIG_PATH

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688171

Kevin Kofler <kevin(a)tigcc.ticalc.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kevin(a)tigcc.ticalc.org

--- Comment #4 from Kevin Kofler <kevin(a)tigcc.ticalc.org&gt; 2011-03-19 16:55:05 EDT
---
What about filtering the contents of PKG_CONFIG_PATH for bad directories
instead of unsetting it entirely? It's more code, of course, but it'd work
better.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 688171] i686-pc-mingw32-pkg-config shouldn't unset PKG_CONFIG_PATH

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688171

Yaakov (Cygwin Ports) <yselkowitz(a)cygwin.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yselkowitz(a)cygwin.com

--- Comment #5 from Yaakov (Cygwin Ports) <yselkowitz(a)cygwin.com&gt; 2011-04-04
21:45:23 EDT ---
(In reply to comment #3)
>  We need the unset command in the rpm macro, but it's not needed
> for the wrapper
>  script. In fact, it's not only unneeded but might cause problems when configure
>  scripts call <host-triplet>-pkg-config.
>  
>  I would say another solution is rewriting i686-pc-mingw32-pkg-config script so
>  it wouldn't call rpm --eval internally. With that we'd be able to get rid of
>  the 'unset' command in the script, but keep it in the rpm macro. 
Why not just remove the "unset PKG_CONFIG_PATH" from %_mingw32_pkg_config but
leave it in %_mingw32_env?  That way PKG_CONFIG_PATH will still be honoured
when building manually, such as the OP's example, but will be ignored when
building RPMs.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 688171] i686-pc-mingw32-pkg-config shouldn't unset PKG_CONFIG_PATH

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688171

--- Comment #6 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl&gt; 2011-04-10
10:54:56 EDT ---
That sounds like a good solution.
Here's a proposed patch:

--- a/macros.mingw32
+++ b/macros.mingw32
@@ -97,9 +97,7 @@ package or when debugging this package.\
   unset x i

 %_mingw32_pkg_config \
-  PKG_CONFIG_LIBDIR="%{_mingw32_libdir}/pkgconfig"; export PKG_CONFIG_LIBDIR;
\
-  unset PKG_CONFIG_PATH; \
-  pkg-config
+  PKG_CONFIG_LIBDIR="%{_mingw32_libdir}/pkgconfig" pkg-config

 %_mingw32_configure %{_mingw32_env} ; \
   __mingw32_topdir=.; if ! test -x configure; then __mingw32_topdir=..; fi;
\\\

The %_mingw32_env macro still has the unset PKG_CONFIG_PATH, but it shouldn't
be called when one calls the script 'mingw32-pkg-config' or
'i686-pc-mingw32-pkg-config'.

Is the patch good enough to commit?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 688171] i686-pc-mingw32-pkg-config shouldn't unset PKG_CONFIG_PATH

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688171

Marc-Andre Lureau <marcandre.lureau(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marcandre.lureau(a)redhat.com

--- Comment #7 from Marc-Andre Lureau <marcandre.lureau(a)redhat.com&gt; 2011-05-12
09:39:24 EDT ---
+1, yes please :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 688171] i686-pc-mingw32-pkg-config shouldn't unset PKG_CONFIG_PATH

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688171

--- Comment #8 from Kalev Lember <kalev(a)smartlink.ee&gt; 2011-05-12 14:13:48 EDT ---
+1, looks good.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 688171] i686-pc-mingw32-pkg-config shouldn't unset PKG_CONFIG_PATH

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688171

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 688171] i686-pc-mingw32-pkg-config shouldn't unset PKG_CONFIG_PATH

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688171

--- Comment #9 from Fedora Update System <updates(a)fedoraproject.org&gt; 2011-05-14
08:14:59 EDT ---
mingw32-filesystem-67-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/mingw32-filesystem-67-1.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 688171] i686-pc-mingw32-pkg-config shouldn't unset PKG_CONFIG_PATH

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688171

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #10 from Fedora Update System <updates(a)fedoraproject.org&gt; 2011-05-17
01:37:45 EDT ---
Package mingw32-filesystem-67-1.fc15:
* should fix your issue,
* was pushed to the Fedora 15 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing mingw32-filesystem-67-1.fc15'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/mingw32-filesystem-67-1.fc15
then log in and leave karma (feedback).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 688171] i686-pc-mingw32-pkg-config shouldn't unset PKG_CONFIG_PATH

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688171

--- Comment #11 from Fedora Update System <updates(a)fedoraproject.org&gt; 2011-05-19
17:56:35 EDT ---
mingw32-filesystem-67-1.fc15 has been pushed to the Fedora 15 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 688171] i686-pc-mingw32-pkg-config shouldn't unset PKG_CONFIG_PATH

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688171

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |mingw32-filesystem-67-1.fc1
                   |                            |5
         Resolution|                            |ERRATA
               Flag|needinfo?(bpeeluk(a)yahoo.co. |
                   |uk)                         |
        Last Closed|                            |2011-05-19 17:56:41

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.