[Bug 491618] New: Review Request: mingw32-libsqlite3x - MinGW Windows C++ wrapper for the sqlite database library - mingw

List overview All Threads
Download

newer

[Bug 491618] New: Review Request: mingw32-libsqlite3x - MinGW Windows C++ wrapper for the sqlite database library

older

[Bug 498508] New: mingw32-zlib...

[Bug 492133] New: Review Request:...

Red Hat Bugzilla

23 Mar 2009 23 Mar '09

6:12 a.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: mingw32-libsqlite3x - MinGW Windows C++ wrapper for the sqlite database library Alias: mingw32-libsqlite3x

https://bugzilla.redhat.com/show_bug.cgi?id=491618

Summary: Review Request: mingw32-libsqlite3x - MinGW Windows C++ wrapper for the sqlite database library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: t.sailer@alumni.ethz.ch QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com, fedora-mingw@lists.fedoraproject.org Classification: Fedora

Spec URL: http://sailer.fedorapeople.org/mingw32-libsqlite3x.spec SRPM URL: http://sailer.fedorapeople.org/mingw32-libsqlite3x-20071018-5.fc11.src.rpm Description: MinGW Windows C++ wrapper for the sqlite database library.

Approved MinGW packaging guidelines are here: http://fedoraproject.org/wiki/Packaging/MinGW

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

26 Apr 26 Apr

12:06 a.m.

New subject: [Bug 491618] Review Request: mingw32-libsqlite3x - MinGW Windows C++ wrapper for the sqlite database library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491618

Mattias Ellert mattias.ellert@fysast.uu.se changed:

--- Comment #1 from Mattias Ellert mattias.ellert@fysast.uu.se 2009-04-26 01:06:16 EDT --- Build fails:

i686-pc-mingw32-g++ -DHAVE_CONFIG_H -I. -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOUR\ CE=2 -fexceptions --param=ssp-buffer-size=4 -mms-bitfields -O2 -Wall -c sqlite3\ x_command.cpp -DPIC env: i686-pc-mingw32-g++: Permission denied make[1]: *** [sqlite3x_command.lo] Error 1 make[1]: Leaving directory `/builddir/build/BUILD/libsqlite3x-2007.10.18' make: *** [all] Error 2

Probable cause: missing BuildRequires: mingw32-gcc-c++

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

27 Apr 27 Apr

4:33 a.m.

New subject: [Bug 491618] Review Request: mingw32-libsqlite3x - MinGW Windows C++ wrapper for the sqlite database library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491618

--- Comment #2 from Thomas Sailer t.sailer@alumni.ethz.ch 2009-04-27 05:33:17 EDT --- Update: Spec URL: http://sailer.fedorapeople.org/mingw32-libsqlite3x.spec SRPM URL: http://sailer.fedorapeople.org/mingw32-libsqlite3x-20071018-6.fc11.src.rpm

Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1322147

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

28 Apr 28 Apr

8:23 a.m.

New subject: [Bug 491618] Review Request: mingw32-libsqlite3x - MinGW Windows C++ wrapper for the sqlite database library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491618

--- Comment #3 from Mattias Ellert mattias.ellert@fysast.uu.se 2009-04-28 09:23:08 EDT --- Fedora review mingw32-libsqlite3x-20071018-6.fc11.src.rpm 2009-04-28

* OK ! needs attention

* rpmlint output Only expected Errors/Warnings from a mingw package

* Package is named according to Fedora mingw packaging guidelines

* Spec file is named as the package

* Package follows the Fedora mingw packaging guidelines

* License is MIT, which is Fedora approved

* The license is the same as the corresponding native package

! How was it determined that the native's package license should be MIT?

* There is no License file in the source tarfile (though some license statements are in the README file which is packaged).

* The spec file is written in legible English

* Source matches upstream

f5015c83030236205aec1494b13ee334 libsqlite3x-2007.10.18.tar.gz f5015c83030236205aec1494b13ee334 SRPM/libsqlite3x-2007.10.18.tar.gz

* According to guidelines the version should match the version of the corresponding Fedora package - which it does.

* Package builds in mock (Fedora 10)

! The package contains documentation already present in the native Fedora package

* BuildRequires look sane

! But is there a reason for having the "BuildArch: noarch" listed in the middle of the list of Thr BuildRequies?

* Owns the directories it creates

* No duplicate files

* %files has %defattr

* %clean clears %buildroot

* Specfile uses macros consistently

* Package does not own other's directories

* %install clears %buildroot

* Installed filenames are valid UTF8

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

1:53 p.m.

New subject: [Bug 491618] Review Request: mingw32-libsqlite3x - MinGW Windows C++ wrapper for the sqlite database library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491618

--- Comment #4 from Thomas Sailer t.sailer@alumni.ethz.ch 2009-04-28 14:53:30 EDT --- (In reply to comment #3)

Updated: SRPM: http://sailer.fedorapeople.org/mingw32-libsqlite3x-20071018-7.fc11.src.rpm Spec: http://sailer.fedorapeople.org/mingw32-libsqlite3x.spec

...

! How was it determined that the native's package license should be MIT?

Good you noticed that. It isn't MIT, it is under zlib. There are a few copyright notices as comments in source files, eg. sqlite3x.hpp. I changed the license tag in the above spec file, and I will also change the native package. David Woodhouse (the reviewer of the native package), has also been notified, he is ok with the change.

...

! The package contains documentation already present in the native Fedora package

Removed.

...

! But is there a reason for having the "BuildArch: noarch" listed in the middle of the list of Thr BuildRequies?

Reordered.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

29 Apr 29 Apr

4:27 a.m.

New subject: [Bug 491618] Review Request: mingw32-libsqlite3x - MinGW Windows C++ wrapper for the sqlite database library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491618

Mattias Ellert mattias.ellert@fysast.uu.se changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

--- Comment #5 from Mattias Ellert mattias.ellert@fysast.uu.se 2009-04-29 05:27:38 EDT --- Do you still need BuildRequires: doxygen?

Anyway, that you can check post-review.

Package approved.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:16 a.m.

New subject: [Bug 491618] Review Request: mingw32-libsqlite3x - MinGW Windows C++ wrapper for the sqlite database library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491618

--- Comment #6 from Thomas Sailer t.sailer@alumni.ethz.ch 2009-04-29 06:16:19 EDT --- Thank you for the review.

New Package CVS Request ======================= Package Name: mingw32-libsqlite3x Short Description: MinGW Windows C++ wrapper for the sqlite database Owners: sailer rjones Branches: F-10 F-11 InitialCC:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:16 a.m.

New subject: [Bug 491618] Review Request: mingw32-libsqlite3x - MinGW Windows C++ wrapper for the sqlite database library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491618

Thomas Sailer t.sailer@alumni.ethz.ch changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:42 p.m.

New subject: [Bug 491618] Review Request: mingw32-libsqlite3x - MinGW Windows C++ wrapper for the sqlite database library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491618

Kevin Fenzi kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

--- Comment #7 from Kevin Fenzi kevin@tummy.com 2009-04-30 00:42:10 EDT --- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

30 Apr 30 Apr

1:13 a.m.

New subject: [Bug 491618] Review Request: mingw32-libsqlite3x - MinGW Windows C++ wrapper for the sqlite database library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491618

--- Comment #8 from Fedora Update System updates@fedoraproject.org 2009-04-30 02:13:27 EDT --- mingw32-libsqlite3x-20071018-7.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/mingw32-libsqlite3x-20071018-7.fc11

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

1:17 a.m.

New subject: [Bug 491618] Review Request: mingw32-libsqlite3x - MinGW Windows C++ wrapper for the sqlite database library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491618

--- Comment #9 from Fedora Update System updates@fedoraproject.org 2009-04-30 02:17:07 EDT --- mingw32-libsqlite3x-20071018-7.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/mingw32-libsqlite3x-20071018-7.fc10

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2 May 2 May

11:37 a.m.

New subject: [Bug 491618] Review Request: mingw32-libsqlite3x - MinGW Windows C++ wrapper for the sqlite database library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491618

--- Comment #10 from Fedora Update System updates@fedoraproject.org 2009-05-02 12:37:24 EDT --- mingw32-libsqlite3x-20071018-7.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:37 a.m.

New subject: [Bug 491618] Review Request: mingw32-libsqlite3x - MinGW Windows C++ wrapper for the sqlite database library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491618

Fedora Update System updates@fedoraproject.org changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8 May 8 May

11:18 p.m.

New subject: [Bug 491618] Review Request: mingw32-libsqlite3x - MinGW Windows C++ wrapper for the sqlite database library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491618

--- Comment #11 from Fedora Update System updates@fedoraproject.org 2009-05-09 00:18:15 EDT --- mingw32-libsqlite3x-20071018-7.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:18 p.m.

New subject: [Bug 491618] Review Request: mingw32-libsqlite3x - MinGW Windows C++ wrapper for the sqlite database library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=491618

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|20071018-7.fc10 |20071018-7.fc11

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

5879

Age (days ago)

5926

Last active (days ago)

mingw@lists.fedoraproject.org

14 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla