Re: Regarding notmuch and Fedora 16
by Karel Zak
On Thu, Jan 12, 2012 at 02:31:39PM +0200, Tomi Ollila wrote:
> On Tue, 03 Jan 2012 22:36:59 +0000, Darren McGuicken <mailing-notmuch(a)fernseed.info> wrote:
> > On Tue, 03 Jan 2012 17:09:39 -0500, Peter Portante <peter.a.portante(a)gmail.com> wrote:
> > > I am interested in using notmuch from within emacs, but have not been
> > > able to get the latest version of notmuch (0.10.2) to compile under
> > > Fedora 16.
> >
> > Looks like we have a growing Fedora community, yay! :-)
> >
> > And it's nothing you're doing wrong, per my reply to the other thread
> > F16 is using the current development version of gmime which has API
> > differences with the stable version 2.4. The patch that exists isn't
> > part of standard notmuch since it in turn breaks 2.4 compatibility.
> >
> > What's the right way to handle this? I see 2.6 tarballs on gnome... is
> > 2.6 officially out there and stable?
>
> Some conditional compilation by #if(def)ing some *GMIME* macro...
>
> While doing something else I passed by these messages:
>
> http://www.mail-archive.com/notmuch@notmuchmail.org/msg05829.html
> http://koji.fedoraproject.org/koji/buildinfo?buildID=269819
>
> These seems to provide valuable information to anyone attempting
> to compile notmuch with gmime 2.5+
It seems that we have officially notmuch 0.11 in Fedora 17/rawhide, if
you have the latest stable Fedora 16, then you can use:
yum --enablerepo=rawhide install notmuch notmuch-devel
to get:
$ rpm -q notmuch gmime
notmuch-0.11-1.fc17.x86_64
gmime-2.5.8-1.fc16.x86_64
Karel
--
Karel Zak <kzak(a)redhat.com>
http://karelzak.blogspot.com
11 years, 9 months
Re: [PATCH 2/2] notmuch: fix compilation error at get_nm_message()
by Karel Zak
(ah... I forgot CC: to list)
Note that to compile the current git HEAD you have to update to
notmuch >= 0.9 (on Fedora you have to use f17/rawhide notmuch).
Karel
On Mon, Feb 27, 2012 at 09:58:38AM +0100, Karel Zak wrote:
> On Sun, Feb 26, 2012 at 03:41:29PM +0100, Víctor Manuel Jáquez Leal wrote:
> > The shown error is:
> >
> > mutt_notmuch.c: In function ‘get_nm_message’:
> > mutt_notmuch.c:643:2: error: too few arguments to function ‘notmuch_database_find_message’
> > /usr/include/notmuch.h:371:1: note: declared here
> > make[2]: *** [mutt_notmuch.o] Error 1
> >
> > The mutt-ks is made for notmuch version 0.8, but in version 0.9 the API
> > changed, in particular with this commit:
> >
> > http://git.notmuchmail.org/git/notmuch/commitdiff/02a30767116ad8abcbd0a33...
> >
> > This patch updates the function notmuch_database_find_message() usage.
>
> Applied, thanks.
>
> Karel
>
>
> > Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez(a)igalia.com>
> > ---
> > mutt_notmuch.c | 5 +++--
> > 1 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/mutt_notmuch.c b/mutt_notmuch.c
> > index 2f21407..e77f547 100644
> > --- a/mutt_notmuch.c
> > +++ b/mutt_notmuch.c
> > @@ -635,12 +635,13 @@ char *nm_uri_from_query(CONTEXT *ctx, char *buf, size_t bufsz)
> > */
> > static notmuch_message_t *get_nm_message(notmuch_database_t *db, HEADER *hdr)
> > {
> > - notmuch_message_t *msg;
> > + notmuch_message_t *msg = NULL;
> > char *id = nm_header_get_id(hdr);
> >
> > dprint(2, (debugfile, "nm: find message (%s)\n", id));
> >
> > - msg = id && db ? notmuch_database_find_message(db, id) : NULL;
> > + if (id && db)
> > + notmuch_database_find_message(db, id, &msg);
> >
> > FREE(&id);
> > return msg;
> > --
> > 1.7.9
> >
>
> --
> Karel Zak <kzak(a)redhat.com>
> http://karelzak.blogspot.com
--
Karel Zak <kzak(a)redhat.com>
http://karelzak.blogspot.com
11 years, 9 months
Re: [PATCH 1/2] notmuch: fix compilation error when using hcache
by Karel Zak
On Sun, Feb 26, 2012 at 03:41:28PM +0100, Víctor Manuel Jáquez Leal wrote:
> The error is this:
>
> In file included from imap.c:28:0:
> ../mx.h:73:56: error: unknown type name ‘header_cache_t’
> make[2]: *** [imap.o] Error 1
>
> The offender commit was:
>
> commit cc497cf32588bb080fe39dfb7a37965e92f3c01b
> Author: Karel Zak <kzak(a)redhat.com>
> Date: Wed Dec 14 14:07:58 2011 +0100
>
> notmuch: consolidate msg sync code
>
> - add mh_sync_mailbox_message() to sync just one message
> - add msg->commited_path to save info about the final message path
> (will be used keep notmuch DB up to date)
>
> Signed-off-by: Karel Zak <kzak(a)redhat.com>
>
> The fix consist in including hcache.h when hchace is enabled.
>
> Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez(a)igalia.com>
> ---
> mx.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Applied, thanks.
Karel
>
> diff --git a/mx.h b/mx.h
> index c59de77..0dd7e6c 100644
> --- a/mx.h
> +++ b/mx.h
> @@ -70,6 +70,7 @@ void maildir_parse_flags (HEADER * h, const char *path);
> void maildir_update_flags (CONTEXT *ctx, HEADER *o, HEADER *n);
>
> #if USE_HCACHE
> +#include <hcache.h>
> int mh_sync_mailbox_message (CONTEXT * ctx, int msgno, header_cache_t *hc);
> #else
> int mh_sync_mailbox_message (CONTEXT * ctx, int msgno);
> --
> 1.7.9
>
--
Karel Zak <kzak(a)redhat.com>
http://karelzak.blogspot.com
11 years, 9 months