On Fri, 2009-06-26 at 12:45 +0200, Jonas Eriksson wrote:
These files are heavily based on their initscript-counterpart.
They look ok overall (of course, I am relying on you that they actually work on SuSE ;)
Besides the refactoring discussed for the C driver, one minor thing that I simplified the other day is that instead of writing
<node label="GATEWAY"> <xsl:attribute name="value"><xsl:value-of select="route/@gateway"/></xsl:attribute> </node>
you can use an 'attribute value template' and write
<node label="GATEWAY" value="{route/@gateway}"/>
which is much more readable (if such a thing can be said of XSLT)
Thinking about it some more, I am actually not sure whether refactoring is all that useful for the stylesheets, since they have most of the backend-specific logic. Of course, where it's easy and seems safe for future changes (like constructing BONDING_OPTS), it makes sense; in other places, it might be ok to have the same things repeated across several stylesheets.
David