On Tue, Jun 30, 2009 at 01:21:33PM -0700, David Lutterkort wrote:
This is the second take on adding vlan interfaces. The format has been
changed according to Dan's suggestion, so that a bridge with an enslaved
VLAN now looks like
<interface type="bridge" name="br0">
<start mode="onboot"/>
<protocol family="ipv4">
<dhcp/>
</protocol>
<bridge stp="off">
<interface type="vlan" name="eth0.42">
<vlan tag="42">
<interface name="eth0"/>
</vlan>
</interface>
</bridge>
</interface>
Besides changing the way how the base interface for a VLAN interface is
expressed (with the nested <vlan/>) tag, these patches have also been
rebased to work with the changes for interface/@name and interface/start
that I just posted.
I'll probably commit these in the next few hours, since I won't be around
tomorrow, so people can follow along more easily at home.
This looks good to me too.
Daniel
--
|: Red Hat, Engineering, London -o-
http://people.redhat.com/berrange/ :|
|:
http://libvirt.org -o-
http://virt-manager.org -o-
http://ovirt.org :|
|:
http://autobuild.org -o-
http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|