Checkpoint logic error for integration test tear-up phase

[Till Maas]

Hi,

while looking at Nmstate logs after failures I noticed that Nmstate
uses checkpoints in the tear-up phase of integration tests. Therefore,
if something fails inside the mainloopo in the tear-up phase, all
tear-up progress is reverted instead of keeping at least the removed
bits removed. Am I missing something?

My idea for the easiest/cleanest solution would  be to just issue
"nmcli c d $interface; nmclid d $interface (if it is not eth1/eth2)"
and ignoring the returncode for all interfaces that are touched in a
test as the tear-up code. Since Nmstate also stores routes and DNS
information in the respective profiles, this should properly clean it
up with the better working nmcli code.

What do you think?

Kind regards
Till

-- 
Till Maas
He/His/Him
Ansible RHEL Networking System Role Maintainer

Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Laurie Krebs, Michael O'Neill,
Thomas Savage