The the Node.js guidelines say about Source0 [1]:
"The canonical method for shipping most node modules is tarballs from
the npm registry"
and
"This method [PP: tarbals from npm] should be preferred to using
checkouts from git or automatically generated tarballs from GitHub."
But I think that in following cases it would be better to use sources
from the upstream project:
1) When the license is not included in NPM but is in upstream project.
o Because we are not supposed to ship the license separate from the
sources.
2) When the tests are not included.
o In this case we need to download the sources from NPM and from
upstream project, which seems redundant and a waste of work.
3) When NPM content is generated and source files are not in NPM.
o This would mean to download sources from NPM and upstream project,
delete the NPM sources in prep and generate the files again.
Are there good reason to enforce the use of NPM sources which I am
missing? What is your opinion?
I would like to suggest to ad those three exceptions to the guidelines.
Piotr
[1]:
https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#Using…
Sent from my Samsung device
-------- Original message --------
From: Tom Hughes <tom(a)compton.nu>
Date: 08/10/2015 16:17 (GMT+00:00)
To: "Node.js on Fedora" <nodejs(a)lists.fedoraproject.org>
Subject: Re: Self-introduction + package review swaps
On 08/10/15 15:51, Jared K. Smith wrote:
> I have the following outstanding package review requests, and would be
> happy to swap reviews with anyone else to help push some of these
> packages forward.
As you're aware I've already done a couple of our packages, and I'll try
and look at some more this evening. I've got a couple of nodejs packages
awaiting review if you'd like to help out in return:
1223550 nodejs-fill-keys
1257707 nodejs-should-http
Beyond that I have some C++ based packages awaiting review if you're up
for dealing with that.
Tom
--
Tom Hughes (tom(a)compton.nu)
http://compton.nu/
_______________________________________________
nodejs mailing list
nodejs(a)lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/nodejs