On Thu, Sep 3, 2020 at 1:04 PM Troy Dawson <tdawson(a)redhat.com> wrote:
On Thu, Sep 3, 2020 at 9:28 AM Tom Hughes <tom(a)compton.nu> wrote:
>
> On 03/09/2020 16:41, Troy Dawson wrote:
>
> > Any changes and/or improvements that people think should be made?
>
> Well macros for all that boilerplate in the spec is an
> obvious one.
>
> Also making the script fetch the actual version being packaged
> rather than the latest version would be good. Something like:
>
> VERSION="$(rpmspec --srpm --queryformat=%{VERSION} -q
nodejs-${PACKAGE}.spec)"
>
> and then:
>
> npm pack ${PACKAGE}@${VERSION}
>
> Tom
>
Good point. I guess I had sorta hard coded both the name and the version.
So if they provide a version, use it, and if not, use the latest.
Hi Troy,
This looks pretty reasonable to me. (Sorry, I intended to try and work
on something like this myself over the summer but didn't end up having
time. Thanks for working on it!)
I'd been thinking the script would have one source archive per nodejs
module rather than a single source archive with all the bundled
dependencies, but on second thought that probably would be extremely
unwieldy, so perhaps bundling them together into a tarball is better.
What are your thoughts on deploying this? Node packages are going to
be broken in Fedora 33, but it's probably way too late to fix that
now, so perhaps there should be a Fedora 34 Change proposal?
Ben Rosser