Updating nodejs-bytes

[Ben Rosser]

Hello nodejs@,

I'm currently, slowly, working on packaging quassel-webserver [1], a
nodejs web application. It has a number of node dependencies that need
to be gotten in Fedora (hence the "slowly").

I've currently hit a roadblock: nodejs-body-parser is needed by
nodejs-libquassel (one of the dependencies). body-parser depends on
nodejs-bytes version 2.4.0 [2]. We presently ship version *0.3.0*,
which dates back to March 2014. Tests suggest that there's actual API
changes between 0.3.0 and 2.4.0; attempting to %nodejs_fixdep the
problem away caused body-parser's unit tests to fail.

There is an open bug against our nodejs-bytes package to update it to
a newer version that was filed by release-monitoring (back in 2014)
[3], but the only action on the ticket has been additional bumps from
release-monitoring as newer and newer versions have been released.

Since the nodejs-sig group has commit rights on the package, I figured
I'd first contact this list before doing anything else. Is there a
reason we're shipping such an old version? Would it be possible for
someone to look into updating it? Should I request commit rights
myself?

dnf repoquery --whatrequires "npm(bytes)" suggests its dependencies in
Fedora are:
> nodejs-compression-0:1.0.1-5.fc24.noarch
> nodejs-connect-0:2.14.5-7.fc24.noarch
> nodejs-morgan-0:1.0.0-5.fc24.noarch
> nodejs-raw-body-0:1.1.4-4.fc24.noarch

Thanks in advance!
Ben Rosser

[1] https://github.com/magne4000/quassel-webserver

[2] https://github.com/expressjs/body-parser/blob/master/package.json

[3] https://bugzilla.redhat.com/show_bug.cgi?id=1094697

[Zuzana Svetlikova]

Hi,

I pdated bytes in rawhide, I'll make update for f25 when other packages are ready 
so we don't break something.

Zuzka

----- Original Message -----
From: "Ben Rosser" 
To: [e-mail]
Sent: Thursday, February 9, 2017 6:59:16 AM
Subject: Updating nodejs-bytes

Hello nodejs@,

I'm currently, slowly, working on packaging quassel-webserver [1], a
nodejs web application. It has a number of node dependencies that need
to be gotten in Fedora (hence the "slowly").

I've currently hit a roadblock: nodejs-body-parser is needed by
nodejs-libquassel (one of the dependencies). body-parser depends on
nodejs-bytes version 2.4.0 [2]. We presently ship version *0.3.0*,
which dates back to March 2014. Tests suggest that there's actual API
changes between 0.3.0 and 2.4.0; attempting to %nodejs_fixdep the
problem away caused body-parser's unit tests to fail.

There is an open bug against our nodejs-bytes package to update it to
a newer version that was filed by release-monitoring (back in 2014)
[3], but the only action on the ticket has been additional bumps from
release-monitoring as newer and newer versions have been released.

Since the nodejs-sig group has commit rights on the package, I figured
I'd first contact this list before doing anything else. Is there a
reason we're shipping such an old version? Would it be possible for
someone to look into updating it? Should I request commit rights
myself?

dnf repoquery --whatrequires "npm(bytes)" suggests its dependencies in
Fedora are:
> nodejs-compression-0:1.0.1-5.fc24.noarch
> nodejs-connect-0:2.14.5-7.fc24.noarch
> nodejs-morgan-0:1.0.0-5.fc24.noarch
> nodejs-raw-body-0:1.1.4-4.fc24.noarch

Thanks in advance!
Ben Rosser

[1] https://github.com/magne4000/quassel-webserver

[2] https://github.com/expressjs/body-parser/blob/master/package.json

[3] https://bugzilla.redhat.com/show_bug.cgi?id=1094697
_______________________________________________
nodejs mailing list -- [e-mail]
To unsubscribe send an email to [e-mail]

[Tom Hughes]

So, err, what efforts did you make to investigate the effect on the four 
packages that require bytes before you updated it?

When you say "when the other packages are ready" does that mean you're 
working on them? or are you expecting other people to pick up the pieces?

Tom

On 09/02/17 09:50, Zuzana Svetlikova wrote:
> Hi,
>
> I pdated bytes in rawhide, I'll make update for f25 when other packages are ready
> so we don't break something.
>
> Zuzka
>
> ----- Original Message -----
> From: "Ben Rosser" 
> To: [e-mail]
> Sent: Thursday, February 9, 2017 6:59:16 AM
> Subject: Updating nodejs-bytes
>
> Hello nodejs@,
>
> I'm currently, slowly, working on packaging quassel-webserver [1], a
> nodejs web application. It has a number of node dependencies that need
> to be gotten in Fedora (hence the "slowly").
>
> I've currently hit a roadblock: nodejs-body-parser is needed by
> nodejs-libquassel (one of the dependencies). body-parser depends on
> nodejs-bytes version 2.4.0 [2]. We presently ship version *0.3.0*,
> which dates back to March 2014. Tests suggest that there's actual API
> changes between 0.3.0 and 2.4.0; attempting to %nodejs_fixdep the
> problem away caused body-parser's unit tests to fail.
>
> There is an open bug against our nodejs-bytes package to update it to
> a newer version that was filed by release-monitoring (back in 2014)
> [3], but the only action on the ticket has been additional bumps from
> release-monitoring as newer and newer versions have been released.
>
> Since the nodejs-sig group has commit rights on the package, I figured
> I'd first contact this list before doing anything else. Is there a
> reason we're shipping such an old version? Would it be possible for
> someone to look into updating it? Should I request commit rights
> myself?
>
> dnf repoquery --whatrequires "npm(bytes)" suggests its dependencies in
> Fedora are:
> > nodejs-compression-0:1.0.1-5.fc24.noarch
> > nodejs-connect-0:2.14.5-7.fc24.noarch
> > nodejs-morgan-0:1.0.0-5.fc24.noarch
> > nodejs-raw-body-0:1.1.4-4.fc24.noarch
>
> Thanks in advance!
> Ben Rosser
>
> [1] https://github.com/magne4000/quassel-webserver
>
> [2] https://github.com/expressjs/body-parser/blob/master/package.json
>
> [3] https://bugzilla.redhat.com/show_bug.cgi?id=1094697
> _______________________________________________
> nodejs mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> _______________________________________________
> nodejs mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Tom Hughes]

Just to take the first example, compression, that has a new upstream 
version that uses bytes 2.4.0 but it also needs a newer version of 
compressible and both accepts and vary that we don't have yet.

So the knock on effects of trying to update everything else are not 
going to be trivial...

Tom

On 09/02/17 09:58, Tom Hughes wrote:
> So, err, what efforts did you make to investigate the effect on the four
> packages that require bytes before you updated it?
>
> When you say "when the other packages are ready" does that mean you're
> working on them? or are you expecting other people to pick up the pieces?
>
> Tom
>
> On 09/02/17 09:50, Zuzana Svetlikova wrote:
> > Hi,
> >
> > I pdated bytes in rawhide, I'll make update for f25 when other
> > packages are ready
> > so we don't break something.
> >
> > Zuzka
> >
> > ----- Original Message -----
> > From: "Ben Rosser" 
> > To: [e-mail]
> > Sent: Thursday, February 9, 2017 6:59:16 AM
> > Subject: Updating nodejs-bytes
> >
> > Hello nodejs@,
> >
> > I'm currently, slowly, working on packaging quassel-webserver [1], a
> > nodejs web application. It has a number of node dependencies that need
> > to be gotten in Fedora (hence the "slowly").
> >
> > I've currently hit a roadblock: nodejs-body-parser is needed by
> > nodejs-libquassel (one of the dependencies). body-parser depends on
> > nodejs-bytes version 2.4.0 [2]. We presently ship version *0.3.0*,
> > which dates back to March 2014. Tests suggest that there's actual API
> > changes between 0.3.0 and 2.4.0; attempting to %nodejs_fixdep the
> > problem away caused body-parser's unit tests to fail.
> >
> > There is an open bug against our nodejs-bytes package to update it to
> > a newer version that was filed by release-monitoring (back in 2014)
> > [3], but the only action on the ticket has been additional bumps from
> > release-monitoring as newer and newer versions have been released.
> >
> > Since the nodejs-sig group has commit rights on the package, I figured
> > I'd first contact this list before doing anything else. Is there a
> > reason we're shipping such an old version? Would it be possible for
> > someone to look into updating it? Should I request commit rights
> > myself?
> >
> > dnf repoquery --whatrequires "npm(bytes)" suggests its dependencies in
> > Fedora are:
> > > nodejs-compression-0:1.0.1-5.fc24.noarch
> > > nodejs-connect-0:2.14.5-7.fc24.noarch
> > > nodejs-morgan-0:1.0.0-5.fc24.noarch
> > > nodejs-raw-body-0:1.1.4-4.fc24.noarch
> >
> > Thanks in advance!
> > Ben Rosser
> >
> > [1] https://github.com/magne4000/quassel-webserver
> >
> > [2] https://github.com/expressjs/body-parser/blob/master/package.json
> >
> > [3] https://bugzilla.redhat.com/show_bug.cgi?id=1094697
> > _______________________________________________
> > nodejs mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
> > _______________________________________________
> > nodejs mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]

[Zuzana Svetlikova]

Yes, I did check how much of a breakage the update will cause 
and no, I do not expect anyone to help out.

----- Original Message -----
From: "Tom Hughes" 
To: "Node.js on Fedora" 
Sent: Thursday, February 9, 2017 11:01:30 AM
Subject: Re: Updating nodejs-bytes

Just to take the first example, compression, that has a new upstream 
version that uses bytes 2.4.0 but it also needs a newer version of 
compressible and both accepts and vary that we don't have yet.

So the knock on effects of trying to update everything else are not 
going to be trivial...

Tom

On 09/02/17 09:58, Tom Hughes wrote:
> So, err, what efforts did you make to investigate the effect on the four
> packages that require bytes before you updated it?
>
> When you say "when the other packages are ready" does that mean you're
> working on them? or are you expecting other people to pick up the pieces?
>
> Tom
>
> On 09/02/17 09:50, Zuzana Svetlikova wrote:
> > Hi,
> >
> > I pdated bytes in rawhide, I'll make update for f25 when other
> > packages are ready
> > so we don't break something.
> >
> > Zuzka
> >
> > ----- Original Message -----
> > From: "Ben Rosser" 
> > To: [e-mail]
> > Sent: Thursday, February 9, 2017 6:59:16 AM
> > Subject: Updating nodejs-bytes
> >
> > Hello nodejs@,
> >
> > I'm currently, slowly, working on packaging quassel-webserver [1], a
> > nodejs web application. It has a number of node dependencies that need
> > to be gotten in Fedora (hence the "slowly").
> >
> > I've currently hit a roadblock: nodejs-body-parser is needed by
> > nodejs-libquassel (one of the dependencies). body-parser depends on
> > nodejs-bytes version 2.4.0 [2]. We presently ship version *0.3.0*,
> > which dates back to March 2014. Tests suggest that there's actual API
> > changes between 0.3.0 and 2.4.0; attempting to %nodejs_fixdep the
> > problem away caused body-parser's unit tests to fail.
> >
> > There is an open bug against our nodejs-bytes package to update it to
> > a newer version that was filed by release-monitoring (back in 2014)
> > [3], but the only action on the ticket has been additional bumps from
> > release-monitoring as newer and newer versions have been released.
> >
> > Since the nodejs-sig group has commit rights on the package, I figured
> > I'd first contact this list before doing anything else. Is there a
> > reason we're shipping such an old version? Would it be possible for
> > someone to look into updating it? Should I request commit rights
> > myself?
> >
> > dnf repoquery --whatrequires "npm(bytes)" suggests its dependencies in
> > Fedora are:
> > > nodejs-compression-0:1.0.1-5.fc24.noarch
> > > nodejs-connect-0:2.14.5-7.fc24.noarch
> > > nodejs-morgan-0:1.0.0-5.fc24.noarch
> > > nodejs-raw-body-0:1.1.4-4.fc24.noarch
> >
> > Thanks in advance!
> > Ben Rosser
> >
> > [1] https://github.com/magne4000/quassel-webserver
> >
> > [2] https://github.com/expressjs/body-parser/blob/master/package.json
> >
> > [3] https://bugzilla.redhat.com/show_bug.cgi?id=1094697
> > _______________________________________________
> > nodejs mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
> > _______________________________________________
> > nodejs mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]

[Ben Rosser]

On Thu, Feb 9, 2017 at 4:50 AM, Zuzana Svetlikova  wrote:
> Hi,
>
> I pdated bytes in rawhide, I'll make update for f25 when other packages are ready
> so we don't break something.
>
> Zuzka

Thanks for the quick update!

Ben Rosser

[Ben Rosser]

On Sun, Feb 12, 2017 at 12:20 AM, Ben Rosser  wrote:
> On Thu, Feb 9, 2017 at 4:50 AM, Zuzana Svetlikova  wrote:
> > Hi,
> >
> > I pdated bytes in rawhide, I'll make update for f25 when other packages are ready
> > so we don't break something.
> >
> > Zuzka
>
> Thanks for the quick update!

Hi,

Thanks again for updating nodejs-bytes. Unfortunately, it seems that
there is still an issue here:
> Error: nothing provides npm(iconv-lite) >= 0.4.15 needed by nodejs-raw-body-2.2.0-1.fc26.noarch

I assume that the nodejs-bytes package now needs a %nodejs_fixdep in
order to remove the versioned dependency on iconv-lite (or our
iconv-lite package needs to be updated-- 0.4.15 is current upstream
and we're shipping 0.4.13-- but given the fact that those version
numbers are pretty close, I'd suspect this isn't necessary).

Ben Rosser

[Tom Hughes]

On 17/02/17 04:41, Ben Rosser wrote:
> Thanks again for updating nodejs-bytes. Unfortunately, it seems that
> there is still an issue here:
> > Error: nothing provides npm(iconv-lite) >= 0.4.15 needed by nodejs-raw-body-2.2.0-1.fc26.noarch
>
> I assume that the nodejs-bytes package now needs a %nodejs_fixdep in
> order to remove the versioned dependency on iconv-lite (or our
> iconv-lite package needs to be updated-- 0.4.15 is current upstream
> and we're shipping 0.4.13-- but given the fact that those version
> numbers are pretty close, I'd suspect this isn't necessary).

I've built 0.4.15 into rawhide now.

Tom

[Piotr Popieluch]

nodejs-connect and nodejs-compression have broken deps now. My first look
at nodejs-connect gives me the impression that it is not trivial to update.
Zuzana, do I understand correctly that you are working on updating those
packages?

Op vr 17 feb. 2017 om 11:03 schreef Tom Hughes :
> On 17/02/17 04:41, Ben Rosser wrote:
> > Thanks again for updating nodejs-bytes. Unfortunately, it seems that
> > there is still an issue here:
> > > Error: nothing provides npm(iconv-lite) >= 0.4.15 needed by
>
> nodejs-raw-body-2.2.0-1.fc26.noarch
> > I assume that the nodejs-bytes package now needs a %nodejs_fixdep in
> > order to remove the versioned dependency on iconv-lite (or our
> > iconv-lite package needs to be updated-- 0.4.15 is current upstream
> > and we're shipping 0.4.13-- but given the fact that those version
> > numbers are pretty close, I'd suspect this isn't necessary).
>
> I've built 0.4.15 into rawhide now.
>
> Tom
>
> --
> Tom Hughes ([e-mail])
> http://compton.nu/
> _______________________________________________
> nodejs mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Piotr Popieluch]

Op vr 17 feb. 2017 om 13:14 schreef Piotr Popieluch :
> nodejs-connect and nodejs-compression have broken deps now. My first look
> at nodejs-connect gives me the impression that it is not trivial to update

I've create two review requests needed for updating nodejs-compression:
https://bugzilla.redhat.com/show_bug.cgi?id=1424660
https://bugzilla.redhat.com/show_bug.cgi?id=1424655

[Zuzana Svetlikova]

I've made review requests for nodejs-connect:

https://bugzilla.redhat.com/show_bug.cgi?id=1424859
https://bugzilla.redhat.com/show_bug.cgi?id=1424860

I'm sorry it takes me so long and thanks for help.

----- Original Message -----
From: "Piotr Popieluch" 
To: "Node.js on Fedora" 
Sent: Saturday, February 18, 2017 1:21:06 AM
Subject: Re: Updating nodejs-bytes

Op vr 17 feb. 2017 om 13:14 schreef Piotr Popieluch < [e-mail] >:

nodejs-connect and nodejs-compression have broken deps now. My first look at nodejs-connect gives me the impression that it is not trivial to update

I've create two review requests needed for updating nodejs-compression: 
https://bugzilla.redhat.com/show_bug.cgi?id=1424660 
https://bugzilla.redhat.com/show_bug.cgi?id=1424655

_______________________________________________
nodejs mailing list -- [e-mail]
To unsubscribe send an email to [e-mail]