Update jquery to 3.2.1?

[Christopher]

I have a patch prepped to update js-jquery to 3.2.1, and was wondering if I
should do it for F26.

I'm not a javascript expert, and certainly not that familiar with nodejs
stuffs, but jquery is a pretty simple package, and I need it for my web app.

The only significant issue I ran into is that the new version adds a build
dependency on "insight" for some sort of tracking feature. This doesn't
appear to work in Fedora (the nodejs-grunt-insight package doesn't exist?)
and the tracking feature can be easily patched out.

Does anybody have any thoughts/opinions/expertise on these matters and can
help make a decision about when to update jquery in Fedora?

[Tom Hughes]

On 28/03/17 18:00, Christopher wrote:

>  I have a patch prepped to update js-jquery to 3.2.1, and was
> wondering
>  if I should do it for F26.
>
>  I'm not a javascript expert, and certainly not that familiar with nodejs
>  stuffs, but jquery is a pretty simple package, and I need it for my web app. 
What are you updating from? and if it's a significant version change 
then what other dependants does it have that might get broken?

Tom

-- 
Tom Hughes (tom(a)compton.nu)
http://compton.nu/

[Christopher]

On Tue, Mar 28, 2017 at 1:11 PM Tom Hughes <tom(a)compton.nu&gt; wrote:

>  On 28/03/17 18:00, Christopher wrote:
>
>  > I have a patch prepped to update js-jquery to 3.2.1, and was wondering
>  > if I should do it for F26.
>  >
>  > I'm not a javascript expert, and certainly not that familiar with nodejs
>  > stuffs, but jquery is a pretty simple package, and I need it for my web
>  app.
>
>  What are you updating from? and if it's a significant version change
>  then what other dependants does it have that might get broken?
>
>  
The current version in Fedora is 2.2.4 (which is quite old now). I don't
know what it might break... I'm not even sure how to check which packages
depend on js-jquery. I've only taken over js-jquery because it was orphaned
for awhile, I need it for my package, and I didn't want it to get retired.
One thing I know... it's not reasonable to keep packaging *every* major
version of jQuery. Currently, there is js-jquery1 (which is the last
version 1) and js-jquery (which is the last version 2). I would like to
retire js-jquery1 eventually, and just keep js-jquery at the latest.


>  Tom
>
>  --
>  Tom Hughes (tom(a)compton.nu)
>  http://compton.nu/
>

[Tom Hughes]

On 28/03/17 18:49, Christopher wrote:

>  The current version in Fedora is 2.2.4 (which is quite old now). I
> don't
>  know what it might break... I'm not even sure how to check which
>  packages depend on js-jquery. I've only taken over js-jquery because it
>  was orphaned for awhile, I need it for my package, and I didn't want it
>  to get retired. One thing I know... it's not reasonable to keep
>  packaging *every* major version of jQuery. Currently, there is
>  js-jquery1 (which is the last version 1) and js-jquery (which is the
>  last version 2). I would like to retire js-jquery1 eventually, and just
>  keep js-jquery at the latest. 
Well rubygem-jquery-rails is a definite issue:

rubygem-jquery-rails-0:4.2.2-2.fc26.noarch
jquery = 1.12.4
jquery = 2.2.4

As far as I can see nothing else has an require that would actually be 
broken, and I don't think 2 to 3 is as big an issue as 1 to 2 so you 
might be ok.

You need to talk to the rubygem maintainer though, as that always has to 
be updated in lockstep with the main package.

Tom

-- 
Tom Hughes (tom(a)compton.nu)
http://compton.nu/

[Matthias Runge]

On Tue, Mar 28, 2017 at 07:02:37PM +0100, Tom Hughes wrote:
>  On 28/03/17 18:49, Christopher wrote:
>  
>  > The current version in Fedora is 2.2.4 (which is quite old now). I don't
>  > know what it might break... I'm not even sure how to check which
>  > packages depend on js-jquery. I've only taken over js-jquery because it
>  > was orphaned for awhile, I need it for my package, and I didn't want it
>  > to get retired. One thing I know... it's not reasonable to keep
>  > packaging *every* major version of jQuery. Currently, there is
>  > js-jquery1 (which is the last version 1) and js-jquery (which is the
>  > last version 2). I would like to retire js-jquery1 eventually, and just
>  > keep js-jquery at the latest.
>  
>  Well rubygem-jquery-rails is a definite issue:
>  
>  rubygem-jquery-rails-0:4.2.2-2.fc26.noarch
>  jquery = 1.12.4
>  jquery = 2.2.4
>  
>  As far as I can see nothing else has an require that would actually be
>  broken, and I don't think 2 to 3 is as big an issue as 1 to 2 so you might
>  be ok.
>  
>  You need to talk to the rubygem maintainer though, as that always has to be
>  updated in lockstep with the main package. 
python-XStatic-JQuery depends on js-jquery1 (and about 15 other
packages)

For those folks requiring jquery to upgrade to 3, how about introducing
js-jquery2 (for backwards compatibility) and upgrading js-jquery then?

Up to a certain point of time, it was ok to bundle js libs, you'd just
punish those maintainers who unbundled them.

-- 
Matthias Runge <mrunge(a)redhat.com&gt;

[Christopher]

On Wed, Mar 29, 2017 at 3:05 AM Matthias Runge <mrunge(a)redhat.com&gt; wrote:

>  On Tue, Mar 28, 2017 at 07:02:37PM +0100, Tom Hughes wrote:
>  > On 28/03/17 18:49, Christopher wrote:
>  >
>  > > The current version in Fedora is 2.2.4 (which is quite old now). I
>  don't
>  > > know what it might break... I'm not even sure how to check which
>  > > packages depend on js-jquery. I've only taken over js-jquery because it
>  > > was orphaned for awhile, I need it for my package, and I didn't want it
>  > > to get retired. One thing I know... it's not reasonable to keep
>  > > packaging *every* major version of jQuery. Currently, there is
>  > > js-jquery1 (which is the last version 1) and js-jquery (which is the
>  > > last version 2). I would like to retire js-jquery1 eventually, and just
>  > > keep js-jquery at the latest.
>  >
>  > Well rubygem-jquery-rails is a definite issue:
>  >
>  > rubygem-jquery-rails-0:4.2.2-2.fc26.noarch
>  > jquery = 1.12.4
>  > jquery = 2.2.4
>  >
>  > As far as I can see nothing else has an require that would actually be
>  > broken, and I don't think 2 to 3 is as big an issue as 1 to 2 so you
>  might
>  > be ok.
>  >
>  > You need to talk to the rubygem maintainer though, as that always has to
>  be
>  > updated in lockstep with the main package.
>
>  python-XStatic-JQuery depends on js-jquery1 (and about 15 other
>  packages)
>
>  For those folks requiring jquery to upgrade to 3, how about introducing
>  js-jquery2 (for backwards compatibility) and upgrading js-jquery then?
>
>  
I can introduce js-jquery2 to keep 2.2.4 around longer. I just don't want
to have too many compat packages in the long-term... when it's better if
people just migrate.

Any suggestions for the upgrade path? Should js-jquery2 have "Obsoletes:
js-jquery < 3"? Or should users automatically be upgraded to version 3, and
have to explicitly install js-jquery2?



>  Up to a certain point of time, it was ok to bundle js libs, you'd
> just
>  punish those maintainers who unbundled them.
>
>  --
>  Matthias Runge <mrunge(a)redhat.com&gt;
>

[Matthias Runge]

On Wed, Mar 29, 2017 at 11:30:45PM +0000, Christopher wrote:
>  On Wed, Mar 29, 2017 at 3:05 AM Matthias Runge
> <mrunge(a)redhat.com&gt; wrote:
>  
>  > python-XStatic-JQuery depends on js-jquery1 (and about 15 other
>  > packages)
>  >
>  > For those folks requiring jquery to upgrade to 3, how about introducing
>  > js-jquery2 (for backwards compatibility) and upgrading js-jquery then?
>  >
>  >
>  
>  I can introduce js-jquery2 to keep 2.2.4 around longer. I just don't want
>  to have too many compat packages in the long-term... when it's better if
>  people just migrate.
>  
>  Any suggestions for the upgrade path? Should js-jquery2 have "Obsoletes:
>  js-jquery < 3"? Or should users automatically be upgraded to version 3, and
>  have to explicitly install js-jquery2? 
If you'd have js-jquery version 3 obsolete all other js-jquery packages,
you'd upgrade it in all places, most probably leaving users with a
broken setup, there are a few breaking changes between 2 and 3. [1]

A safe path would introduce js-jquery2, obsoleting js-jquery <=
(specific version, like 2.2.4-1) and then introduce js-jquery as newer
major version.

There are currently 16 packages requiring js-jquery, they'd need to be
changed to explicitly require js-jquery2; after that change, we should
be good to upgrade js-query to jquery3. Does that sound reasonable?

Matthias


[1] https://jquery.com/upgrade-guide/3.0/#summary-of-important-changes
-- 
Matthias Runge <mrunge(a)redhat.com&gt;