Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491712
Alan Dunn <amdunn(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|needinfo?(amdunn(a)gmail.com) |
--- Comment #3 from Alan Dunn <amdunn(a)gmail.com> 2009-03-25 08:00:56 EDT ---
Should be fixed now in files at the same location (though in this case, unlike
in the example, %{my_ocaml_lib_dir}/*.a should be excluded from main and put
into devel in not just opt build due to libgmp_caml.a)
(In reply to comment #2)
> + rpmlint output
>
> rpmlint output all looks fine, and the things it notices
> can be ignored.
>
> + package name satisfies the packaging naming guidelines
> + specfile name matches the package base name
> + package should satisfy packaging guidelines
> + license meets guidelines and is acceptable to Fedora
> + license matches the actual package license
> LGPLv2 (not +)
> + %doc includes license file
> + spec file written in American English
> + spec file is legible
> + upstream sources match sources in the srpm
> 63ec244511e58bd1cbf5513dc7aaad8e 169186
> + package successfully builds on at least one architecture
> n/a ExcludeArch bugs filed
> + BuildRequires list all build dependencies
> n/a %find_lang instead of %{_datadir}/locale/*
> + binary RPM with shared library files must call ldconfig in %post and %postun
> + does not use Prefix: /usr
> - package owns all directories it creates
>
> Package should own %{my_ocaml_lib_dir}.
> Then %files should add %exclude lines for everything in -devel.
> See the example:
> http://fedoraproject.org/w/uploads/5/5c/Packaging_OCaml_ocaml-foolib.spec
>
> + no duplicate files in %files
> + %defattr line
> + %clean contains rm -rf $RPM_BUILD_ROOT
> + consistent use of macros
> + package must contain code or permissible content
> + large documentation files should go in -doc subpackage
> + files marked %doc should not affect package
> n/a header files should be in -devel
> n/a static libraries should be in -static
> n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
> n/a libfoo.so must go in -devel
> + -devel must require the fully versioned base
> n/a packages should not contain libtool .la files
> n/a packages containing GUI apps must include %{name}.desktop file
> + packages must not own files or directories owned by other packages
> + %install must start with rm -rf %{buildroot} etc.
> + filenames must be valid UTF-8
>
> Optional:
>
> n/a if there is no license file, packager should query upstream
> n/a translations of description and summary for non-English languages, if
> available
> + reviewer should build the package in mock
> + the package should build into binary RPMs on all supported architectures
> - review should test the package functions as described
> n/a scriptlets should be sane
> n/a pkgconfig files should go in -devel
> + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
> /usr/sbin
>
> ------------
>
> Please fix the directory ownership issue.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491712
Richard W.M. Jones <rjones(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |needinfo?(amdunn(a)gmail.com)
--- Comment #2 from Richard W.M. Jones <rjones(a)redhat.com> 2009-03-25 07:20:02 EDT ---
+ rpmlint output
rpmlint output all looks fine, and the things it notices
can be ignored.
+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
LGPLv2 (not +)
+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
63ec244511e58bd1cbf5513dc7aaad8e 169186
+ package successfully builds on at least one architecture
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
+ binary RPM with shared library files must call ldconfig in %post and %postun
+ does not use Prefix: /usr
- package owns all directories it creates
Package should own %{my_ocaml_lib_dir}.
Then %files should add %exclude lines for everything in -devel.
See the example:
http://fedoraproject.org/w/uploads/5/5c/Packaging_OCaml_ocaml-foolib.spec
+ no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
+ large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
+ -devel must require the fully versioned base
n/a packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8
Optional:
n/a if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock
+ the package should build into binary RPMs on all supported architectures
- review should test the package functions as described
n/a scriptlets should be sane
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin
------------
Please fix the directory ownership issue.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491712
--- Comment #1 from Richard W.M. Jones <rjones(a)redhat.com> 2009-03-25 07:07:06 EDT ---
Koji scratch-build in Rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1257820
/usr/bin/gmptop is an OCaml toplevel, but is protected from
being damaged by prelink .. Good.
$ hexdump -C /usr/bin/gmptop | tail -3
00239d20 00 0e 23 44 42 55 47 00 0d 2c 9f 00 00 00 06 43 |..#DBUG..,.....C|
00239d30 61 6d 6c 31 39 39 39 58 30 30 38 |aml1999X008|
00239d3b
> I would also appreciate comments on whether I should be going back and
> modifying the package's makefile to attempt to build libgmp_caml.a as a shared
> object - I believe this would be necessary to allow gmp.cma to be loaded
> dynamically.
I have no idea about this, but it shouldn't affect the review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491712
Richard W.M. Jones <rjones(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |fedora-ocaml-list(a)redhat.co
| |m
AssignedTo|nobody(a)fedoraproject.org |rjones(a)redhat.com
Alias| |ocaml-mlgmpidl
Flag| |fedora-review?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480807
Piotr Drąg <piotrdrag(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fedora-ocaml-list(a)redhat.co
| |m, piotrdrag(a)gmail.com,
| |rjones(a)redhat.com
Component|Spanish [es] |virt-ctrl
Version|unspecified |rawhide
AssignedTo|domingobecker(a)gmail.com |rjones(a)redhat.com
Product|Fedora Localization |Fedora
QAContact|domingobecker(a)gmail.com |extras-qa(a)fedoraproject.org
--- Comment #1 from Piotr Drąg <piotrdrag(a)gmail.com> 2009-03-23 14:10:26 EDT ---
Moving to correct component.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480812
Piotr Drąg <piotrdrag(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fedora-ocaml-list(a)redhat.co
| |m,
| |fedora-virt-maint(a)redhat.co
| |m, piotrdrag(a)gmail.com,
| |rjones(a)redhat.com
Component|Spanish [es] |virt-df
Version|unspecified |rawhide
AssignedTo|domingobecker(a)gmail.com |rjones(a)redhat.com
Product|Fedora Localization |Fedora
QAContact|domingobecker(a)gmail.com |extras-qa(a)fedoraproject.org
--- Comment #1 from Piotr Drąg <piotrdrag(a)gmail.com> 2009-03-23 14:09:33 EDT ---
Moving to correct component.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480817
Piotr Drąg <piotrdrag(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fedora-ocaml-list(a)redhat.co
| |m,
| |fedora-virt-maint(a)redhat.co
| |m, piotrdrag(a)gmail.com,
| |rjones(a)redhat.com
Component|Spanish [es] |virt-top
Version|unspecified |rawhide
AssignedTo|domingobecker(a)gmail.com |rjones(a)redhat.com
Product|Fedora Localization |Fedora
QAContact|domingobecker(a)gmail.com |extras-qa(a)fedoraproject.org
--- Comment #1 from Piotr Drąg <piotrdrag(a)gmail.com> 2009-03-23 14:06:41 EDT ---
Moving to correct component.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Something I thought I would address to the Fedora OCaml experts:
I want to package MLGMPIDL -
http://www.inrialpes.fr/pop-art/people/bjeannet/mlxxxidl-forge/mlgmpidl/ind…
- (it's a dependency for something else I want to package, in case
anyone is interested my path is MLGMPIDL -> APRON -> Frama-C). It
links to C code in a static library and produces OCaml native code and
bytecode libraries. What is the ideal way to package this? The
packaging guidelines state that I should try not to ship a static C
library if possible, but from what I understand (which may well be
wrong, so please correct me if needed) even with the latest OCaml,
bytecode and native code just don't mix, and there's no way to load a
shared C library from native code. Thus it seems that to ship native
and bytecode versions of the library, I need to ship the static
library anyway, so I should just use this for both versions
(separating it out into a -static package too?) Furthermore, even if
there is a way to do something great with OCaml 3.11, this isn't
available for Fedora 9 and 10 (and at least 10 will be around for a
while longer)...
If someone doesn't mind, if there's a definitive guide to exactly what
can and cannot be done with respect to native, bytecode, and external
C library linking and how this varies over OCaml version it would be
much appreciated - the information on this out there is tough for me
to parse, it seems to be in bits and pieces all over the place.
- Alan
Just a note to say that I've added three superb new OCaml packages:
*** ocaml-pa-do is a syntax extension which provides "delimited
overloading" of operators. In plain English, "operator overloading"
lets you overload operators, such as using "+" to mean addition of
complex numbers or vectors. Traditionally this has been regarded as
potentially dangerous in OCaml. Which is why this extension is
"delimited", meaning that sections of code where operator overloading
is permitted are clearly marked.
For example:
let z' =
Complex.( <-- the delimiter
log(z + 2I) = I / u <-- overloaded complex number expression
)
let bi =
Big_int.(
23 ** 567 mod 45 + "123456789123456789123456789"
)
You can add your own overloading using the pa_do API. pa_do comes
with overloadings for many existing integer types in OCaml.
http://pa-do.forge.ocamlcore.org/
*** ocaml-p3l is a parallel skeleton programming compiler. This
allows you to model the parallel aspects of your program using
templates such as MapReduce. It can then generate code which
transparently distributes itself both across clusters of machines, and
over multiple cores in a single machine.
OCamlP3L programs also have a deterministic, sequential interpretation
which allows you to prove properties of the program.
http://camlp3l.inria.fr/eng.htm
*** Finally coccinelle (spatch) is a framework for semantic patching
of Linux kernel code. Semantic patches describe changes to code in
terms of C expressions:
@@
expression lock, flags; <-- this is "any C expression" bound
expression urb; <-- to lock/flags/urb
@@
spin_lock_irqsave(lock, flags);
<...
- usb_submit_urb(urb)
+ usb_submit_urb(urb, GFP_ATOMIC)
...>
spin_unlock_irqrestore(lock, flags);
@@
expression urb;
@@
- usb_submit_urb(urb)
+ usb_submit_urb(urb, GFP_KERNEL)
http://lwn.net/Articles/315686/http://www.emn.fr/x-info/coccinelle/
Rich.
--
Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/