On Thu, 2021-04-08 at 19:18 -0600, Jerry James wrote:
I am currently traveling, with only my phone for accessing email, so please pardon top posting, HTML, etc. I also have the goal of bringing Infer to Fedora, so I am happy to make common cause with you.
Are you aware of my efforts to build an OCaml spec generator? See https://pagure.io/opam2rpm. It isn't finished, but it is useful for getting started.
That looks handy, thanks! I'm halfway through packaging the next package Infer needs (camlzip) so I already wrote a manual spec file for it too, but I'll check out opam2rpm for the next dependency in line.
I can be more helpful next week when I am home & have my beloved Fedora desktop in front of me. :-)
Hope to have a set of review requests by then!
Best regards,
On Fri, Apr 9, 2021 at 5:33 PM Michel Alexandre Salim michel@michel-slm.name wrote:
ok, the camlzip OPAM module still uses Makefiles to install, and rather than trying to make sure I override the right environment variables to get it to build correctly, I figured I'd rather fix opam2rpm to support Zip archives:
Thank you! I have merged the pull request. I want to point out, too, that camlzip is already packaged as ocaml-zip. Also, I recently announced a dependency visualizer, named depict, and included an example of visualizing the dependencies of Infer. See https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/...
I will take a look at your review request for ocaml-atd. Regards,
On Mon, 2021-04-12 at 15:51 -0600, Jerry James wrote:
On Fri, Apr 9, 2021 at 5:33 PM Michel Alexandre Salim michel@michel-slm.name wrote:
ok, the camlzip OPAM module still uses Makefiles to install, and rather than trying to make sure I override the right environment variables to get it to build correctly, I figured I'd rather fix opam2rpm to support Zip archives:
Thank you! I have merged the pull request. I want to point out, too, that camlzip is already packaged as ocaml-zip. Also, I recently announced a dependency visualizer, named depict, and included an example of visualizing the dependencies of Infer. See
Oh, thanks, I guess I really should use the `ocaml(...)` notation for dependencies.
Best regards,
Taking out devel@ to reduce noise
On Thu, 2021-04-15 at 18:11 -0700, Michel Alexandre Salim wrote:
On Mon, 2021-04-12 at 15:51 -0600, Jerry James wrote:
On Fri, Apr 9, 2021 at 5:33 PM Michel Alexandre Salim michel@michel-slm.name wrote:
ok, the camlzip OPAM module still uses Makefiles to install, and rather than trying to make sure I override the right environment variables to get it to build correctly, I figured I'd rather fix opam2rpm to support Zip archives:
Thank you! I have merged the pull request. I want to point out, too, that camlzip is already packaged as ocaml-zip. Also, I recently announced a dependency visualizer, named depict, and included an example of visualizing the dependencies of Infer. See
Oh, thanks, I guess I really should use the `ocaml(...)` notation for dependencies.
Speaking of camlzip, looks like we need to add a mapping from camlzip => ocaml-zip-devel?
https://pagure.io/opam2rpm/pull-request/7
Also, I have a weird issue that I can't quite repro: the first time I tried `opam2rpm javalib` I get a spec generated that correctly calls ./configure.sh and make. Then I created the patch, did `python setup.py install`, and did `opam2rpm javalib` again... and those two lines disappear.
After stashing my change and installing again -- or even doing a new checkout and creating a new venv, the calls to ./configure.sh and make are still gone, so this is unrelated to my added mapping. Not sure what I'm doing wrong there...
Repro steps: - clone opam2rpm - cd opam2rpm - python3 -m venv .venv - source .venv/bin/activate - python setup.py install - opam2rpm javalib
I can file an issue if needed.
Thanks,
On Thu, Apr 15, 2021 at 8:10 PM Michel Alexandre Salim michel@michel-slm.name wrote:
Speaking of camlzip, looks like we need to add a mapping from camlzip => ocaml-zip-devel?
Thanks! I'll look at that momentarily.
Also, I have a weird issue that I can't quite repro: the first time I tried `opam2rpm javalib` I get a spec generated that correctly calls ./configure.sh and make. Then I created the patch, did `python setup.py install`, and did `opam2rpm javalib` again... and those two lines disappear.
After stashing my change and installing again -- or even doing a new checkout and creating a new venv, the calls to ./configure.sh and make are still gone, so this is unrelated to my added mapping. Not sure what I'm doing wrong there...
Repro steps:
- clone opam2rpm
- cd opam2rpm
- python3 -m venv .venv
- source .venv/bin/activate
- python setup.py install
- opam2rpm javalib
I can file an issue if needed.
I checked in a big patch yesterday and probably broke something. :-( You've given me the steps to reproduce. Let me see if I can diagnose the problem. Thanks!
On Fri, Apr 16, 2021 at 8:38 AM Jerry James loganjerry@gmail.com wrote:
I checked in a big patch yesterday and probably broke something. :-( You've given me the steps to reproduce. Let me see if I can diagnose the problem. Thanks!
It should be fixed now. I added a bunch of typing annotations yesterday and managed to break the %build script generator with some code changes intended to satisfy mypy.
On Fri, 2021-04-16 at 08:56 -0600, Jerry James wrote:
On Fri, Apr 16, 2021 at 8:38 AM Jerry James loganjerry@gmail.com wrote:
I checked in a big patch yesterday and probably broke something. :- ( You've given me the steps to reproduce. Let me see if I can diagnose the problem. Thanks!
It should be fixed now. I added a bunch of typing annotations yesterday and managed to break the %build script generator with some code changes intended to satisfy mypy.
Aha, thanks. I thought I tried backing out to a known good state but I must have forgotten to do 'python setup.py install' after then.
ocaml-devel@lists.fedoraproject.org
-
Jerry James -
Michel Alexandre Salim