The last OCaml mass rebuild made incorrect changes to two spec files that use rpmautospec, namely ocaml-base64 and ocaml-opam-file-format. The Release field should be reverted to plain "%autorelease" and the changelog entry above "%autochangelog" removed. If nobody has time to deal with it before the mass rebuild starts, I can fix them.
On Wed, Jan 19, 2022 at 4:03 PM Jerry James loganjerry@gmail.com wrote:
The last OCaml mass rebuild made incorrect changes to two spec files that use rpmautospec, namely ocaml-base64 and ocaml-opam-file-format. The Release field should be reverted to plain "%autorelease" and the changelog entry above "%autochangelog" removed. If nobody has time to deal with it before the mass rebuild starts, I can fix them.
And 1 hour later the email goes out announcing the start of the mass rebuild. I'm going to fix these 2 packages and beg for forgiveness later if necessary.
On Wed, Jan 19, 2022 at 04:03:32PM -0700, Jerry James wrote:
The last OCaml mass rebuild made incorrect changes to two spec files that use rpmautospec, namely ocaml-base64 and ocaml-opam-file-format. The Release field should be reverted to plain "%autorelease" and the changelog entry above "%autochangelog" removed. If nobody has time to deal with it before the mass rebuild starts, I can fix them.
Sorry, I probably just did that again.
I'll fix them shortly, but we'll somehow have to fix the OCaml mass build script to cope with this (which is difficult because it uses a magic string in the changelog as a sentinel to know if the releaes has been bumped).
Rich.
On Wed, Jan 19, 2022 at 04:03:32PM -0700, Jerry James wrote:
The last OCaml mass rebuild made incorrect changes to two spec files that use rpmautospec, namely ocaml-base64 and ocaml-opam-file-format. The Release field should be reverted to plain "%autorelease" and the changelog entry above "%autochangelog" removed. If nobody has time to deal with it before the mass rebuild starts, I can fix them.
Actually now I look, it's fine, and I've no idea why!
Maybe rpmdev-bumpspec (which I use to update the changelog) has some magic for rpmautospec files?
Rich.
On Fri, Feb 04, 2022 at 10:20:30PM +0000, Richard W.M. Jones wrote:
On Wed, Jan 19, 2022 at 04:03:32PM -0700, Jerry James wrote:
The last OCaml mass rebuild made incorrect changes to two spec files that use rpmautospec, namely ocaml-base64 and ocaml-opam-file-format. The Release field should be reverted to plain "%autorelease" and the changelog entry above "%autochangelog" removed. If nobody has time to deal with it before the mass rebuild starts, I can fix them.
Actually now I look, it's fine, and I've no idea why!
Maybe rpmdev-bumpspec (which I use to update the changelog) has some magic for rpmautospec files?
Yes:
$ rpmdev-bumpspec -c '- OCaml 4.13.1 rebuild to remove package notes' *.spec RPMAutoSpec usage detected, not changing the spec file. $ echo $? 0
Unfortunately while that works fine from the rpmdev-bumpspec point of view, it doesn't work well for the goals file which is expecting to use that message in the %changelog to know that the package was bumped:
http://git.annexia.org/?p=goals.git;a=blob;f=stdlib/fedora.gl;h=cb518bc7ab12...
I'll have to work around this for now - not sure how to fix this properly yet.
Rich.
On Fri, Feb 4, 2022 at 3:25 PM Richard W.M. Jones rjones@redhat.com wrote:
Unfortunately while that works fine from the rpmdev-bumpspec point of view, it doesn't work well for the goals file which is expecting to use that message in the %changelog to know that the package was bumped:
http://git.annexia.org/?p=goals.git;a=blob;f=stdlib/fedora.gl;h=cb518bc7ab12...
I'll have to work around this for now - not sure how to fix this properly yet.
I haven't looked at the goals code at all, so this may be nonsense. Would it be possible to look for "%autochangelog" as the latest changelog message and, if that is found, consult "git log -n 1 --oneline" to see if the message is there?
On Wed, Feb 09, 2022 at 08:49:59AM -0700, Jerry James wrote:
On Fri, Feb 4, 2022 at 3:25 PM Richard W.M. Jones rjones@redhat.com wrote:
Unfortunately while that works fine from the rpmdev-bumpspec point of view, it doesn't work well for the goals file which is expecting to use that message in the %changelog to know that the package was bumped:
http://git.annexia.org/?p=goals.git;a=blob;f=stdlib/fedora.gl;h=cb518bc7ab12...
I'll have to work around this for now - not sure how to fix this properly yet.
I haven't looked at the goals code at all, so this may be nonsense. Would it be possible to look for "%autochangelog" as the latest changelog message and, if that is found, consult "git log -n 1 --oneline" to see if the message is there?
Yes, it'll be something like that.
Rich.
ocaml-devel@lists.fedoraproject.org
-
Jerry James -
Richard W.M. Jones