Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: ocaml-camlp5 pretty printer bug
https://bugzilla.redhat.com/show_bug.cgi?id=691913
Summary: ocaml-camlp5 pretty printer bug Product: Fedora Version: 15 Platform: All OS/Version: Linux Status: NEW Severity: unspecified Priority: unspecified Component: ocaml-camlp5 AssignedTo: rjones@redhat.com ReportedBy: loganjerry@gmail.com QAContact: extras-qa@fedoraproject.org CC: rjones@redhat.com, fedora-ocaml-list@redhat.com Classification: Fedora Story Points: ---
Description of problem: I'm trying to build the latest version of coq. The build is failing on F-15. Coq upstream claims it is a known bug in the camlp5 pretty printer. The upstream discussion is here (may require registration):
http://www.lix.polytechnique.fr/coq/bugs/show_bug.cgi?id=2468
That bug says the patch to fix the problem is as follows (may be whitespace mangled due to cutting and pasting between browser tabs):
Index: etc/pr_o.ml =================================================================== RCS file: /home/ROCQ/aosteroc/deraugla/repository/camlp5/etc/pr_o.ml,v retrieving revision 6.48 retrieving revision 6.49 diff -r6.48 -r6.49 2c2 < (* $Id: pr_o.ml,v 6.48 2010-11-21 17:17:45 deraugla Exp $ *) ---
(* $Id: pr_o.ml,v 6.49 2010-12-06 10:31:00 deraugla Exp $ *)
2083c2083 < | None -> patt pc p ] ---
| None -> pprintf pc "~%p" patt p ]
Version-Release number of selected component (if applicable): ocaml-camlp5-6.02.1-2.fc15.x86_64
How reproducible: Always
Steps to Reproduce: 1. Attempt to compile coq (vanilla upstream tarball shows the problem) 2. 3.
Actual results: File "toplevel/mltop.optml", line 112, characters 63-64: Error: The function applied to this argument has type ?warn:bool -> System.physical_path * string This argument cannot be applied without label make[1]: *** [toplevel/mltop.cmx] Error 2
Expected results: Successful compilation.
Additional info:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691913
Stéphane Glondu steph@glondu.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |steph@glondu.net
--- Comment #1 from Stéphane Glondu steph@glondu.net 2011-03-29 17:15:53 EDT --- FTR, the latest version of Coq (8.3pl1) compiles with the latest version of camlp5 (6.02.2 + the three patches listed on the camlp5 website). I guess you are using camlp5 6.02.1, which needs the matching patches still available from [1].
[1] http://pauillac.inria.fr/~ddr/camlp5/distrib/src/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691913
--- Comment #2 from Richard W.M. Jones rjones@redhat.com 2011-03-30 08:45:13 EDT --- Jerry, if you are in the Fedora packager group, please apply to co-maintain ocaml-camlp5. That way you can add these patches yourself.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691913
--- Comment #3 from Jerry James loganjerry@gmail.com 2011-03-30 12:52:52 EDT --- (In reply to comment #2)
Jerry, if you are in the Fedora packager group, please apply to co-maintain ocaml-camlp5. That way you can add these patches yourself.
Actually, coq upstream provided a workaround for this bug. Plus, I don't know that I'm competent to maintain any core ocaml packages, given my almost total lack of knowledge of things ocaml. I think it would be better for me to apply the coq workaround, to be removed once a fixed camlp5 makes it into Fedora.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691913
--- Comment #4 from Jerry James loganjerry@gmail.com 2011-10-27 16:22:37 EDT --- Even though I still don't want to comaintain ocaml-camlp5, I would like to see us get a version with this bug fixed. I'm going to commit the changes necessary to move to version 6.02.3, which fixes all the (known) bugs I care about as coq comaintainer.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691913
--- Comment #5 from Richard W.M. Jones rjones@redhat.com 2011-10-27 16:59:55 EDT --- Thanks for pushing a fix. Can we close this bug?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691913
--- Comment #6 from Jerry James loganjerry@gmail.com 2011-10-27 17:13:51 EDT --- I'd like to update ocaml-camlp5 for F16 too, unless you object. Since I'm not a maintainer of this package, I'll need you to do a build override for me so I can rebuild coq. (There are 2 ocaml-camlp5 symbols that coq depends on whose hashes are different in this new version.) I can ask you for the override here or in email, your choice. If email, then we might as well close this bug, sure.
I'm building the ocaml-camlp5 -> coq chain in Rawhide right now. If all goes well with that, I'll build ocaml-camlp5 for F16 afterwards and then contact you.
Also, I believe that coq is the only package that requires a rebuild due to this update. At least, I had repoquery check everything ocaml-camlp5 provides, and coq was the only dependency I turned up.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691913
--- Comment #7 from Richard W.M. Jones rjones@redhat.com 2011-10-27 18:21:48 EDT --- Yes please, go for it. If you were co-maint then you should be able to request build overrides too?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691913
--- Comment #8 from Jerry James loganjerry@gmail.com 2011-10-27 18:25:53 EDT --- Zing! :-) Yes, you're right, But I'm trying really hard to NOT pick up more packages to comaintain, because I've got a couple dozen packages waiting in the wings that I want to push into Fedora. Plus, I'm still pretty uncomfortable with ocaml. I've got to learn that language one of these days....
I'm ready for the F16 buildroot override any time now, please. Thanks.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691913
--- Comment #9 from Richard W.M. Jones rjones@redhat.com 2011-10-28 04:56:20 EDT --- Done ...
$ bodhi --buildroot-override=ocaml-camlp5-6.02.3-1.fc16 Notes: Password for rjones: Notes: Your buildroot override has been successfully tagged. It may take up to 20 minutes for the buildroot to regenerate. You can wait for the new buildroot by running `koji wait-repo f16-build`
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691913
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691913
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-10-28 16:40:46 EDT --- ocaml-camlp5-6.02.3-1.fc16,coq-8.3pl2-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ocaml-camlp5-6.02.3-1.fc16,coq-8.3pl...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691913
--- Comment #11 from Jerry James loganjerry@gmail.com 2011-10-28 16:49:29 EDT --- Thank you. I'm all done with the buildroot override. Sorry for being such a pain about comaintaining.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691913
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-10-31 21:25:56 EDT --- Package ocaml-camlp5-6.02.3-1.fc16, coq-8.3pl2-3.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing ocaml-camlp5-6.02.3-1.fc16 coq-8.3pl2-3.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2011-15177 then log in and leave karma (feedback).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691913
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |ocaml-camlp5-6.02.3-1.fc16 Resolution| |ERRATA Last Closed| |2011-11-10 12:40:26
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-11-10 12:40:26 EST --- ocaml-camlp5-6.02.3-1.fc16, coq-8.3pl2-3.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.
ocaml-devel@lists.fedoraproject.org
-
Red Hat Bugzilla