Hello,
I'm working on submitting olpc-switch-desktop for inclusion in Fedora. I (or rather rpmlint) found these issues:
The .spec from the repo, the GNOME .desktop and the Sugar control panel references a couple of SVG files, but those aren't in the repo. Are there any suitable icons to use or do someone need to create them?
The .spec creates /etc/skel/Desktop (for the GNOME .desktop file). I think that breaks the feature that a name from the user's locale is used when creating the desktop directory (xdg-user-dirs), so that needs to be done some other way.
Is there a way to place an icon on every user's desktop without poking around in their ~/Desktop? If not, perhaps the Sugar part can install the GNOME .desktop file for the user when the user first switches from Sugar to GNOME? Then it is only done for GNOME users who actually ran Sugar in the first place (call that a feature or a bug) and by then the locale is hopefully set correctly so that the desktop directory can be created the proper way.
Also, the GNOME app should probably have a license declaration at the top of the source file, or the license should be stated explicitly in the README.
/abo
On Sun, 2009-06-28 at 21:52 +0200, Alexander Boström wrote:
I'm working on submitting olpc-switch-desktop for inclusion in Fedora. I (or rather rpmlint) found these issues:
The .spec from the repo, the GNOME .desktop and the Sugar control panel references a couple of SVG files, but those aren't in the repo. Are there any suitable icons to use or do someone need to create them?
Oops, added now. Thanks for pointing this out.
The .spec creates /etc/skel/Desktop (for the GNOME .desktop file). I think that breaks the feature that a name from the user's locale is used when creating the desktop directory (xdg-user-dirs), so that needs to be done some other way.
Even when I clear /home/olpc completely, open Sugar, change to spanish and switch to GNOME, the directory that gets created is /home/olpc/Desktop - it does not seem to be localized.
I do not know of any other way of adding other icons to the desktop.
Also, the GNOME app should probably have a license declaration at the top of the source file, or the license should be stated explicitly in the README.
OK will add...
Thanks! Daniel
Den 2009-06-30 11:22, Daniel Drake skrev:
Even when I clear /home/olpc completely, open Sugar, change to spanish and switch to GNOME, the directory that gets created is /home/olpc/Desktop - it does not seem to be localized.
Hmm. I installed F10 on some machine a while back, with sv_SE as the default locale, created a fresh user account and got ~/Skrivbord instead of Desktop.
Are you sure you also cleared out ~/.config/user-dirs.* ?
I do not know of any other way of adding other icons to the desktop.
Me neither. But the approach of creating the .desktop when first switching from Sugar to GNOME should be ok. As I'm sure Sugar will be the default wherever this package is relevant this shouldn't break anything.
Btw, maybe olpc-switch-desktop should really just be writing to ~/.dmrc ?
/abo
On Tue, 2009-06-30 at 12:16 +0200, Alexander Boström wrote:
Hmm. I installed F10 on some machine a while back, with sv_SE as the default locale, created a fresh user account and got ~/Skrivbord instead of Desktop.
Are you sure you also cleared out ~/.config/user-dirs.* ?
Yes. Maybe the problem is that the xdg-user-dirs component is not being included in our session.
Mind you, at least it works at the moment ;)
Btw, maybe olpc-switch-desktop should really just be writing to ~/.dmrc ?
Which system component reads from that?
Daniel
Den 2009-06-30 13:13, Daniel Drake skrev:
On Tue, 2009-06-30 at 12:16 +0200, Alexander Boström wrote:
Maybe the problem is that the xdg-user-dirs component is not being included in our session.
Oh. It's probably a good idea to make sure that it's installed by default on all Sugar and GNOME distros. (KDE has a dependency on it, btw.)
Btw, maybe olpc-switch-desktop should really just be writing to ~/.dmrc ?
Which system component reads from that?
I don't know if it's a proper standard, but GDM documents it here: http://library.gnome.org/admin/gdm/stable/configuration.html.en#userconfig
/abo
On Tue, 2009-06-30 at 12:16 +0200, Alexander Boström wrote:
Hmm. I installed F10 on some machine a while back, with sv_SE as the default locale, created a fresh user account and got ~/Skrivbord instead of Desktop.
Are you sure you also cleared out ~/.config/user-dirs.* ?
OK, I changed olpc-session to better integrate with xinitrc.d and now it creates and uses those localized directories, and puts the icon in the right polace.
The /etc/skel installation from olpc-switch-desktop can now be dropped.
Thanks, Daniel
Den 2009-06-30 14:59, Daniel Drake skrev:
OK, I changed olpc-session to better integrate with xinitrc.d and now it creates and uses those localized directories, and puts the icon in the right polace.
Hmm... I can't find that changeset.
Here's an rpm anyway:
http://www.root.snowtree.se/abo/fedora/reviews/olpc-switch-desktop/
I haven't submitted it for review yet.
/abo
On Sat, 2009-07-04 at 12:37 +0200, Alexander Boström wrote:
Den 2009-06-30 14:59, Daniel Drake skrev:
OK, I changed olpc-session to better integrate with xinitrc.d and now it creates and uses those localized directories, and puts the icon in the right polace.
Hmm... I can't find that changeset.
Here's an rpm anyway:
http://www.root.snowtree.se/abo/fedora/reviews/olpc-switch-desktop/
Thanks for your efforts. I cleaned up the package and have created a review request here: https://bugzilla.redhat.com/show_bug.cgi?id=510626
Daniel
-
Alexander Boström -
Alexander Boström -
Daniel Drake