Here's an executive summary of all outstanding patches in my queue:
http://people.sugarlabs.org/bernie/sugar/sugar-0.88-patches/
Most of these have already been submitted to sugar-devel@ or attached to tickets in bugs.sugarlabs.org.
Some of these patches have outstanding quality issues, but all of them have been integrated and tested for a while in F11-0.88 and together contribute to a better Sugar experience.
== Bugfixes ==
sugar-toolkit/use-set_toolbar_box-in-example-code.patch sugar-toolkit/set-default-accelerators-for-Copy-and-Paste-buttons.patch
These have been ack'd by Alsroot. Do we also need Erikos' approval?
sugar-toolkit/sl1842-notify-red-alert.patch sugar/sl1842-journal-error-messates.patch
The review has been swamped by a design discussion. It's not clear what Anish should do to pass review.
sugar-toolkit/sl1948-Race-condition-with-name-widget-in-the-activ.patch
This patch has a corner case in which it fails to update the activity name, but I think it's still a little better than the current behavior. See ticket for details.
sugar/add-font-dpi-schema.patch
This is a companion patch of a fix sugar-settings-manager which has already landed in git. It's needed by xulrunner (Browse).
sugar/avoid-popping-an-empty-list-in-the-software-updater.patch
Works, but James Cameron's posted a better counter-patch. Merge that one.
sugar/click-on-journal-icons-with-a-exclusive-time-frame.patch
Requested by the Waveplace folks. Please merge.
sugar/dynamically-set-number-of-control-panel-columns.patch
The approach to comoute the column width is wrong, but it produces better results than the current fixed number of columns. So, for now, I'm keeping it around.
sugar/fix-duplication-of-OLPC-mesh-icons.patch sugar/fix-for-file-list-sorting-for-FAT32-formatted-flash-drives-in-journal.patch
All the above have no issues to my knowledge and should be merged.
sugar/use-the-spanish-verb-quitar-for-unmounting-devices.patch
Better-than-nothing patch, but the real fix would require a gettext kludge in the code (see http://bugs.python.org/issue2504 )
== Minor bugfixes ==
sugar-toolkit/fix-two-trivial-shell-log-warnings.patch
Reviewed on sugar-devel, should be merged.
sugar-toolkit/sl1876.patch
Patch is in comment 2 of the ticket. It has been overlooked becuase the ticket had also an attachment.
sugar/fix-name-clash-set_state.patch
Should be merged.
== New Features ==
sugar/backup-0001-Volumes-Backup-and-Restore.patch sugar/backup-0002-Journal-XS-backup-and-restore.patch
There are concerns about restore deleting new entries since the last backup. I agree, but since nobody seems to have the time to implement and test a more sophisticated procedure, at this time this is the best restore feature we have for Sugar.
== Cleanups ==
sugar/simplify-the-definition-of-UpdateModel._bundles_to_check..patch
Merge.
sugar-toolkit/remove-incomplete-MANIFEST-support.patch
The incomplete design and implementation of MANIFEST files has been laying around for 3 years. We can choose to clean it up now, or let it bitrot for another 3 years.
== Experimental patches ==
sugar/set-default-scaling-to-100.patch
This is only required on the XO. We should really autodetect this.
sugar/cpu-and-memory-resource-indicator.patch
Not yet reviewed on sugar-devel@. Not even tested by us yet.
sugar-artwork/sl2006-icons-for-touchpad-panel.patch sugar/sl2006-touchpad-section-for-control-panel.patch sugar/sl2006-file-exists-check.patch
Walter's XO-1 touchpad control panel. For me, it could already go in, but it would be nice to add a global shortcut such as alt-shift-t, and maybe move the functionality to a frame icon, for fast switching.
sugar-toolkit/change-keep-string-to-keep-a-copy.patch
Several alternatives have been suggested on the list, but nobody implemented them, so this one still stands.
sugar-toolkit/kill-the-delayed-menus-for-good.patch
This change has been at the center of a huge design / UX / testing flame war a while ago. I've merged it to observe user reactions, so hopefully we can have a polite discussion based on some real data.
sugar/backup-0003-Journal-documents-volume-button.patch
We no longer need this feature since we decided to disable Gnome, but other deployments may find it useful. (but journal crashes when you drop files on the icon)
== Patches with outstanding issues ==
sugar-datastore/0001-Add-ctime-and-timestamp-properties-to-the-index.patch sugar-datastore/0002-Add-migration-from-DS-v0-code-for-the-new-properties.patch sugar-datastore/0003-increment-CURRENT_LAYOUT_VERSION-to-trigger-an-index-rebuild.patch sugar/sizelist-0000-cover-letter.patch sugar/sizelist-0001-Journal-Retrieve-filesize-from-the-datastore.patch sugar/sizelist-0002-Add-a-filesize-column-to-the-journal-list-model.patch sugar/sizelist-0003-Journaltoolbox-Add-add_separator-method-for-convenie.patch sugar/sizelist-0004-Add-a-ListViewButton-to-the-journal-search-toolbar.patch sugar/sizelist-0005-Rename-the-date-column-to-sort_column.patch sugar/sizelist-0006-Display-the-sorting-property-in-the-last-column.patch sugar/sizelist-0007-Expandedentry-Try-to-use-the-filesize-property.patch sugar/sizelist-0008-Implement-sorting-for-removable-devices.patch sugar/sizelist-0009-Add-sort-by-creation-time-option-to-the-ListViewButt.patch sugar/sizelist-0010-Add-ctime-property-to-the-journal-model.patch
Andres' series for sorting the journal by size. There's an outstanding problem with ctime being an integer rather than a string, as expected by Etoys. Andres is working on a fix.
sugar-toolkit/sugar-toolkit-dont-configure-fonts.patch sugar/sugar-enable-settings-manager.patch
We had to temporarily exclude these because sugar-settings-manager does not yet work well on F11-0.88.
== Obsolete patches ==
sugar/pe558-add-option-to-mount-any-user-directory-to-journal.patch sugar/pe558-backup-restore-front-end-for-control-panel.patch sugar/pe558-journal-management-control-panel-feature.patch sugar/pe558-modify-volumnestoolbar-to-mount-a-directory.patch
This patch set has been replaced by Tincho's Journal-based backup/restore functionality. Keeping these patches around in case someone else prefers the control panel UI.
sugar/fix-for-file-list-sorting-for-FAT32-formatted-flash-drives-in-journal.patch
The recent F11-0.88 builds present Home View List with the entries in oldest-to-newest order. I have over 100 Activities installed, and have to scroll down to the bottom of the Home View List in order to launch new Activities (if they are not present in the Home View Ring).
Please consider a "fix-for-activity-list-sorting", to present the Home View List to the user with the "most recent" entries shown first.
mikus
El Wed, 30-06-2010 a las 02:19 -0500, Mikus Grinbergs escribió:
sugar/fix-for-file-list-sorting-for-FAT32-formatted-flash-drives-in-journal.patch
The recent F11-0.88 builds present Home View List with the entries in oldest-to-newest order. I have over 100 Activities installed, and have to scroll down to the bottom of the Home View List in order to launch new Activities (if they are not present in the Home View Ring).
Please consider a "fix-for-activity-list-sorting", to present the Home View List to the user with the "most recent" entries shown first.
Confirmed. I wonder why it was changed. Can you please add a line in the F11-0.84 status page, so we don't forget to look into it?
http://wiki.sugarlabs.org/go/Deployment_Team/Sugar-0.88
Technically, it's a regression, but not very high priority.
On Wed, Jun 30, 2010 at 03:57, Bernie Innocenti bernie@codewiz.org wrote:
Here's an executive summary of all outstanding patches in my queue:
http://people.sugarlabs.org/bernie/sugar/sugar-0.88-patches/
Most of these have already been submitted to sugar-devel@ or attached to tickets in bugs.sugarlabs.org.
Some of these patches have outstanding quality issues, but all of them have been integrated and tested for a while in F11-0.88 and together contribute to a better Sugar experience.
== Bugfixes ==
sugar-toolkit/use-set_toolbar_box-in-example-code.patch sugar-toolkit/set-default-accelerators-for-Copy-and-Paste-buttons.patch
These have been ack'd by Alsroot. Do we also need Erikos' approval?
No, as per http://wiki.sugarlabs.org/go/Development_Team/Code_Review#Discussion .
sugar-toolkit/sl1842-notify-red-alert.patch
Correct me if I'm wrong, but I think both Gary and James agreed?
I wonder about performance, as fills on the XO-1 are very slow and if the fading was very smooth it could have a negative impact on the UX.
sugar/sl1842-journal-error-messates.patch
The review has been swamped by a design discussion. It's not clear what Anish should do to pass review.
Do you have a link to the controversy?
sugar-toolkit/sl1948-Race-condition-with-name-widget-in-the-activ.patch
This patch has a corner case in which it fails to update the activity name, but I think it's still a little better than the current behavior. See ticket for details.
I guess you and Simon need to agree on which bad is better.
sugar/add-font-dpi-schema.patch
This is a companion patch of a fix sugar-settings-manager which has already landed in git. It's needed by xulrunner (Browse).
Would be good if the commit message said why is that needed, or at least have a link to the ticket.
sugar/avoid-popping-an-empty-list-in-the-software-updater.patch
Works, but James Cameron's posted a better counter-patch. Merge that one.
sugar/click-on-journal-icons-with-a-exclusive-time-frame.patch
Requested by the Waveplace folks. Please merge.
What happened to the check for activity_id? We have it in other places in the UI with the similar issue.
sugar/dynamically-set-number-of-control-panel-columns.patch
The approach to comoute the column width is wrong, but it produces better results than the current fixed number of columns. So, for now, I'm keeping it around.
Anish has a better one already.
sugar/fix-duplication-of-OLPC-mesh-icons.patch sugar/fix-for-file-list-sorting-for-FAT32-formatted-flash-drives-in-journal.patch
All the above have no issues to my knowledge and should be merged.
sugar/use-the-spanish-verb-quitar-for-unmounting-devices.patch
Better-than-nothing patch, but the real fix would require a gettext kludge in the code (see http://bugs.python.org/issue2504 )
Shouldn't we make the change in Pootle? Or it will be synced automatically?
Or maybe we should go with the kludge as the real fix is most likely to not land in 2.x.
== Minor bugfixes ==
sugar-toolkit/fix-two-trivial-shell-log-warnings.patch
Reviewed on sugar-devel, should be merged.
sugar-toolkit/sl1876.patch
Patch is in comment 2 of the ticket. It has been overlooked becuase the ticket had also an attachment.
sugar/fix-name-clash-set_state.patch
Should be merged.
== New Features ==
sugar/backup-0001-Volumes-Backup-and-Restore.patch sugar/backup-0002-Journal-XS-backup-and-restore.patch
There are concerns about restore deleting new entries since the last backup. I agree, but since nobody seems to have the time to implement and test a more sophisticated procedure, at this time this is the best restore feature we have for Sugar.
Do we know any other deployment willing to deploy this?
If we decide to merge it, I think it should be disabled by default and have a gconf setting, because knowingly shipping a feature that causes data loss may not be a good idea.
== Cleanups ==
sugar/simplify-the-definition-of-UpdateModel._bundles_to_check..patch
Merge.
sugar-toolkit/remove-incomplete-MANIFEST-support.patch
The incomplete design and implementation of MANIFEST files has been laying around for 3 years. We can choose to clean it up now, or let it bitrot for another 3 years.
== Experimental patches ==
sugar/set-default-scaling-to-100.patch
This is only required on the XO. We should really autodetect this.
sugar/cpu-and-memory-resource-indicator.patch
Not yet reviewed on sugar-devel@. Not even tested by us yet.
sugar-artwork/sl2006-icons-for-touchpad-panel.patch sugar/sl2006-touchpad-section-for-control-panel.patch sugar/sl2006-file-exists-check.patch
Walter's XO-1 touchpad control panel. For me, it could already go in, but it would be nice to add a global shortcut such as alt-shift-t, and maybe move the functionality to a frame icon, for fast switching.
sugar-toolkit/change-keep-string-to-keep-a-copy.patch
Several alternatives have been suggested on the list, but nobody implemented them, so this one still stands.
sugar-toolkit/kill-the-delayed-menus-for-good.patch
This change has been at the center of a huge design / UX / testing flame war a while ago. I've merged it to observe user reactions, so hopefully we can have a polite discussion based on some real data.
I would go with whatever deployers decide.
sugar/backup-0003-Journal-documents-volume-button.patch
We no longer need this feature since we decided to disable Gnome, but other deployments may find it useful. (but journal crashes when you drop files on the icon)
== Patches with outstanding issues ==
sugar-datastore/0001-Add-ctime-and-timestamp-properties-to-the-index.patch sugar-datastore/0002-Add-migration-from-DS-v0-code-for-the-new-properties.patch sugar-datastore/0003-increment-CURRENT_LAYOUT_VERSION-to-trigger-an-index-rebuild.patch sugar/sizelist-0000-cover-letter.patch sugar/sizelist-0001-Journal-Retrieve-filesize-from-the-datastore.patch sugar/sizelist-0002-Add-a-filesize-column-to-the-journal-list-model.patch sugar/sizelist-0003-Journaltoolbox-Add-add_separator-method-for-convenie.patch sugar/sizelist-0004-Add-a-ListViewButton-to-the-journal-search-toolbar.patch sugar/sizelist-0005-Rename-the-date-column-to-sort_column.patch sugar/sizelist-0006-Display-the-sorting-property-in-the-last-column.patch sugar/sizelist-0007-Expandedentry-Try-to-use-the-filesize-property.patch sugar/sizelist-0008-Implement-sorting-for-removable-devices.patch sugar/sizelist-0009-Add-sort-by-creation-time-option-to-the-ListViewButt.patch sugar/sizelist-0010-Add-ctime-property-to-the-journal-model.patch
Andres' series for sorting the journal by size. There's an outstanding problem with ctime being an integer rather than a string, as expected by Etoys. Andres is working on a fix.
Is Aleksey ok with merging this?
Regards,
Tomeu
sugar-toolkit/sugar-toolkit-dont-configure-fonts.patch sugar/sugar-enable-settings-manager.patch
We had to temporarily exclude these because sugar-settings-manager does not yet work well on F11-0.88.
== Obsolete patches ==
sugar/pe558-add-option-to-mount-any-user-directory-to-journal.patch sugar/pe558-backup-restore-front-end-for-control-panel.patch sugar/pe558-journal-management-control-panel-feature.patch sugar/pe558-modify-volumnestoolbar-to-mount-a-directory.patch
This patch set has been replaced by Tincho's Journal-based backup/restore functionality. Keeping these patches around in case someone else prefers the control panel UI.
-- // Bernie Innocenti - http://codewiz.org/ \X/ Sugar Labs - http://sugarlabs.org/
Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
El Thu, 01-07-2010 a las 15:02 +0200, Tomeu Vizoso escribió:
sugar-toolkit/sl1842-notify-red-alert.patch
Correct me if I'm wrong, but I think both Gary and James agreed?
I wonder about performance, as fills on the XO-1 are very slow and if the fading was very smooth it could have a negative impact on the UX.
Looks smooth even on my XO-1...
sugar/sl1842-journal-error-messates.patch
The review has been swamped by a design discussion. It's not clear what Anish should do to pass review.
Do you have a link to the controversy?
I agree with Gary's proposal of using only NotifyAlert for the time being. Anish, what do you think?
sugar-toolkit/sl1948-Race-condition-with-name-widget-in-the-activ.patch
This patch has a corner case in which it fails to update the activity name, but I think it's still a little better than the current behavior. See ticket for details.
I guess you and Simon need to agree on which bad is better.
It's hard to dedice which one is less incorrect. I tried to come up with a "perfect" fix by checking for a title change one more time from the Stop button, which sounds like a straightforward approach.
However, I quickly got to a difficulty that I couldn't solve without breaking encapsulation or subverting the design: the Stop button and the TitleEntry widgets don't know about each other, but StopButton would have to peek into TitleEntry to find what the current title is.
Because many activities build the activity toolbar manually, one widget at a time, there's no way to ensure that the StopButton instance will have a reference to TitleEntry instance. Perhaps Gtk offers an easy way to find other widgets by name in the widget tree of a window, but it smells like a horrible kludge.
Eventually, I gave up on this approach because it seemed overly complicated for fixing this bug.
You know Gtk much better than me: is it possible that there's no sure way to get notified when the user has finished editing a gtk.Entry? The "editing-done" signal implemented by the GtkCellEditable sounds perfect, but it only fires when the user presses enter in the widget so it's useless for us.
sugar/add-font-dpi-schema.patch
This is a companion patch of a fix sugar-settings-manager which has already landed in git. It's needed by xulrunner (Browse).
Would be good if the commit message said why is that needed, or at least have a link to the ticket.
sugar/avoid-popping-an-empty-list-in-the-software-updater.patch
Works, but James Cameron's posted a better counter-patch. Merge that one.
sugar/click-on-journal-icons-with-a-exclusive-time-frame.patch
Requested by the Waveplace folks. Please merge.
What happened to the check for activity_id? We have it in other places in the UI with the similar issue.
You mean in the Activity() class of jarabe? It seems that activity_id gets initialized after the activity brings up its window, which leaves several seconds of time for a user to open two instances with a double-click.
(I'm not very familiar with this code, excuse me if I'm misunderstanding the context)
sugar/use-the-spanish-verb-quitar-for-unmounting-devices.patch
Better-than-nothing patch, but the real fix would require a gettext kludge in the code (see http://bugs.python.org/issue2504 )
Shouldn't we make the change in Pootle? Or it will be synced automatically?
Good question, I don't know if Pootle syncs bidirectionally. I would expect it to, but better ask Sayamindu.
Or maybe we should go with the kludge as the real fix is most likely to not land in 2.x.
Indeed. (though the bug has been moving forward a little)
sugar/backup-0001-Volumes-Backup-and-Restore.patch sugar/backup-0002-Journal-XS-backup-and-restore.patch
There are concerns about restore deleting new entries since the last backup. I agree, but since nobody seems to have the time to implement and test a more sophisticated procedure, at this time this is the best restore feature we have for Sugar.
Do we know any other deployment willing to deploy this?
The original code was contributed by Uruguay, so I guess they would like to use it.
sugar/use-the-spanish-verb-quitar-for-unmounting-devices.patch
Better-than-nothing patch, but the real fix would require a gettext kludge in the code (see http://bugs.python.org/issue2504 )
If we decide to merge it, I think it should be disabled by default and have a gconf setting, because knowingly shipping a feature that causes data loss may not be a good idea.
Sounds like a good compromise. The backup/restore strategies are decoupled from the dialogs. Having the infrastructure in git might motivate others to come up with improved approaches.
(though I suspect that any non-destructive approaches will likely be complicated or break in several common scenarios)
sugar-toolkit/kill-the-delayed-menus-for-good.patch
This change has been at the center of a huge design / UX / testing flame war a while ago. I've merged it to observe user reactions, so hopefully we can have a polite discussion based on some real data.
I would go with whatever deployers decide.
I received no comments so far. I'll ask my testers to give an opinion whether they like it more this way after a few days of adjustment.
They also did not say anything about the hot-borders for the frame being disabled by default.
sugar-datastore/0001-Add-ctime-and-timestamp-properties-to-the-index.patch sugar-datastore/0002-Add-migration-from-DS-v0-code-for-the-new-properties.patch sugar-datastore/0003-increment-CURRENT_LAYOUT_VERSION-to-trigger-an-index-rebuild.patch sugar/sizelist-0000-cover-letter.patch sugar/sizelist-0001-Journal-Retrieve-filesize-from-the-datastore.patch sugar/sizelist-0002-Add-a-filesize-column-to-the-journal-list-model.patch sugar/sizelist-0003-Journaltoolbox-Add-add_separator-method-for-convenie.patch sugar/sizelist-0004-Add-a-ListViewButton-to-the-journal-search-toolbar.patch sugar/sizelist-0005-Rename-the-date-column-to-sort_column.patch sugar/sizelist-0006-Display-the-sorting-property-in-the-last-column.patch sugar/sizelist-0007-Expandedentry-Try-to-use-the-filesize-property.patch sugar/sizelist-0008-Implement-sorting-for-removable-devices.patch sugar/sizelist-0009-Add-sort-by-creation-time-option-to-the-ListViewButt.patch sugar/sizelist-0010-Add-ctime-property-to-the-journal-model.patch
Andres' series for sorting the journal by size. There's an outstanding problem with ctime being an integer rather than a string, as expected by Etoys. Andres is working on a fix.
Is Aleksey ok with merging this?
If I interpreted correctly, he was reluctant to put more work into the current Journal UI because it must be rewritten from scratch to solve some fundamental performance and extensibility issues.
However, it doesn't seem like this will happen in time for 0.90... so perhaps it won't hurt?
NOTE: the current implementation conflicts with etoys' usage of ctime and fails to upgrade the index format from version 4 (what 0.88 uses). Andres is working on fixing both these issues.
sugar-toolkit/kill-the-delayed-menus-for-good.patch
I received no comments so far. I'll ask my testers to give an opinion whether they like it more this way after a few days of adjustment.
Sounds like something I would have an interest in. What does this do ?
Thanks, mikus
El Fri, 02-07-2010 a las 04:49 -0500, Mikus Grinbergs escribió:
sugar-toolkit/kill-the-delayed-menus-for-good.patch
I received no comments so far. I'll ask my testers to give an opinion whether they like it more this way after a few days of adjustment.
Sounds like something I would have an interest in. What does this do ?
It makes menus pop-up immediately instead of after a 2 seconds delay.
Ideally, we'd want users to click the right button explicitly, but even if we increase the delay, most users sit and wait patiently for the menu to open automatically. It seems to be a perverse form of laziness :-)
In F11-0.88 I have also disabled the hot-corners for the frame. I don't like it, but Tim Falconer asked me to do it at Realness and there was a chorus of approval. They're probably still using the G1G1 crap software with the jumpy touchpad (I fixed it over 2 years ago :-)
At some point, I will ask the children and their teachers to comment on these changes. So far nobody said anything: whether they like it or not, it's probably not a very big deal for them.
-
Bernie Innocenti -
Mikus Grinbergs -
Tomeu Vizoso