----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/136/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description -------
Add LMI_MountPoint.
Diffs -----
mof/LMI_Storage.reg 36b149a8f52aef299ee4efff35217c72218a0ae2 src/openlmi/storage/LMI_MountPoint.py PRE-CREATION src/openlmi/storage/cimom_entry.py d5d2e5274aff95395b5bdbc709af3f3337ae11e1
Diff: http://reviewboard-openlmi.rhcloud.com/r/136/diff/
Testing -------
Thanks,
Jan Synacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/136/#review138 -----------------------------------------------------------
src/openlmi/storage/LMI_MountPoint.py http://reviewboard-openlmi.rhcloud.com/r/136/#comment93
There is no FileSystemType property in LMI_MountPoint.
src/openlmi/storage/LMI_MountPoint.py http://reviewboard-openlmi.rhcloud.com/r/136/#comment94
This can be retrieved using provider = self.provider_manager.get_provider_for_format(device, fmt) # throw error if provider is None format_name = provider.get_name_for_format(device, fmt)
Question is how to get fmt and device - device is Blivet StorageDevice and fmt is device.format.
src/openlmi/storage/LMI_MountPoint.py http://reviewboard-openlmi.rhcloud.com/r/136/#comment95
These lines should be removed, we use cimom_entry.py as the entry point from CIMOM
- Jan Safranek
On April 8, 2013, 3:23 p.m., Jan Synacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/136/
(Updated April 8, 2013, 3:23 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
Add LMI_MountPoint.
Diffs
mof/LMI_Storage.reg 36b149a8f52aef299ee4efff35217c72218a0ae2 src/openlmi/storage/LMI_MountPoint.py PRE-CREATION src/openlmi/storage/cimom_entry.py d5d2e5274aff95395b5bdbc709af3f3337ae11e1
Diff: http://reviewboard-openlmi.rhcloud.com/r/136/diff/
Testing
Thanks,
Jan Synacek
On April 9, 2013, 5:13 p.m., Jan Safranek wrote:
src/openlmi/storage/LMI_MountPoint.py, line 64 http://reviewboard-openlmi.rhcloud.com/r/136/diff/1/?file=739#file739line64
There is no FileSystemType property in LMI_MountPoint.
Hmm, I have no idea how it got there..
- Jan
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/136/#review138 -----------------------------------------------------------
On April 8, 2013, 3:23 p.m., Jan Synacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/136/
(Updated April 8, 2013, 3:23 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
Add LMI_MountPoint.
Diffs
mof/LMI_Storage.reg 36b149a8f52aef299ee4efff35217c72218a0ae2 src/openlmi/storage/LMI_MountPoint.py PRE-CREATION src/openlmi/storage/cimom_entry.py d5d2e5274aff95395b5bdbc709af3f3337ae11e1
Diff: http://reviewboard-openlmi.rhcloud.com/r/136/diff/
Testing
Thanks,
Jan Synacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/136/ -----------------------------------------------------------
(Updated April 17, 2013, 10:06 a.m.)
Status ------
This change has been discarded.
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description -------
Add LMI_MountPoint.
Diffs -----
mof/LMI_Storage.reg 36b149a8f52aef299ee4efff35217c72218a0ae2 src/openlmi/storage/LMI_MountPoint.py PRE-CREATION src/openlmi/storage/cimom_entry.py d5d2e5274aff95395b5bdbc709af3f3337ae11e1
Diff: http://reviewboard-openlmi.rhcloud.com/r/136/diff/
Testing -------
Thanks,
Jan Synacek
openlmi-devel@lists.fedorahosted.org