----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/275/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description -------
Fix more issues found by coverity
Mostly missing unlocks, one wrong umask for tempfile.
Diffs -----
src/LMI_IPConfigurationServiceProvider.c 072623b0d8982c8e8e1ab245b362f037e9671021 src/LMI_LANEndpointProvider.c 8a0f7691e4f0fb4d970515e0ca63027dbf420727 src/LMI_LinkAggregationConcreteIdentityProvider.c 4f095aee1e4e19b474c16c48e11f90a9951c7d4d src/LMI_OrderedIPAssignmentComponentProvider.c 7b38744823ac0993022e803fc389001064d80dcd src/unittest/test_network.c f1e8fe9692428679e1a79373575a098239456230
Diff: http://reviewboard-openlmi.rhcloud.com/r/275/diff/
Testing -------
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/275/#review329 -----------------------------------------------------------
Ship it!
Ship It!
- Jan Synacek
On April 26, 2013, 3:39 p.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/275/
(Updated April 26, 2013, 3:39 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
Fix more issues found by coverity
Mostly missing unlocks, one wrong umask for tempfile.
Diffs
src/LMI_IPConfigurationServiceProvider.c 072623b0d8982c8e8e1ab245b362f037e9671021 src/LMI_LANEndpointProvider.c 8a0f7691e4f0fb4d970515e0ca63027dbf420727 src/LMI_LinkAggregationConcreteIdentityProvider.c 4f095aee1e4e19b474c16c48e11f90a9951c7d4d src/LMI_OrderedIPAssignmentComponentProvider.c 7b38744823ac0993022e803fc389001064d80dcd src/unittest/test_network.c f1e8fe9692428679e1a79373575a098239456230
Diff: http://reviewboard-openlmi.rhcloud.com/r/275/diff/
Testing
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/275/ -----------------------------------------------------------
(Updated April 29, 2013, 9:57 a.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description -------
Fix more issues found by coverity
Mostly missing unlocks, one wrong umask for tempfile.
Diffs -----
src/LMI_IPConfigurationServiceProvider.c 072623b0d8982c8e8e1ab245b362f037e9671021 src/LMI_LANEndpointProvider.c 8a0f7691e4f0fb4d970515e0ca63027dbf420727 src/LMI_LinkAggregationConcreteIdentityProvider.c 4f095aee1e4e19b474c16c48e11f90a9951c7d4d src/LMI_OrderedIPAssignmentComponentProvider.c 7b38744823ac0993022e803fc389001064d80dcd src/unittest/test_network.c f1e8fe9692428679e1a79373575a098239456230
Diff: http://reviewboard-openlmi.rhcloud.com/r/275/diff/
Testing -------
Thanks,
Radek Novacek
openlmi-devel@lists.fedorahosted.org
-
Stephen Gallagher