Add LANGUAGE property to LMI_Locale

[Alexander Lakhin]

Hello,

It seems that LMI_Locale misses one important property - LANGUAGE.
The property can have value distinct from LC_* and LANG and it is 
supported by systemd-localed/localectl.
Is it possible to add it to the LMI_Locale provider?
I would like to propose the attached patch for it or should I file the bug?

Best regards,
Alexander

[Vitezslav Crhonek]

On 10/15/2014 03:05 PM, Александр Лахин wrote:
> Hello,
>
> It seems that LMI_Locale misses one important property - LANGUAGE.
> The property can have value distinct from LC_* and LANG and it is
> supported by systemd-localed/localectl.
> Is it possible to add it to the LMI_Locale provider?
> I would like to propose the attached patch for it or should I file the bug?
>
> Best regards,
> Alexander

Hello Alexander,

you're right, LANGUAGE variable is missing.

There's no need to file a bug. Your patch looks fine at first glance,
I'll test it a bit and then add to the provider.

Thank you for your contribution!

Best regards,
Vitezslav Crhonek

Small fixes for get_computer_system function

[Alexander Lakhin]

Hi,
Please look at the following patch.
It seems that there is a memory leak in the function and the error 
message is incorrect.

Best regards,
Alexander

Patch to set a label for a new fs

[Alexander Lakhin]

Hi,

I would like to propose a patch for 
LMI_FileSystemConfigurationService.LMI_CreateFileSystem.
This method takes ElementName as a label for a new fs, but uses it only 
when creating btrfs.
With the proposed change a label can be set for other FSes too.

Best regards,
Alexander

Patch to set a label for a new fs

[Jan Safranek]

On 11/05/2014 08:50 AM, Alexander Lakhin wrote:
> Hi,
>
> I would like to propose a patch for
> LMI_FileSystemConfigurationService.LMI_CreateFileSystem.
> This method takes ElementName as a label for a new fs, but uses it only
> when creating btrfs.
> With the proposed change a label can be set for other FSes too.

Thanks for the patch! I pushed it to our git and it will be part of the
next openlmi-storage release.

Jan

Patch to add support for reiserfs and swap

[Alexander Lakhin]

Hello,

Please consider commiting the following patch to add support for 
reiserfs and swap.

Best regards,
Alexander

Patch to add support for reiserfs and swap

[Jan Safranek]

On 12/24/2014 05:47 AM, Alexander Lakhin wrote:
> Hello,
>
> Please consider commiting the following patch to add support for
> reiserfs and swap.

I'm fine with raiserfs. On the other hand, swap is not a filesystem. It
does not provide files and it should be handled differently, preferably
with its own SwapConfigurationService, which would be able for create it
on a device, and later with methods to swapon/swapoff and modify /etc/fstab.

It's tracked as https://fedorahosted.org/openlmi/ticket/66.

Jan

openlmi-storage: Add support for biosboot partitions

[Alexander Lakhin]

Hello,

Please consider commiting attached patch to support biosboot partition 
creation.
(openlmi-storage correctly reports type of such existing partition 
through LMI_DataFormat but can't create a new one.)

Best regards,
Alexander

openlmi-storage: Add support for biosboot partitions

[Jan Safranek]

On 03/13/2015 12:21 PM, Alexander Lakhin wrote:
> Hello,
>
> Please consider commiting attached patch to support biosboot partition
> creation.
> (openlmi-storage correctly reports type of such existing partition
> through LMI_DataFormat but can't create a new one.)

Thanks for the patch! I pushed it to our git and it will be part of the
next release.

Jan

openlmi-storage: Add support for FS labeling

[Alexander Lakhin]

Hello,

Please consider adding 
LMI_FileSystemConfigurationService.ModifyFileSystem (proposed 
implementation is attached) to support changing a filesystem label.

Best regards,
Alexander

openlmi-storage: Add support for FS labeling

[Jan Safranek]

On 06/19/2015 10:00 AM, Alexander Lakhin wrote:
> Hello,
>
> Please consider adding
> LMI_FileSystemConfigurationService.ModifyFileSystem (proposed
> implementation is attached) to support changing a filesystem label.

Thanks for the patch! I pushed it to current git master and it will be
part of any next OpenLMI release.

Jan.

openlmi-storage: Add 'Removable' property to LMI_StorageExtent

[Alexander Lakhin]

Hello,

It seems that for now, there is no way to know whether the block device 
(represented by LMI_StorageExtent) is removable (though I can get it's 
bus type).
If it can be useful, please consider accepting the proposed patch.

Thanks,
Alexander

Small fixes for get_computer_system function

[Jan Safranek]

On 10/24/2014 02:17 PM, Alexander Lakhin wrote:
> Hi,
> Please look at the following patch.
> It seems that there is a memory leak in the function and the error
> message is incorrect.

Thanks for the patch, I pushed it to our git.

And sorry for late reply - please use our reviewboard instance at
https://reviewboard-openlmi.rhcloud.com to make sure such patches do not
get lost.

Jan