This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/56/ |
On March 26th, 2013, 8:50 a.m. UTC, Roman Rakus wrote:
src/hardware/LMI_ProcessorCapabilitiesProvider.c (Diff revision 1) 42 *instace_id_string = "LMI:ProcessorCapabilities:",43 *element_name_string = "Capabilities of processor ";Isn't better to move these constants to some header file as macros?
And split it to parts. ORGID, CLASSNAME or so. And ORGID will be global for all providers.
- Roman
On March 25th, 2013, 4:24 p.m. UTC, Peter Schiffer wrote:
Review request for OpenLMI Developers.
By Peter Schiffer.
Updated March 25, 2013, 4:24 p.m.
Repository:
openlmi-providers
Description
Diffs
|