----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/130/#review135 -----------------------------------------------------------
src/openlmi/storage/LMI_HostedMount.py http://reviewboard-openlmi.rhcloud.com/r/130/#comment83
These lines should be removed, we use cimom_entry.py as the entry point from CIMOM
src/openlmi/storage/MountingProvider.py http://reviewboard-openlmi.rhcloud.com/r/130/#comment86
I would appreciate more information why is this class useful.
src/openlmi/storage/MountingProvider.py http://reviewboard-openlmi.rhcloud.com/r/130/#comment84
device.parents is not related with filesystem on the device in any way, why is the check here?
src/openlmi/storage/MountingProvider.py http://reviewboard-openlmi.rhcloud.com/r/130/#comment85
If I read it correctly, this says that if a device is not mounted, it's still added to list of mounts. Is this correct? It sounds weird to me.
- Jan Safranek
On April 8, 2013, 3:22 p.m., Jan Synacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/130/
(Updated April 8, 2013, 3:22 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
Add LMI_MountedFileSystem and LMI_HostedMount.
Diffs
mof/LMI_Storage.reg 36b149a8f52aef299ee4efff35217c72218a0ae2 src/openlmi/storage/LMI_HostedMount.py PRE-CREATION src/openlmi/storage/LMI_MountedFileSystem.py PRE-CREATION src/openlmi/storage/MountingProvider.py PRE-CREATION src/openlmi/storage/cimom_entry.py d5d2e5274aff95395b5bdbc709af3f3337ae11e1
Diff: http://reviewboard-openlmi.rhcloud.com/r/130/diff/
Testing
Thanks,
Jan Synacek