This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/240/

Ship it!

Ship It!

- Jan


On April 18th, 2013, 11:46 p.m. CEST, Michal Minar wrote:

Review request for OpenLMI Developers.
By Michal Minar.

Updated April 18, 2013, 11:46 p.m.

Repository: openlmi-providers

Description

renamed mof files according to LMI convention

Mof files prefixed with digits ensuring their correct order of parsing
upon their installation. This avoids problems with sfcbmof compiler,
which can not handle dependent classes being parsed before their
antecedents.

Convention is specified in mof/README.

Removed inclusion of LMI_Qualifiers in LMI_Jobs. LMI_Qualifiers should
be registered in cimom instead of included in dependent mof files.
This allows it to be used by any other providers simultaneously.

Modified references to mof files in cmake build files.

Diffs

  • mof/LMI_SoftwareIndicationFilters.mof ()
  • mof/README (PRE-CREATION)
  • src/account/CMakeLists.txt (776ce871b4057b665362922c2072788a708f67d2)
  • src/hardware/CMakeLists.txt (c50acef4758c595acf95a4636454189d7da75997)
  • src/logicalfile/CMakeLists.txt (8b0097ac4830c6d875050eaf93e743fdc17b58c5)
  • src/fan/CMakeLists.txt (7cb801ae1e8fa71dec4190bcfe3d7b5db6a437e0)
  • mof/LMI_PowerManagement.mof ()
  • mof/LMI_Qualifiers.mof ()
  • mof/LMI_Service.mof ()
  • mof/LMI_Software.mof ()
  • mof/LMI_LogicalFile.mof ()
  • mof/LMI_Hardware.mof ()
  • mof/LMI_Jobs.mof (b17e8338fa96f3bea9b6f884670b9f2dc13b059f)
  • mof/LMI_Account.mof ()
  • mof/LMI_Fan.mof ()
  • src/power/CMakeLists.txt (73725d39d9f37fb40e0bb0750de9459923d6609f)
  • src/service/CMakeLists.txt (c0f236f7d8da1d8cdba78273ea73512ac9f3f76c)

View Diff