This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/56/

src/hardware/LMI_ProcessorCapabilitiesProvider.c (Diff revision 1)
72
            instance_id_len =
73
                    strlen(instace_id_string) + strlen(dmi_cpus[i].id) + 1;
74
            instance_id = (char *)malloc(instance_id_len * sizeof(char));
75
            if (!instance_id) {
76
                error_msg = "Not enough available memory.";
77
                goto done;
78
            }
79
            snprintf(instance_id, instance_id_len, "%s%s", instace_id_string,
80
                    dmi_cpus[i].id);
Use asprintf to alloc the memory easily (applies to whole patch).

- Jan


On March 25th, 2013, 5:24 p.m. CET, Peter Schiffer wrote:

Review request for OpenLMI Developers.
By Peter Schiffer.

Updated March 25, 2013, 5:24 p.m.

Repository: openlmi-providers

Description

Hardware: added new providers

Providers added:
 * LMI_ProcessorCapabilitiesProvider
 * LMI_ProcessorElementCapabilitiesProvider

Diffs

  • mof/LMI_Hardware.mof (4848ef1dbc40f5e01d496dcc893ac389d62aaa4f)
  • src/hardware/CMakeLists.txt (ebf79fb40869125ccb72dcd77a03038fa7066809)
  • src/hardware/LMI_ProcessorCapabilitiesProvider.c (PRE-CREATION)
  • src/hardware/LMI_ProcessorElementCapabilitiesProvider.c (PRE-CREATION)
  • src/hardware/LMI_ProcessorProvider.c (8e92fdd3ad0efc86287c19e93509559d3ed2cd49)
  • src/hardware/dmidecode.h (f7e76a929bf19c481278a59c81e20a64201f75a7)
  • src/hardware/dmidecode.c (6a038fbe6a8b9acefbc1facafa2ee6a2195a0788)
  • src/hardware/lscpu.h (892141e2ff423ebc004091c8982565880b51265c)
  • src/hardware/lscpu.c (124ed7b81121ed9f2aabac4a7c2d49f7c65282e0)
  • src/hardware/utils.h (9f5686faf4e50775b18adb62bfd0f5a707f093cb)
  • src/hardware/utils.c (da7bbfadffd77afd5ecc1c81360cb7f23f3412e1)

View Diff