This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/56/

src/hardware/LMI_ProcessorElementCapabilitiesProvider.c (Diff revision 1)
		124	&lmi_cpu_el_cap, 0, 3);

You should rather use enum value (LMI_ProcessorElementCapabilities_Characteristics_Current) instead of hardcoding number here

- Radek

On March 25th, 2013, 5:24 p.m. CET, Peter Schiffer wrote:

Review request for OpenLMI Developers.

By Peter Schiffer.

Updated March 25, 2013, 5:24 p.m.

Repository: openlmi-providers

Description

Hardware: added new providers

Providers added:
 * LMI_ProcessorCapabilitiesProvider
 * LMI_ProcessorElementCapabilitiesProvider

Diffs

mof/LMI_Hardware.mof (4848ef1dbc40f5e01d496dcc893ac389d62aaa4f)
src/hardware/CMakeLists.txt (ebf79fb40869125ccb72dcd77a03038fa7066809)
src/hardware/LMI_ProcessorCapabilitiesProvider.c (PRE-CREATION)
src/hardware/LMI_ProcessorElementCapabilitiesProvider.c (PRE-CREATION)
src/hardware/LMI_ProcessorProvider.c (8e92fdd3ad0efc86287c19e93509559d3ed2cd49)
src/hardware/dmidecode.h (f7e76a929bf19c481278a59c81e20a64201f75a7)
src/hardware/dmidecode.c (6a038fbe6a8b9acefbc1facafa2ee6a2195a0788)
src/hardware/lscpu.h (892141e2ff423ebc004091c8982565880b51265c)
src/hardware/lscpu.c (124ed7b81121ed9f2aabac4a7c2d49f7c65282e0)
src/hardware/utils.h (9f5686faf4e50775b18adb62bfd0f5a707f093cb)
src/hardware/utils.c (da7bbfadffd77afd5ecc1c81360cb7f23f3412e1)