This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/195/ |
src/hardware/LMI_MemoryProvider.c (Diff revision 1) | |||
---|---|---|---|
94 | LMI_Memory_Set_InstanceID(&lmi_mem, ORGID ":" MEM_CLASS_NAME ":0"); |
It should be LMI:LMI_Memory:0, not :Memory:
src/hardware/dmidecode.h (Diff revision 1) | |||
---|---|---|---|
79 | DmiMemoryModule *modules; /* Memory Modules */ |
||
80 | unsigned modules_nb; /* Number of Memory Modules */ |
These modules are only parsed, but they are never used. Is it something you're going to work on in the future?
src/hardware/dmidecode.c (Diff revision 1) | |||
---|---|---|---|
781 | /* ignore first useless lines */ |
||
782 | if (curr_mem < 0) { |
||
783 | continue; |
||
784 | } |
What's purpose of this check? 'continue' has no effect here, the loop ends after 'if' anyway.
- Jan
On April 15th, 2013, 7:02 p.m. CEST, Peter Schiffer wrote:
Review request for OpenLMI Developers.
By Peter Schiffer.
Updated April 15, 2013, 7:02 p.m.
Repository:
openlmi-providers
Description
Diffs
|