This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/56/

Ship it!

Ship It!

src/hardware/LMI_ProcessorElementCapabilitiesProvider.c (Diff revision 2)
		104	if (asprintf(&instance_id, "%s:%s:%s", ORGID,

This could be written more effectively, because ORGID and CPU_CAP_CLASS_NAME are constants:
asprintf(&instance_id, ORGID ":" CPU_CAP_CLASS_NAME ":%s", dmi_cpus[i].id)

But it's not really an issue

- Radek

On March 26th, 2013, 3:46 p.m. CET, Peter Schiffer wrote:

Review request for OpenLMI Developers.

By Peter Schiffer.

Updated March 26, 2013, 3:46 p.m.

Repository: openlmi-providers

Description

Hardware: added new providers

Providers added:
 * LMI_ProcessorCapabilitiesProvider
 * LMI_ProcessorElementCapabilitiesProvider

Diffs

mof/LMI_Hardware.mof (4848ef1dbc40f5e01d496dcc893ac389d62aaa4f)
src/globals.h (6cf272ca9fbf08cde48ae67ff72b4bf71a9d9f4f)
src/hardware/CMakeLists.txt (ebf79fb40869125ccb72dcd77a03038fa7066809)
src/hardware/LMI_Hardware.h (PRE-CREATION)
src/hardware/LMI_ProcessorCapabilitiesProvider.c (PRE-CREATION)
src/hardware/LMI_ProcessorElementCapabilitiesProvider.c (PRE-CREATION)
src/hardware/LMI_ProcessorProvider.c (8e92fdd3ad0efc86287c19e93509559d3ed2cd49)
src/hardware/dmidecode.h (f7e76a929bf19c481278a59c81e20a64201f75a7)
src/hardware/dmidecode.c (6a038fbe6a8b9acefbc1facafa2ee6a2195a0788)
src/hardware/lscpu.h (892141e2ff423ebc004091c8982565880b51265c)
src/hardware/lscpu.c (124ed7b81121ed9f2aabac4a7c2d49f7c65282e0)

View Diff