This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/130/

On April 9th, 2013, 4:47 p.m. CEST, Jan Safranek wrote:

src/openlmi/storage/MountingProvider.py (Diff revision 1)
41
            if not device.parents:
42
                continue
device.parents is not related with filesystem on the device in any way, why is the check here?
This was there to prevent the parent device from displaying. A modified the code slightly so it's not needed there anymore.

On April 9th, 2013, 4:47 p.m. CEST, Jan Safranek wrote:

src/openlmi/storage/MountingProvider.py (Diff revision 1)
44
            if not mountpaths:
45
                mountpaths.append(device.format.type)
If I read it correctly, this says that if a device is not mounted, it's still added to list of mounts. Is this correct? It sounds weird to me.
Yes. It's totally wrong, I'll remove it.

- Jan


On April 8th, 2013, 3:22 p.m. CEST, Jan Synacek wrote:

Review request for OpenLMI Developers.
By Jan Synacek.

Updated April 8, 2013, 3:22 p.m.

Repository: openlmi-storage

Description

Add LMI_MountedFileSystem and LMI_HostedMount.

Diffs

  • mof/LMI_Storage.reg (36b149a8f52aef299ee4efff35217c72218a0ae2)
  • src/openlmi/storage/LMI_HostedMount.py (PRE-CREATION)
  • src/openlmi/storage/LMI_MountedFileSystem.py (PRE-CREATION)
  • src/openlmi/storage/MountingProvider.py (PRE-CREATION)
  • src/openlmi/storage/cimom_entry.py (d5d2e5274aff95395b5bdbc709af3f3337ae11e1)

View Diff