This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/100/

Review request for OpenLMI Developers.
By Stephen Gallagher.
Repository: openlmi-tools

Description 

The openlmi-tools are built entirely in Python. It seems wasteful to use the heavyweight autotools build system for it. This patch and the one in review https://reviewboard-openlmi.rhcloud.com/r/99/ will replace the autotools build system with one based on Python's setuptools.

Apologies for the ugly in-browser diff. Apparently, ReviewBoard does not handle file moves very gracefully yet. I've attached a different version of the diff as well, which only shows that a move happens and then the differences made. It's easier to spot that way.

Testing 

Ran 'python setup.py install --root `pwd`/chroot' and verified that all files are installed where expected on the target system.

Diffs

  • cli-tools/lmi/__init__.py (e69de29bb2d1d6434b8b29ae775ad8c2e48c5391)
  • cli-tools/lmi/lmi_address.py (140dd269fef10350500c1e3fb0579ef2a46d4063)
  • cli-tools/lmi/lmi_client_base.py (a69cdfef704e34f8761eecbaa52497920935a6bb)
  • cli-tools/lmi/lmi_client_ip.py (c5bbaf79a086f674cc477cebcc1103468b91413b)
  • cli-tools/lmi/lmi_client_power.py (6f625cb011cfa67f8da8979422498d243f806107)
  • cli-tools/lmi/lmi_client_service.py (d112a87abc54c6ca218af6dfa25556cb6ef05316)
  • cli-tools/lmi/lmi_client_shell.py (fb3a29e1be1411fc2917391768c58a6865508c6b)
  • cli-tools/lmi/lmi_client_user.py (aca205b91f1cfe032c2d6d7e899d908799261227)
  • cli-tools/lmi/lmi_listener.py (6670b204a84485b6e1f8bef5dfa2893098f0a9da)
  • cli-tools/lmi/lmi_options.py (9fe18761e0b25d99c39cd3a40399bbaa243fee96)
  • cli-tools/lmiip (200f0df48c3db46618a5b604c0a3fbc08f5f6490)
  • cli-tools/lmipower (1cf95a5af099b4b0e6fb461383c80be1041e9a8e)
  • cli-tools/lmiservice (9d4020eb4d51e3a94ba29d2dcd128c1c1cbeb957)
  • cli-tools/lmishell (89844d862922a3288a461e34838e3194ccf4a97b)
  • cli-tools/lmiuser (2ecff093adb46c9bbebf776fd846524c7a0185e6)
  • lmi/lmi_address.py (PRE-CREATION)
  • lmi/lmi_client_base.py (PRE-CREATION)
  • lmi/lmi_client_ip.py (PRE-CREATION)
  • lmi/lmi_client_power.py (PRE-CREATION)
  • lmi/lmi_client_service.py (PRE-CREATION)
  • lmi/lmi_client_shell.py (PRE-CREATION)
  • lmi/lmi_client_user.py (PRE-CREATION)
  • lmi/lmi_ip.py (PRE-CREATION)
  • lmi/lmi_listener.py (PRE-CREATION)
  • lmi/lmi_options.py (PRE-CREATION)
  • lmi/lmi_power.py (PRE-CREATION)
  • lmi/lmi_service.py (PRE-CREATION)
  • lmi/lmi_shell.py (PRE-CREATION)
  • lmi/lmi_user.py (PRE-CREATION)
  • setup.py (PRE-CREATION)

View Diff

File Attachments