This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/56/ |
On March 26th, 2013, 9:50 a.m. CET, Roman Rakus wrote:
src/hardware/LMI_ProcessorCapabilitiesProvider.c (Diff revision 1) 42 *instace_id_string = "LMI:ProcessorCapabilities:",43 *element_name_string = "Capabilities of processor ";Isn't better to move these constants to some header file as macros?On March 26th, 2013, 10:08 a.m. CET, Roman Rakus wrote:
And split it to parts. ORGID, CLASSNAME or so. And ORGID will be global for all providers.
I've added ORGID to the globals.h and CPU_CAP_CLASS_NAME to LMI_Hardware.h. element_name_string is used only in that one place, so I've made it const char * and kept it there.
- Peter
On March 26th, 2013, 3:46 p.m. CET, Peter Schiffer wrote:
Review request for OpenLMI Developers.
By Peter Schiffer.
Updated March 26, 2013, 3:46 p.m.
Repository:
openlmi-providers
Description
Diffs
|