Re: Review Request (realmd)
Hi John,
Radek Novacek and I have reviewed the realmd-cim code and we would like to
merge it into the OpenLMI sources -- there is nothing that we would consider
to be a blocker. The openlmi-providers tree would suit realmd-cim the best I
think.
Radek might add his notes if he feels like I've forgotten something
important but the review was quite easy -- we don't know realmd too well and
formally the code looks
On Fri, 12 Apr 2013 08:51:27 -0400
John Dennis <jdennis(a)redhat.com> wrote:
I would like the team to review the realmd provider I wrote. I tried
to
use ReviewBoard to post the review request but I ran into number of
problems since the code is not yet in one of the repos known to the
ReivewBorad instance. Also a diff in the context of new code doesn't
make much sense, there is nothing to diff against and with such a large
body of code diff format would be difficult to read. Instead I'm going
to suggest cloning the below git repo to review the code.
git://fedorapeople.org/~jdennis/realmd-cim.git
In other projects we review prior to import anyway.
Some notes:
* We recognize this is not the best example of CIM modeling, To fully
integrate into the existing CIM schema requires the existence of other
providers which do not exist (i.e. credentials, KDC, etc.). We had a
meeting about this a couple of weeks ago and decided at this juncture it
was best to just expose what realmd provides and not attempt full model
integration. We expect scriptons to hide much of this anyway.
The model doesn't look much like the DMTF standards however if it's
functional (which I assume so) and convenient enough to use there is no reason
no to accept it.
We will let you know when we're finished with the code merge.
Thanks a lot and regards,
--
Tomáš Smetana
Platform Engineering, Red Hat