This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/873/

Review request for OpenLMI Developers.
By Jan Synacek.
Repository: openlmi-providers

Description

logicalfile: code cleanup and rewrite

GetInstance() calls were rewritten using cleaner code. Also, the macros
that were used before were either rewritten to functions, or cleaned up
so they wouldn't return or do anything unexpected.

Helper functions now use CMPIStatus more consistently.

Some memory leaks were fixed.

Testing

All upstream tests finish successfully. Additional testing done using the openlmi scripts.

Diffs

  • src/logicalfile/LMI_DataFileProvider.c (ea410c3e40aaf6a728e489250c681d85ecf7713f)
  • src/logicalfile/LMI_DirectoryContainsFileProvider.c (427c2a635dc76fe6dddebc71a3e4d28f3e11c2cd)
  • src/logicalfile/LMI_FIFOPipeFileProvider.c (8730299be3f380bc17942c7109c86dcc6e25f7dd)
  • src/logicalfile/LMI_FileIdentityProvider.c (7720a751447f17cf103e82e2507a893d09a448af)
  • src/logicalfile/LMI_RootDirectoryProvider.c (0c3b23ea14d02c0e26644d9069cc846dc66eebf7)
  • src/logicalfile/LMI_SymbolicLinkProvider.c (c93c087a8ad1c804d2f2e5381a35a6e6ec7c9567)
  • src/logicalfile/LMI_UnixDeviceFileProvider.c (4d09efa6b134693cbbd97cb4f636dfccfa7d115d)
  • src/logicalfile/LMI_UnixDirectoryProvider.c (bdd12454f9dba30294f9f79b1c5db95499b4732e)
  • src/logicalfile/LMI_UnixFileProvider.c (6b3a45e85b3baff87f7cc95d74fe76d42be3ab40)
  • src/logicalfile/LMI_UnixSocketProvider.c (56fb6bdba2dbca08486ca93a566ab3e390031185)
  • src/logicalfile/file.h (938673c0174edb8948b165914472e7bdf3cffcdf)
  • src/logicalfile/file.c (e768ea0b67a264d124f3f93fbcb9a43b687b86d2)

View Diff