This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/279/

src/LMI_DNSSettingDataProvider.c (Diff revision 1)
static CMPIStatus LMI_DNSSettingDataModifyInstance(
		159	KReturn2(_cb, ERR_FAILED, "Invalid ObjectPath for of class LMI_DNSSettingData");

Looks like copy&paste error. The message should say something different. Or at least there are "for of", so maybe remove " of".

src/LMI_IPNetworkConnectionCapabilitiesProvider.c (Diff revision 1)
KUint16 LMI_IPNetworkConnectionCapabilities_LMI_CreateIPSetting(
299	// TODO: add the bridge support	340	// TODO: add the bridge support

Is there ERR_NOT_SUPPORTED (or not implemented) return if it is TODO list?

src/connection_nm.c (Diff revision 1)
ConnectionType connection_type_from_string(const char *s)
74	void connection_get_properties(Connection *connection);	74	LMIResult connection_get_properties(Connection* connection);

Looks like unintended change - moving *.

src/connection_nm.c (Diff revision 1)
ConnectionType connection_type_from_string(const char *s)
	82	if (connection == NULL) {
	83	*res = LMI_ERROR_MEMORY;
	84	return NULL;
	85	}

Why no error("Memory allocation") here?

src/globals.c (Diff revision 1)
static const CMPIBroker *_cb = NULL;
43	char *getFQDN(void)	43	char *getFQDN(void)

Now I see that the caller have to free() allocated memory. It would be good to add a comment for it here.

- Roman

On April 29th, 2013, 7:14 a.m. UTC, Radek Novacek wrote:

Review request for OpenLMI Developers.

By Radek Novacek.

Updated April 29, 2013, 7:14 a.m.

Repository: openlmi-networking

Description

Add lots of error checking

Now most of the errors should be handled properly. The error codes still
needs to be converted to error messages and presented to users.

Diffs

src/LMI_BindsToLANEndpointProvider.c (39b4186ab3702a797b9b9c153179f5a02351fd96)
src/LMI_DNSProtocolEndpointProvider.c (017eb11aa3444cd7c2a96188a53a8f006d2a3e8d)
src/LMI_DNSSettingDataProvider.c (a3d74623b4c801b9241a3efcf2c70f6f2c20c660)
src/LMI_EthernetPortStatisticsProvider.c (ffae836683d4a442d4be8b851a3b36453ac65f37)
src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c (e4d9a14e63343ada59ac3db82c36f31cf03f3b3a)
src/LMI_IPConfigurationServiceAffectsElementProvider.c (874ab1dd6896267d7cadc4955224ed174ea72426)
src/LMI_IPNetworkConnectionCapabilitiesProvider.c (4dab5c55b87879ccde2a0a59806f1efa22e14c8d)
src/activeconnection.c (648c23fa2fdf616950758b6d1e58e78e3f6b20e4)
src/activeconnection_nm.h (c60d5da01cbe0254adb5272ff89b61d2c7737ef0)
src/activeconnection_nm.c (caef0042839b520f430f5676e88d52392962e93e)
src/connection.h (7e6d6206bae139a0d4d066f400ae78b0c70ab12d)
src/connection.c (969232810f0342d15f8e75c64bf841b6a42b065f)
src/connection_nm.h (8a43bd068717a4961ba986705c277fecf518aec3)
src/connection_nm.c (a5fba58e1eab8f5dc5ba3793ad247da8dbf404e0)
src/connection_private.h (821e9fd765ab24e9262665540d03a28c91d6c2ab)
src/dbus_wrapper.c (a2d1e98a7cba16036d02a39bf314511b90d4f816)
src/errors.h (bbeec9b4fc7959f23209a6807527a2f86dbc00c8)
src/globals.h (e06b5f4fd595c277370e5ef98ac37dfd69023550)
src/globals.c (f7ce75d47d139910e13b0eec51ec537b1bca37f4)
src/ipassignmentsettingdata.c (78489a83d262b4e78546c654e16c7a9a2401172f)
src/ipconfig.c (575a37ce0f17aa1928d3bcd686bdccaaafbfa5a2)
src/network.h (9a70c28ffec537e9fdb441ea96d27e32f0da5ea3)
src/network.c (8b64c0f06704d5a5644215f6a9af125c8ca0c598)
src/network_nm.c (24455f3b0d0002424449bde12c854d19ad6591fe)
src/network_private.h (27fe247e6bfc6a0381d93f23c8e0953571461cbc)
src/nm_support.h (7f8b6cabb504ee88a6e5af16eade7e4aeddb004f)
src/nm_support.c (272bd3ebef44b5b0a2b40ee0cba31b42cc7e9f94)
src/port.h (a249c8b34ce629f7539d562926928f7a44031fc9)
src/port.c (4b5cd96b94b4448acb3f0498b17d74b5133f3d39)
src/port_nm.c (d3d123788d673dc40491e58a23001e8d16370ff9)
src/setting.h (80e8591f98c8378aff2ea4389f69a8f67df2578b)
src/setting.c (91e311779829b23c927660add0bc68e479e655a4)
src/setting_nm.h (6f626b83a2c2b70ba0a4ce9ff233be54fc7ebe28)
src/setting_nm.c (c005917c0d4bb72d715a32eabfb132a06c8983bc)
src/unittest/mock_nm.c (7509b493418bbacd5294a1a16a0da19147a7087e)
src/unittest/test.h (0db0dc94895a91b640c991f39ba745a13720e5fc)
src/unittest/test_connection.c (5d4c9bdb4590e8181aa8d70f96f24162be0bd8c4)
src/unittest/test_network.c (f1e8fe9692428679e1a79373575a098239456230)
src/unittest/test_setting.c (a03b51b45df266372212ab6d925434b2daec6bcc)

View Diff