This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/95/ |
src/openlmi/storage/LMI_DiskPartitioningConfigurationService.py (Diff revision 1) | |||
---|---|---|---|
def cim_method_setpartitionstyle(self, env, object_name, |
|||
81 | if self.storage.deviceDeps(device): |
81 | # Check the device is unused |
I think it would be much more readable to have comment like "Raise CIMError if device is used". Now it's not clear what will happen without looking at check_unused implementation.
- Radek
On April 4th, 2013, 6:33 p.m. CEST, Jan Safranek wrote:
Review request for OpenLMI Developers.
By Jan Safranek.
Updated April 4, 2013, 6:33 p.m.
Repository:
openlmi-storage
Description
Diffs
|