This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/195/

On April 17th, 2013, 10:52 a.m. CEST, Jan Safranek wrote:
src/hardware/LMI_MemoryProvider.c (Diff revision 1)
94
    LMI_Memory_Set_InstanceID(&lmi_mem, ORGID ":" MEM_CLASS_NAME ":0");
It should be LMI:LMI_Memory:0, not :Memory:
On April 17th, 2013, 11:04 a.m. CEST, Peter Schiffer wrote:
Ugh, I'm using this format in all LMI classes in Hardware.. I kind of chose it by myself. Is there and guideline for that?

src/hardware/LMI_MemoryProvider.c (Diff revision 1)
		94	LMI_Memory_Set_InstanceID(&lmi_mem, ORGID ":" MEM_CLASS_NAME ":0");

I'll rewrite InstanceID in Hardware to complain with the rest of providers in the next patch.

- Peter

On April 15th, 2013, 7:02 p.m. CEST, Peter Schiffer wrote:

Review request for OpenLMI Developers.

By Peter Schiffer.

Updated April 15, 2013, 7:02 p.m.

Repository: openlmi-providers

Description

Hardware: Added System Memory Provider

Added new provider:
 * LMI_MemoryProvider

Diffs

mof/LMI_Hardware.mof (0964291c81b029d17d4945f9faead08e11005ff7)
src/hardware/CMakeLists.txt (3949a8ad704581f5d0e9a88ac5fa369511a041ee)
src/hardware/LMI_Hardware.h (1f30be648ec59f02a4d4ad67aea4a9c6a958d216)
src/hardware/LMI_MemoryProvider.c (PRE-CREATION)
src/hardware/LMI_ProcessorCacheMemoryProvider.c (afc5d7f0488c506dddabd438f7af56578f464856)
src/hardware/LMI_ProcessorProvider.c (99b0fad7d1e36efbb1e823d20cda74bf9b577235)
src/hardware/cpuinfo.h (5ec5dd5083fe73548a434a3312c0a371c0c0d961)
src/hardware/cpuinfo.c (6634b059df7d858654c862e88a705bbc574edef0)
src/hardware/dmidecode.h (9190ea4ac26e82889b24184fc40072f007f9c836)
src/hardware/dmidecode.c (348c7a23b76f42ab5dae78a86e42c69789a4e021)
src/hardware/procfs.h (PRE-CREATION)
src/hardware/procfs.c (PRE-CREATION)

View Diff