-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/859/#review1177
-----------------------------------------------------------
Ship it!
Ship It!
- Michal Minar
On Sept. 13, 2013, 11:31 a.m., Jan Synacek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/859/
-----------------------------------------------------------
(Updated Sept. 13, 2013, 11:31 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
logicalfile: ignore some key properties
CIM_LogicalFile and CIM_UnixFile have some key properties that are not
needed when calling GetInstance(). On Linux systems, all is needed to
get information about a file is its path. Type of the filesystem that
the file resides on and the file type itself are not needed. In fact,
it's not desirable to require those when querying remote systems.
Ignore FSCreationClassName, FSName, LFCreationClassName and
CreationClassName.
This commit reverts most of the functionality of commit
5c3e1a6203e495bec37acd8c3731ca41377beb94.
Diffs
-----
src/logicalfile/LMI_DirectoryContainsFileProvider.c
753cb00d184a71bbaa3a3d63883110480750d8d9
src/logicalfile/LMI_FileIdentityProvider.c 7ada7873c0b90f88bcbf5b3ba1a44aa704c713e4
src/logicalfile/LMI_RootDirectoryProvider.c 2be709f0d0a0ca50271508dffe67bbfc357cc710
src/logicalfile/LMI_UnixFileProvider.c 5da5bb0a471228653fabc30c5a7793c526ebaff3
src/logicalfile/file.h b7ecb53cf43ee2f290c5bbdf091165c81b86ac2d
src/logicalfile/file.c ca0d9f4e88d1b4b78ee7104eb88f676ab30535af
src/logicalfile/test/test_basic.py fbcf6d57829d35e134cfdedab9501043fd3c372a
Diff:
http://reviewboard-openlmi.rhcloud.com/r/859/diff/
Testing
-------
Thanks,
Jan Synacek
_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews