Re: Review Request 854: [1/1] Account: Added QA test for account provider.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/
-----------------------------------------------------------

(Updated Sept. 16, 2013, 7:27 a.m.)


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Account: Added QA test for account provider.


Diffs (updated)
-----

  src/account/test/testAccount.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/


Testing
-------


Thanks,

Robin Hack


_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

Review Request 854: [1/1] Account: Added QA test for account provider.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/#review1178
-----------------------------------------------------------



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment728>

    User really exists after this call?
    Assert missing.



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment729>

    We need separate test case for deleteing user and group... because we need map this
cases to tcms when test will be parametrized.



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment730>

    What is this magic numbers?


- Robin Hack


On Sept. 16, 2013, 7:27 a.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/854/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 16, 2013, 7:27 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Account: Added QA test for account provider.
>  
>  
>  Diffs
>  -----
>  
>    src/account/test/testAccount.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>  

_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

Review Request 854: [1/1] Account: Added QA test for account provider.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/
-----------------------------------------------------------

(Updated Sept. 16, 2013, 8:57 a.m.)


Review request for OpenLMI Developers.


Changes
-------

Qa test from psklenar.


Repository: openlmi-providers


Description
-------

Account: Added QA test for account provider.


Diffs (updated)
-----

  src/account/test/testAccount.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/


Testing
-------


Thanks,

Robin Hack


_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

Review Request 854: [1/1] Account: Added QA test for account provider.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/#review1179
-----------------------------------------------------------



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment734>

    Magic numbers.



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment732>

    Test for the inverse set of characters would be nice. This asserts, that *one char*
usernames are accepted.



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment731>

    These magic numbers are not well readable. Maybe you could use something like:
    badchar = [chr(i) for i in xrange(0, 128) if chr(i) not in set(string.ascii_letters +
string.digits + '$_')]



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment733>

    If an assertion fails, examiner has to test each character from the badchar set until
he finds out, which one caused it. I'd recommend add some description string like:
    self.assertEqual(user.rval, -1, 'account with invalid username "%s"
created')


- Michal Minar


On Sept. 16, 2013, 8:57 a.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/854/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 16, 2013, 8:57 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Account: Added QA test for account provider.
>  
>  
>  Diffs
>  -----
>  
>    src/account/test/testAccount.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>  

_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews