Review Request 255: Fixed LMI_ConcreteJob.GetError and .GetErrors to return correct CIM instance.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/255/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Fixed LMI_ConcreteJob.GetError and .GetErrors to return correct CIM instance.

We should return CIMInstance instead of CIMError (which has nothing to do with
CIM_Error).


Diffs
-----

  src/python/openlmi/common/JobManager.py 5ed783069c7fdd5a0eaa08d346434daab520b7e9 

Diff: http://reviewboard-openlmi.rhcloud.com/r/255/diff/


Testing
-------


Thanks,

Jan Safranek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/255/#review293
-----------------------------------------------------------

Ship it!


Ship It!

- Michal Minar


On April 25, 2013, 8:59 a.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/255/
>  -----------------------------------------------------------
>  
>  (Updated April 25, 2013, 8:59 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Fixed LMI_ConcreteJob.GetError and .GetErrors to return correct CIM instance.
>  
>  We should return CIMInstance instead of CIMError (which has nothing to do with
>  CIM_Error).
>  
>  
>  Diffs
>  -----
>  
>    src/python/openlmi/common/JobManager.py 5ed783069c7fdd5a0eaa08d346434daab520b7e9 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/255/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/255/
-----------------------------------------------------------

(Updated April 25, 2013, 11:14 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Fixed LMI_ConcreteJob.GetError and .GetErrors to return correct CIM instance.

We should return CIMInstance instead of CIMError (which has nothing to do with
CIM_Error).


Diffs
-----

  src/python/openlmi/common/JobManager.py 5ed783069c7fdd5a0eaa08d346434daab520b7e9 

Diff: http://reviewboard-openlmi.rhcloud.com/r/255/diff/


Testing
-------


Thanks,

Jan Safranek