Review Request 32: Patch05: Added LMI_FileSystemConfigurationService.DeleteFileSystem.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/32/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-storage


Description
-------

Added LMI_FileSystemConfigurationService.DeleteFileSystem.


Diffs
-----

  mof/filesystem.mof 2b6eada9926671e34782ee795a6934c1cdb6adc6 
  src/openlmi/storage/LMI_FileSystemConfigurationService.py
2a9c94d26cf63c86ce42edf681b6f0716cce7d1a 
  src/openlmi/storage/ProviderManager.py 3b107f8d895ea5d4a2912f018e04035733a7a009 

Diff: http://reviewboard-openlmi.rhcloud.com/r/32/diff/


Testing
-------


Thanks,

Jan Safranek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/32/#review28
-----------------------------------------------------------



mof/filesystem.mof
<http://reviewboard-openlmi.rhcloud.com/r/32/#comment34>

    ManagedElement is too much generic referenced class. Is it possible to specify some
subclass?


- Roman Rakus


On March 22, 2013, 4:40 p.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/32/
>  -----------------------------------------------------------
>  
>  (Updated March 22, 2013, 4:40 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-storage
>  
>  
>  Description
>  -------
>  
>  Added LMI_FileSystemConfigurationService.DeleteFileSystem.
>  
>  
>  Diffs
>  -----
>  
>    mof/filesystem.mof 2b6eada9926671e34782ee795a6934c1cdb6adc6 
>    src/openlmi/storage/LMI_FileSystemConfigurationService.py
> 2a9c94d26cf63c86ce42edf681b6f0716cce7d1a 
>    src/openlmi/storage/ProviderManager.py 3b107f8d895ea5d4a2912f018e04035733a7a009 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/32/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

>  On March 25, 2013, 12:30 p.m., Roman Rakus wrote:
>  > mof/filesystem.mof, line 253
>  > <http://reviewboard-openlmi.rhcloud.com/r/32/diff/1/?file=155#file155line2...
>  >
>  >     ManagedElement is too much generic referenced class. Is it possible to specify
> some subclass? 
openlmi-doc-class2rst, our documentation generator based on KonkretCMPI MOF parser, throws
an error when parsing the MOF file with LMI_LocalFileSystem instead of CIM_ManagedElement.
So I won't change it.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/32/#review28
-----------------------------------------------------------


On March 22, 2013, 5:40 p.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/32/
>  -----------------------------------------------------------
>  
>  (Updated March 22, 2013, 5:40 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-storage
>  
>  
>  Description
>  -------
>  
>  Added LMI_FileSystemConfigurationService.DeleteFileSystem.
>  
>  
>  Diffs
>  -----
>  
>    mof/filesystem.mof 2b6eada9926671e34782ee795a6934c1cdb6adc6 
>    src/openlmi/storage/LMI_FileSystemConfigurationService.py
> 2a9c94d26cf63c86ce42edf681b6f0716cce7d1a 
>    src/openlmi/storage/ProviderManager.py 3b107f8d895ea5d4a2912f018e04035733a7a009 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/32/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/32/
-----------------------------------------------------------

(Updated March 26, 2013, 3:27 p.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-storage


Description
-------

Added LMI_FileSystemConfigurationService.DeleteFileSystem.


Diffs
-----

  mof/filesystem.mof 2b6eada9926671e34782ee795a6934c1cdb6adc6 
  src/openlmi/storage/LMI_FileSystemConfigurationService.py
2a9c94d26cf63c86ce42edf681b6f0716cce7d1a 
  src/openlmi/storage/ProviderManager.py 3b107f8d895ea5d4a2912f018e04035733a7a009 

Diff: http://reviewboard-openlmi.rhcloud.com/r/32/diff/


Testing
-------


Thanks,

Jan Safranek