Review Request 164: Preparation for 0.5.1: [1/14] Remove LMI_ConcreteJob definition, it's now in openlmi-providers.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/164/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-storage


Description
-------

Remove LMI_ConcreteJob definition, it's now in openlmi-providers.

Whole patchset is available at:
https://github.com/jsafrane/openlmi-storage/tree/v0.5.1.prep


Diffs
-----

  doc/admin/generated/Makefile e01a7e53d3c11d5f592cb332d12af9fe256c4a75 
  doc/admin/mof/Makefile 74170c9780aaa2d8abfe18e694626c5f8abc3c09 
  mof/jobs.mof b8b2b8353e87f781ab79cc53b9ca6a0a89f0171a 

Diff: http://reviewboard-openlmi.rhcloud.com/r/164/diff/


Testing
-------


Thanks,

Jan Safranek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/164/#review165
-----------------------------------------------------------


What's the difference between this review request and
https://reviewboard-openlmi.rhcloud.com/r/145/ ? Seems same to me

- Radek Novacek


On April 10, 2013, 3:47 p.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/164/
>  -----------------------------------------------------------
>  
>  (Updated April 10, 2013, 3:47 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-storage
>  
>  
>  Description
>  -------
>  
>  Remove LMI_ConcreteJob definition, it's now in openlmi-providers.
>  
>  Whole patchset is available at:
> https://github.com/jsafrane/openlmi-storage/tree/v0.5.1.prep
>  
>  
>  Diffs
>  -----
>  
>    doc/admin/generated/Makefile e01a7e53d3c11d5f592cb332d12af9fe256c4a75 
>    doc/admin/mof/Makefile 74170c9780aaa2d8abfe18e694626c5f8abc3c09 
>    mof/jobs.mof b8b2b8353e87f781ab79cc53b9ca6a0a89f0171a 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/164/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

>  On April 10, 2013, 3:56 p.m., Radek Novacek wrote:
>  > What's the difference between this review request and
> https://reviewboard-openlmi.rhcloud.com/r/145/ ? Seems same to me 
#145 was accidentally submitted and dropped.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/164/#review165
-----------------------------------------------------------


On April 10, 2013, 3:47 p.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/164/
>  -----------------------------------------------------------
>  
>  (Updated April 10, 2013, 3:47 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-storage
>  
>  
>  Description
>  -------
>  
>  Remove LMI_ConcreteJob definition, it's now in openlmi-providers.
>  
>  Whole patchset is available at:
> https://github.com/jsafrane/openlmi-storage/tree/v0.5.1.prep
>  
>  
>  Diffs
>  -----
>  
>    doc/admin/generated/Makefile e01a7e53d3c11d5f592cb332d12af9fe256c4a75 
>    doc/admin/mof/Makefile 74170c9780aaa2d8abfe18e694626c5f8abc3c09 
>    mof/jobs.mof b8b2b8353e87f781ab79cc53b9ca6a0a89f0171a 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/164/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/164/#review166
-----------------------------------------------------------

Ship it!


Ship It!

- Radek Novacek


On April 10, 2013, 3:47 p.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/164/
>  -----------------------------------------------------------
>  
>  (Updated April 10, 2013, 3:47 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-storage
>  
>  
>  Description
>  -------
>  
>  Remove LMI_ConcreteJob definition, it's now in openlmi-providers.
>  
>  Whole patchset is available at:
> https://github.com/jsafrane/openlmi-storage/tree/v0.5.1.prep
>  
>  
>  Diffs
>  -----
>  
>    doc/admin/generated/Makefile e01a7e53d3c11d5f592cb332d12af9fe256c4a75 
>    doc/admin/mof/Makefile 74170c9780aaa2d8abfe18e694626c5f8abc3c09 
>    mof/jobs.mof b8b2b8353e87f781ab79cc53b9ca6a0a89f0171a 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/164/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/164/
-----------------------------------------------------------

(Updated April 10, 2013, 4:25 p.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-storage


Description
-------

Remove LMI_ConcreteJob definition, it's now in openlmi-providers.

Whole patchset is available at:
https://github.com/jsafrane/openlmi-storage/tree/v0.5.1.prep


Diffs
-----

  doc/admin/generated/Makefile e01a7e53d3c11d5f592cb332d12af9fe256c4a75 
  doc/admin/mof/Makefile 74170c9780aaa2d8abfe18e694626c5f8abc3c09 
  mof/jobs.mof b8b2b8353e87f781ab79cc53b9ca6a0a89f0171a 

Diff: http://reviewboard-openlmi.rhcloud.com/r/164/diff/


Testing
-------


Thanks,

Jan Safranek