----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/267/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description -------
Added mandatory LMI_LocalFileSystem properties.
Properties like file system size and free space are mandatory and also highly useful.
Diffs -----
src/openlmi/storage/LocalFileSystemProvider.py 42be4c5519dcd6edb4abe0614236e0b36ec6b9e5
Diff: http://reviewboard-openlmi.rhcloud.com/r/267/diff/
Testing -------
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/267/#review313 -----------------------------------------------------------
src/openlmi/storage/LocalFileSystemProvider.py http://reviewboard-openlmi.rhcloud.com/r/267/#comment202
This looks like there should be (fmt.resizable == False). IOW if it's not resizable, its size is fixed.
- Jan Synacek
On April 26, 2013, 12:37 p.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/267/
(Updated April 26, 2013, 12:37 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
Added mandatory LMI_LocalFileSystem properties.
Properties like file system size and free space are mandatory and also highly useful.
Diffs
src/openlmi/storage/LocalFileSystemProvider.py 42be4c5519dcd6edb4abe0614236e0b36ec6b9e5
Diff: http://reviewboard-openlmi.rhcloud.com/r/267/diff/
Testing
Thanks,
Jan Safranek
On April 26, 2013, 12:41 p.m., Jan Synacek wrote:
src/openlmi/storage/LocalFileSystemProvider.py, line 324 http://reviewboard-openlmi.rhcloud.com/r/267/diff/1/?file=1479#file1479line324
This looks like there should be (fmt.resizable == False). IOW if it's not resizable, its size is fixed.
Good catch, I'll fix it before pushing.
- Jan
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/267/#review313 -----------------------------------------------------------
On April 26, 2013, 12:37 p.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/267/
(Updated April 26, 2013, 12:37 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
Added mandatory LMI_LocalFileSystem properties.
Properties like file system size and free space are mandatory and also highly useful.
Diffs
src/openlmi/storage/LocalFileSystemProvider.py 42be4c5519dcd6edb4abe0614236e0b36ec6b9e5
Diff: http://reviewboard-openlmi.rhcloud.com/r/267/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/267/#review321 -----------------------------------------------------------
Ship it!
Ship It!
- Jan Synacek
On April 26, 2013, 12:37 p.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/267/
(Updated April 26, 2013, 12:37 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
Added mandatory LMI_LocalFileSystem properties.
Properties like file system size and free space are mandatory and also highly useful.
Diffs
src/openlmi/storage/LocalFileSystemProvider.py 42be4c5519dcd6edb4abe0614236e0b36ec6b9e5
Diff: http://reviewboard-openlmi.rhcloud.com/r/267/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/267/ -----------------------------------------------------------
(Updated April 30, 2013, 9:11 a.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description -------
Added mandatory LMI_LocalFileSystem properties.
Properties like file system size and free space are mandatory and also highly useful.
Diffs -----
src/openlmi/storage/LocalFileSystemProvider.py 42be4c5519dcd6edb4abe0614236e0b36ec6b9e5
Diff: http://reviewboard-openlmi.rhcloud.com/r/267/diff/
Testing -------
Thanks,
Jan Safranek
openlmi-devel@lists.fedorahosted.org
-
Stephen Gallagher