Review Request 223: [2/6] Add string_to_string_array().

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/223/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-storage


Description
-------

Add string_to_string_array().

Convenient method that takes a python string and converts it to a python array.
It uses eval(), but the values are sanitized before use.


Diffs
-----

  src/openlmi/storage/SettingProvider.py 40fd13cef373934b1eb8690ed6ea31079d586a6d 

Diff: http://reviewboard-openlmi.rhcloud.com/r/223/diff/


Testing
-------


Thanks,

Jan Synacek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/223/#review243
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Safranek


On April 17, 2013, 10:10 a.m., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/223/
>  -----------------------------------------------------------
>  
>  (Updated April 17, 2013, 10:10 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-storage
>  
>  
>  Description
>  -------
>  
>  Add string_to_string_array().
>  
>  Convenient method that takes a python string and converts it to a python array.
>  It uses eval(), but the values are sanitized before use.
>  
>  
>  Diffs
>  -----
>  
>    src/openlmi/storage/SettingProvider.py 40fd13cef373934b1eb8690ed6ea31079d586a6d 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/223/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/223/
-----------------------------------------------------------

(Updated April 17, 2013, 1:18 p.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-storage


Description
-------

Add string_to_string_array().

Convenient method that takes a python string and converts it to a python array.
It uses eval(), but the values are sanitized before use.


Diffs
-----

  src/openlmi/storage/SettingProvider.py 40fd13cef373934b1eb8690ed6ea31079d586a6d 

Diff: http://reviewboard-openlmi.rhcloud.com/r/223/diff/


Testing
-------


Thanks,

Jan Synacek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/223/#review255
-----------------------------------------------------------



src/openlmi/storage/SettingProvider.py
<http://reviewboard-openlmi.rhcloud.com/r/223/#comment161>

    You should at least use ast.literal_eval which is much safer.
    
    http://docs.python.org/2/library/ast.html#ast.literal_eval


- Radek Novacek


On April 17, 2013, 1:18 p.m., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/223/
>  -----------------------------------------------------------
>  
>  (Updated April 17, 2013, 1:18 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-storage
>  
>  
>  Description
>  -------
>  
>  Add string_to_string_array().
>  
>  Convenient method that takes a python string and converts it to a python array.
>  It uses eval(), but the values are sanitized before use.
>  
>  
>  Diffs
>  -----
>  
>    src/openlmi/storage/SettingProvider.py 40fd13cef373934b1eb8690ed6ea31079d586a6d 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/223/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>