Review Request 872: openlmi-providers [4/4] Priority of traces should be lower than priority of DEBUG log messages

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/872/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Priority of traces should be lower than priority of DEBUG log messages


Diffs
-----

  src/python/lmi/providers/cmpi_logging.py ca24601c61af2f667f50845a9e2023b50c1e7a46 
  src/software/config/software.conf 0332ecdea278d5f91df96ba1ffab96ca4935d3cd 

Diff: http://reviewboard-openlmi.rhcloud.com/r/872/diff/


Testing
-------


Thanks,

Radek Novacek


_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/872/#review1189
-----------------------------------------------------------


There use to be a similar piece of debugging code hardcoded somewhere in the C providers.
Shouldn't that be changed as well?

- Jan Synacek


On Sept. 18, 2013, 8:31 a.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/872/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 18, 2013, 8:31 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Priority of traces should be lower than priority of DEBUG log messages
>  
>  
>  Diffs
>  -----
>  
>    src/python/lmi/providers/cmpi_logging.py ca24601c61af2f667f50845a9e2023b50c1e7a46 
>    src/software/config/software.conf 0332ecdea278d5f91df96ba1ffab96ca4935d3cd 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/872/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>  

_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

[Stephen Gallagher]

>  On Sept. 18, 2013, 9:48 a.m., Jan Synacek wrote:
>  > There use to be a similar piece of debugging code hardcoded somewhere in the C
> providers. Shouldn't that be changed as well? 
s/use/used/


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/872/#review1189
-----------------------------------------------------------


On Sept. 18, 2013, 8:31 a.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/872/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 18, 2013, 8:31 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Priority of traces should be lower than priority of DEBUG log messages
>  
>  
>  Diffs
>  -----
>  
>    src/python/lmi/providers/cmpi_logging.py ca24601c61af2f667f50845a9e2023b50c1e7a46 
>    src/software/config/software.conf 0332ecdea278d5f91df96ba1ffab96ca4935d3cd 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/872/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>  

_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

[Stephen Gallagher]

>  On Sept. 18, 2013, 9:48 a.m., Jan Synacek wrote:
>  > There use to be a similar piece of debugging code hardcoded somewhere in the C
> providers. Shouldn't that be changed as well?
>  
>  Jan Synacek wrote:
>      s/use/used/ 
C providers don't use tracing now, so they don't need to be fixed.


- Radek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/872/#review1189
-----------------------------------------------------------


On Sept. 18, 2013, 8:31 a.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/872/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 18, 2013, 8:31 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Priority of traces should be lower than priority of DEBUG log messages
>  
>  
>  Diffs
>  -----
>  
>    src/python/lmi/providers/cmpi_logging.py ca24601c61af2f667f50845a9e2023b50c1e7a46 
>    src/software/config/software.conf 0332ecdea278d5f91df96ba1ffab96ca4935d3cd 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/872/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>  

_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/872/#review1193
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Synacek


On Sept. 18, 2013, 8:31 a.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/872/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 18, 2013, 8:31 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Priority of traces should be lower than priority of DEBUG log messages
>  
>  
>  Diffs
>  -----
>  
>    src/python/lmi/providers/cmpi_logging.py ca24601c61af2f667f50845a9e2023b50c1e7a46 
>    src/software/config/software.conf 0332ecdea278d5f91df96ba1ffab96ca4935d3cd 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/872/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>  

_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/872/
-----------------------------------------------------------

(Updated Sept. 19, 2013, 9:20 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Priority of traces should be lower than priority of DEBUG log messages


Diffs
-----

  src/python/lmi/providers/cmpi_logging.py ca24601c61af2f667f50845a9e2023b50c1e7a46 
  src/software/config/software.conf 0332ecdea278d5f91df96ba1ffab96ca4935d3cd 

Diff: http://reviewboard-openlmi.rhcloud.com/r/872/diff/


Testing
-------


Thanks,

Radek Novacek


_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews