Review Request 121: openlmi-software [5/7] added support for indications to software providers

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/121/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

added support for indications to software providers

Only static indication filters listed in
mof/LMI_SoftwareIndicationFilters.mof are supported. They should be
installed at rpm package installation, so user can use them for
subscriptions.


Diffs
-----

  mof/LMI_Software.mof 824659ef1770db91f1c1ee2874cf90f4829d5756 
  mof/LMI_Software.reg d8e05ee34b259caae8492ad5003fff6ada499db4 
  mof/LMI_SoftwareIndicationFilters.mof PRE-CREATION 
  src/python/openlmi/common/JobManager.py PRE-CREATION 
  src/software/openlmi/software/cimom_entry.py 4aa1d44b24b811197f8e316084ea7fdf3774857a 
  src/software/openlmi/software/yumdb/__init__.py d64c0f43a6d1aeabd31eca193becff76f6d6e4de

  src/software/openlmi/software/yumdb/errors.py 101c40ba507e6557bd515d75dabc3d920fc105ec 
  src/software/openlmi/software/yumdb/jobmanager.py
872e81fecf030743d89d41d0436a2cb5cd1fb878 
  src/software/openlmi/software/yumdb/process.py 0b0c4c17521595a414c487cc1931266c5584e690


Diff: http://reviewboard-openlmi.rhcloud.com/r/121/diff/


Testing
-------


Thanks,

Michal Minar

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/121/#review141
-----------------------------------------------------------



mof/LMI_SoftwareIndicationFilters.mof
<http://reviewboard-openlmi.rhcloud.com/r/121/#comment100>

    (discussed offline, just for the record) please make sure these queries works in
SFCB.



src/python/openlmi/common/JobManager.py
<http://reviewboard-openlmi.rhcloud.com/r/121/#comment101>

    Whole Job class looks very similar to Job in openlmi-storage, could you please push
whole patchset to some git repo (fedorapeople, github, ...) so I can compare it?


- Jan Safranek


On April 8, 2013, 12:07 p.m., Michal Minar wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/121/
>  -----------------------------------------------------------
>  
>  (Updated April 8, 2013, 12:07 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  added support for indications to software providers
>  
>  Only static indication filters listed in
>  mof/LMI_SoftwareIndicationFilters.mof are supported. They should be
>  installed at rpm package installation, so user can use them for
>  subscriptions.
>  
>  
>  Diffs
>  -----
>  
>    mof/LMI_Software.mof 824659ef1770db91f1c1ee2874cf90f4829d5756 
>    mof/LMI_Software.reg d8e05ee34b259caae8492ad5003fff6ada499db4 
>    mof/LMI_SoftwareIndicationFilters.mof PRE-CREATION 
>    src/python/openlmi/common/JobManager.py PRE-CREATION 
>    src/software/openlmi/software/cimom_entry.py 4aa1d44b24b811197f8e316084ea7fdf3774857a 
>    src/software/openlmi/software/yumdb/__init__.py
> d64c0f43a6d1aeabd31eca193becff76f6d6e4de 
>    src/software/openlmi/software/yumdb/errors.py 101c40ba507e6557bd515d75dabc3d920fc105ec
>
>    src/software/openlmi/software/yumdb/jobmanager.py
> 872e81fecf030743d89d41d0436a2cb5cd1fb878 
>    src/software/openlmi/software/yumdb/process.py 0b0c4c17521595a414c487cc1931266c5584e690
>
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/121/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Michal Minar
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/121/#review197
-----------------------------------------------------------

Ship it!


Apart from testing CQL queries in SFCB, the patch looks OK.

- Jan Safranek


On April 8, 2013, 12:07 p.m., Michal Minar wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/121/
>  -----------------------------------------------------------
>  
>  (Updated April 8, 2013, 12:07 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  added support for indications to software providers
>  
>  Only static indication filters listed in
>  mof/LMI_SoftwareIndicationFilters.mof are supported. They should be
>  installed at rpm package installation, so user can use them for
>  subscriptions.
>  
>  
>  Diffs
>  -----
>  
>    mof/LMI_Software.mof 824659ef1770db91f1c1ee2874cf90f4829d5756 
>    mof/LMI_Software.reg d8e05ee34b259caae8492ad5003fff6ada499db4 
>    mof/LMI_SoftwareIndicationFilters.mof PRE-CREATION 
>    src/python/openlmi/common/JobManager.py PRE-CREATION 
>    src/software/openlmi/software/cimom_entry.py 4aa1d44b24b811197f8e316084ea7fdf3774857a 
>    src/software/openlmi/software/yumdb/__init__.py
> d64c0f43a6d1aeabd31eca193becff76f6d6e4de 
>    src/software/openlmi/software/yumdb/errors.py 101c40ba507e6557bd515d75dabc3d920fc105ec
>
>    src/software/openlmi/software/yumdb/jobmanager.py
> 872e81fecf030743d89d41d0436a2cb5cd1fb878 
>    src/software/openlmi/software/yumdb/process.py 0b0c4c17521595a414c487cc1931266c5584e690
>
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/121/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Michal Minar
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/121/
-----------------------------------------------------------

(Updated April 11, 2013, 4:19 p.m.)


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

added support for indications to software providers

Only static indication filters listed in
mof/LMI_SoftwareIndicationFilters.mof are supported. They should be
installed at rpm package installation, so user can use them for
subscriptions.


Diffs (updated)
-----

  src/software/openlmi/software/yumdb/__init__.py c992608e35e30b71fb32c092ac296d5e90b68839

  src/software/openlmi/software/yumdb/process.py 0b0c4c17521595a414c487cc1931266c5584e690

  src/software/openlmi/software/yumdb/errors.py 101c40ba507e6557bd515d75dabc3d920fc105ec 
  src/software/openlmi/software/cimom_entry.py 6c37c9ae4160220217df19006d5eb3e4123aefe7 
  src/software/openlmi/software/LMI_SoftwareInstallationService.py
84f957a448edd2f3d4945736c339adbc33087809 
  src/python/openlmi/common/JobManager.py PRE-CREATION 
  mof/LMI_Software.reg d8e05ee34b259caae8492ad5003fff6ada499db4 
  mof/LMI_Software.mof 824659ef1770db91f1c1ee2874cf90f4829d5756 

Diff: http://reviewboard-openlmi.rhcloud.com/r/121/diff/


Testing
-------


Thanks,

Michal Minar

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/121/
-----------------------------------------------------------

(Updated April 11, 2013, 4:28 p.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

added support for indications to software providers

Only static indication filters listed in
mof/LMI_SoftwareIndicationFilters.mof are supported. They should be
installed at rpm package installation, so user can use them for
subscriptions.


Diffs
-----

  src/software/openlmi/software/yumdb/__init__.py c992608e35e30b71fb32c092ac296d5e90b68839

  src/software/openlmi/software/yumdb/process.py 0b0c4c17521595a414c487cc1931266c5584e690

  src/software/openlmi/software/yumdb/errors.py 101c40ba507e6557bd515d75dabc3d920fc105ec 
  src/software/openlmi/software/cimom_entry.py 6c37c9ae4160220217df19006d5eb3e4123aefe7 
  src/software/openlmi/software/LMI_SoftwareInstallationService.py
84f957a448edd2f3d4945736c339adbc33087809 
  src/python/openlmi/common/JobManager.py PRE-CREATION 
  mof/LMI_Software.reg d8e05ee34b259caae8492ad5003fff6ada499db4 
  mof/LMI_Software.mof 824659ef1770db91f1c1ee2874cf90f4829d5756 

Diff: http://reviewboard-openlmi.rhcloud.com/r/121/diff/


Testing
-------


Thanks,

Michal Minar